Installer fixes

This commit is contained in:
crschnick 2024-02-23 13:17:25 +00:00
parent ce113746a6
commit 96848146c5
2 changed files with 5 additions and 5 deletions

View file

@ -195,9 +195,9 @@ public interface ExternalTerminalType extends PrefsChoiceValue {
@Override
protected void execute(Path file, LaunchConfiguration configuration) throws Exception {
ApplicationHelper.executeLocalApplication(
CommandBuilder.of().addFile(file.toString()).add("run").addFile(configuration.getScriptFile()),
true);
// Tabby has a very weird handling of output, even detaching with start does not prevent it from printing
LocalShell.getShell().executeSimpleCommand(
CommandBuilder.of().addFile(file.toString()).add("run").addFile(configuration.getScriptFile()).discardOutput());
}
@Override

View file

@ -74,11 +74,11 @@ public class AppInstaller {
String.format(
"""
cd /D "%%HOMEDRIVE%%%%HOMEPATH%%"
start "" /wait msiexec /i "%s" /l* "%s" /qb
start "" /wait msiexec /i "%s" /lv "%s" /qb
start "" "%s"
""",
file, logFile, exec));
shellProcessControl.executeSimpleCommand("start \"\" /min \"" + script + "\"");
shellProcessControl.executeSimpleCommand("start \"\" /min cmd /c \"" + script + "\"");
}
@Override