Disable fast terminal startup for now

app/src/main/java/io/xpipe/app/prefs/AppPrefs.java

@@ -636,8 +636,9 @@ public class AppPrefs {
                                 Setting.of("customTerminalCommand", customTerminalCommandControl, customTerminalCommand)
                                         .applyVisibility(VisibilityProperty.of(
                                                 terminalType.isEqualTo(ExternalTerminalType.CUSTOM))),
-                                Setting.of("preferTerminalTabs", preferTerminalTabsField, preferTerminalTabs),
-                                Setting.of("enableFastTerminalStartup", enableFastTerminalStartupField, enableFastTerminalStartup))),
+                                Setting.of("preferTerminalTabs", preferTerminalTabsField, preferTerminalTabs)
+                                //Setting.of("enableFastTerminalStartup", enableFastTerminalStartupField, enableFastTerminalStartup)
+                                )),
                 new DeveloperCategory(this).create(),
                 Category.of("troubleshoot", Group.of(troubleshoot))));
 

dist/changelogs/1.7.12.md

@@ -6,13 +6,7 @@
 
 ## Changes
 
-- Add setting to optimize terminal launching performance.
-  When no scripts, environment, or custom title/color are enabled for a connection,
-  it will now be instantly launched in a terminal without verifying the connection first.
-  This will speed up the process but will move any occurring errors into the terminal window.
-  It also fixes any login banners not being shown.
-  You can enable this under Settings -> Terminal
-- Make current default shell also show up in shell environments to prevent confusion about missing `bash`
+- Make current default shell also show up in shell environments to prevent confusion about missing bash environment
 - Improve error messages when an additional password was requested by the connection
   when none was provided instead of just showing permission denied
 - Make SSH connection starting from a WSL environment use the native Windows key helper for FIDO2 keys
@@ -33,14 +27,14 @@
 - Fix application not starting on Asahi Linux due to executable page size issue
 - Fix file existence check for SSH key files reporting wrong results on Windows in directory links/junctions
 - Fix k8s integration not working when user did not have permission to list nodes
-- Fix rare error when switching to tray operation mode
+- Fix rare error when switching to tray operation mode on Linux
 - Fix connection state not being preserved when being added the first time
 - Fix application failing to start up if OS reported invalid screen size bounds
 - Fix VMware VM not being able to be parsed if configuration file did not specify an encoding or name
 - Fix startup failing when installation was located on a ramdisk
 - Fix some miscellaneous cache data being stored in the user home directory
 - Fix error handling when jump host chain formed a loop
-- Fix PowerShell a remote session being blocked by execution policy
+- Fix PowerShell remote sessions being blocked by execution policy
 - Fix race condition when locking user data directory
 - Fix some CLI commands not starting daemon correctly if it is not already running
 - Fix text field when showing askpass window not being focused automatically
@@ -50,4 +44,4 @@
 ## Preview pro features
 
 For anyone interested in giving any new professional features a try without having to commit to buying a full license,
-there is now a special preview mode available: Simply enter the license key `D18D1C9F-D3CB-49CA-A909-FF385DECD948` and get full access to newly released professional features for two weeks after their initial release date. In fact, you can try it out right now to get access to the new SSH authentication features.
+there is now a special preview mode available: Simply enter the license key `D18D1C9F-D3CB-49CA-A909-FF385DECD948` and get full access to newly released professional features for two weeks after their initial release date. In fact, you can try it out right now to get access to the new vscode file browser integration.

ext/base/src/main/java/io/xpipe/ext/base/script/ScriptStore.java

@@ -35,6 +35,11 @@ public abstract class ScriptStore extends JacksonizedValue implements DataStore,
             var initFlattened = flatten(initScripts);
             var bringFlattened = flatten(bringScripts);
 
+            // Optimize if we have nothing to do
+            if (initFlattened.isEmpty() && bringFlattened.isEmpty()) {
+                return pc;
+            }
+
             pc.onInit(shellControl -> {
                 passInitScripts(pc, initFlattened);