beenull/standardnotes-server
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

feat: remove api metadata decorating html responses

Browse source
This commit is contained in:
Karol Sójko 2022-06-28 14:10:40 +02:00
parent 7c271be310
commit 3035cbc5de
No known key found for this signature in database
GPG key ID: A50543BF560BDEB0
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/api-gateway/src/Service/Http/HttpService.ts
View file

@ -162,6 +162,12 @@ export class HttpService implements HttpServiceInterface {
this.applyResponseHeaders(serviceResponse, response) this.applyResponseHeaders(serviceResponse, response)
if (this.responseShouldNotBeDecorated(serviceResponse)) {
response.status(serviceResponse.status).send(serviceResponse.data)
return
}
response.status(serviceResponse.status).send({ response.status(serviceResponse.status).send({
meta: { meta: {
auth: { auth: {
@ -213,6 +219,10 @@ export class HttpService implements HttpServiceInterface {
return payload return payload
} }
private responseShouldNotBeDecorated(serviceResponse: AxiosResponse): boolean {
return serviceResponse.headers['content-type'].toLowerCase().includes('text/html')
}
private applyResponseHeaders(serviceResponse: AxiosResponse, response: Response): void { private applyResponseHeaders(serviceResponse: AxiosResponse, response: Response): void {
const returnedHeadersFromUnderlyingService = [ const returnedHeadersFromUnderlyingService = [
'access-control-allow-methods', 'access-control-allow-methods',