beenull/sftpgo
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove robots.txt endpoint

Browse source 
This reverts #833 because the contributor did not respond to our
request to sign the CLA

Signed-off-by: Nicola Murino <nicola.murino@gmail.com>
This commit is contained in:
Nicola Murino 2024-04-26 11:00:55 +02:00
parent 26d19abf61
commit e1fdc10ef8
No known key found for this signature in database
GPG key ID: 935D2952DEC4EECF
3 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
internal/httpd/httpd.go
View file

@ -95,7 +95,6 @@ const (
rolesPath = "/api/v2/roles" rolesPath = "/api/v2/roles"
ipListsPath = "/api/v2/iplists" ipListsPath = "/api/v2/iplists"
healthzPath = "/healthz" healthzPath = "/healthz"
robotsTxtPath = "/robots.txt"
webRootPathDefault = "/" webRootPathDefault = "/"
webBasePathDefault = "/web" webBasePathDefault = "/web"
webBasePathAdminDefault = "/web/admin" webBasePathAdminDefault = "/web/admin"

8
internal/httpd/httpd_test.go
View file

@ -131,7 +131,6 @@ const (
rolesPath = "/api/v2/roles" rolesPath = "/api/v2/roles"
ipListsPath = "/api/v2/iplists" ipListsPath = "/api/v2/iplists"
healthzPath = "/healthz" healthzPath = "/healthz"
robotsTxtPath = "/robots.txt"
webBasePath = "/web" webBasePath = "/web"
webBasePathAdmin = "/web/admin" webBasePathAdmin = "/web/admin"
webAdminSetupPath = "/web/admin/setup" webAdminSetupPath = "/web/admin/setup"
@ -12512,13 +12511,6 @@ func TestHealthCheck(t *testing.T) {
assert.Equal(t, "ok", rr.Body.String()) assert.Equal(t, "ok", rr.Body.String())
} }
func TestRobotsTxtCheck(t *testing.T) {
req, _ := http.NewRequest(http.MethodGet, robotsTxtPath, nil)
rr := executeRequest(req)
checkResponseCode(t, http.StatusOK, rr)
assert.Equal(t, "User-agent: *\nDisallow: /", rr.Body.String())
}
func TestGetWebRootMock(t *testing.T) { func TestGetWebRootMock(t *testing.T) {
req, _ := http.NewRequest(http.MethodGet, "/", nil) req, _ := http.NewRequest(http.MethodGet, "/", nil)
rr := executeRequest(req) rr := executeRequest(req)

4
internal/httpd/server.go
View file

@ -1284,10 +1284,6 @@ func (s *httpdServer) initializeRouter() {
render.PlainText(w, r, "ok") render.PlainText(w, r, "ok")
}) })
s.router.Get(robotsTxtPath, func(w http.ResponseWriter, r *http.Request) {
render.PlainText(w, r, "User-agent: *\nDisallow: /")
})
if hasHTTPSRedirect { if hasHTTPSRedirect {
if p := acme.GetHTTP01WebRoot(); p != "" { if p := acme.GetHTTP01WebRoot(); p != "" {
serveStaticDir(s.router, acmeChallengeURI, p, true) serveStaticDir(s.router, acmeChallengeURI, p, true)