sql providers: remove prepared statements

preparing a statement without reusing it is useless

Signed-off-by: Nicola Murino <nicola.murino@gmail.com>

pkgs/choco/sftpgo.nuspec

@@ -0,0 +1,40 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--Do not remove this test for UTF-8: if “Ω” doesn’t appear as greek uppercase omega letter enclosed in quotation marks, you should use an editor that supports UTF-8, not this one.-->
+<package xmlns="http://schemas.microsoft.com/packaging/2015/06/nuspec.xsd">
+	<metadata>
+		<id>sftpgo</id>
+		<version>2.3.1</version>
+		<packageSourceUrl>https://github.com/asheroto/ChocolateyPackages/tree/master/SFTPGo</packageSourceUrl>
+		<owners>asheroto</owners>
+		<title>SFTPGo</title>
+		<authors>Nicola Murino</authors>
+		<projectUrl>https://github.com/drakkan/sftpgo</projectUrl>
+		<iconUrl>https://cdn.statically.io/gh/drakkan/sftpgo/v2.3.1/static/img/logo.png</iconUrl>
+		<licenseUrl>https://github.com/drakkan/sftpgo/blob/main/LICENSE</licenseUrl>
+		<requireLicenseAcceptance>false</requireLicenseAcceptance>
+		<projectSourceUrl>https://github.com/drakkan/sftpgo</projectSourceUrl>
+		<docsUrl>https://github.com/drakkan/sftpgo/tree/v2.3.1/docs</docsUrl>
+		<bugTrackerUrl>https://github.com/drakkan/sftpgo/issues</bugTrackerUrl>
+		<tags>sftp sftp-server ftp webdav s3 azure-blob google-cloud-storage cloud-storage scp data-at-rest-encryption multi-factor-authentication multi-step-authentication</tags>
+		<summary>Fully featured and highly configurable SFTP server with optional HTTP/S,FTP/S and WebDAV support.</summary>
+		<description>SFTPGo allows you to securely share your files over SFTP and optionally over HTTP/S, FTP/S and WebDAV as well.
+Several storage backends are supported and they are configurable per-user, so you can serve a local directory for a user and an S3 bucket (or part of it) for another one.
+
+SFTPGo also supports virtual folders. A virtual folder can use any of the supported storage backends. So you can have, for example, an S3 user that exposes a GCS bucket (or part of it) on a specified path and an encrypted local filesystem on another one. Virtual folders can be private or shared among multiple users, for shared virtual folders you can define different quota limits for each user.
+
+SFTPGo allows to create HTTP/S links to externally share files and folders securely, by setting limits to the number of downloads/uploads, protecting the share with a password, limiting access by source IP address, setting an automatic expiration date.
+
+SFTPGo is highly customizable and extensible to suit your needs.
+
+You can find more info [here](https://github.com/drakkan/sftpgo).
+
+### Notes
+
+* This package installs SFTPGo as Windows Service.
+* After the first installation please take a look at the [Getting Started Guide](https://github.com/drakkan/sftpgo/blob/main/docs/howto/getting-started.md).</description>
+		<releaseNotes>https://github.com/drakkan/sftpgo/releases/tag/v2.3.1</releaseNotes>
+	</metadata>
+	<files>
+		<file src="**" exclude="**\*.md;**\icon.png;**\icon.jpg;**\icon.svg" />
+	</files>
+</package>

pkgs/choco/tools/ChocolateyInstall.ps1

@@ -0,0 +1,52 @@
+$ErrorActionPreference  = 'Stop'
+$packageName    = 'sftpgo'
+$softwareName   = 'SFTPGo'
+$url            = 'https://github.com/drakkan/sftpgo/releases/download/v2.3.1/sftpgo_v2.3.1_windows_x86_64.exe'
+$checksum       = '1F9355C8CADC44C837028CA1F6679E913F0AC5D9873E81FD9B8195BB01F1B793'
+$silentArgs     = '/VERYSILENT'
+$validExitCodes = @(0)
+
+$packageArgs = @{
+  packageName   = $packageName
+  fileType      = 'exe'
+  file          = $fileLocation
+  url           = $url
+  checksum      = $checksum
+  checksumType  = 'sha256'
+  silentArgs    = $silentArgs
+  validExitCodes= $validExitCodes
+  softwareName  = $softwareName
+}
+
+Install-ChocolateyPackage @packageArgs
+
+$DefaultDataPath = Join-Path -Path $ENV:ProgramData -ChildPath "SFTPGo"
+$DefaultConfigurationFilePath = Join-Path -Path $DefaultDataPath -ChildPath "sftpgo.json"
+
+# `t = tab
+Write-Output "---------------------------"
+Write-Output ""
+Write-Output "If you have never used SFTPGo before, the web administration panel is located here:"
+Write-Output "`thttp://localhost:8080/web/admin"
+Write-Output ""
+Write-Output "Default web administration port:"
+Write-Output "`t8080"
+Write-Output "Default SFTP port:"
+Write-Output "`t2022"
+Write-Output ""
+Write-Output "Default data location:"
+Write-Output "`t$DefaultDataPath"
+Write-Output "Default configuration file location:"
+Write-Output "`t$DefaultConfigurationFilePath"
+Write-Output ""
+Write-Output "If the SFTPGo service does not start, make sure that TCP ports 2022 and 8080 are"
+Write-Output "not used by other services or change the SFTPGo configuration to suit your needs."
+Write-Output ""
+Write-Output "General information (README) location:"
+Write-Output "`thttps://github.com/drakkan/sftpgo"
+Write-Output "Getting start guide location:"
+Write-Output "`thttps://github.com/drakkan/sftpgo/blob/v2.3.1/docs/howto/getting-started.md"
+Write-Output "Detailed information (docs folder) location:"
+Write-Output "`thttps://github.com/drakkan/sftpgo/tree/v2.3.1/docs"
+Write-Output ""
+Write-Output "---------------------------"

sftpd/sftpd_test.go

@@ -8633,8 +8633,7 @@ func TestSSHCopy(t *testing.T) {
 			assert.NoError(t, err)
 			err = os.Chmod(subPath, 0001)
 			assert.NoError(t, err)
-			// c.connection.fs.GetDirSize(fsSourcePath) will fail scanning subdirs
-			// checkRecursiveCopyPermissions will work since it will skip subdirs with no permissions
+			// checkRecursiveCopyPermissions will fail scanning subdirs
 			_, err = runSSHCommand(fmt.Sprintf("sftpgo-copy %v %v", vdirPath1, "newdir"), user, usePubKey)
 			assert.Error(t, err)
 			err = os.Chmod(subPath, os.ModePerm)