beenull/runtipi
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix(apps.helpers): make required boolean field pass with false value

Browse source
This commit is contained in:
Nicolas Meienberger 2023-06-05 21:17:51 +02:00 committed by Nicolas Meienberger
parent a31ecca41a
commit 09a51fe90c
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/server/services/apps/apps.helpers.test.ts
View file

@ -183,7 +183,7 @@ describe('Test: generateEnvFile()', () => {
const app = await insertApp({}, appConfig, db);
// act & assert
expect(() => generateEnvFile(Object.assign(app, { config: { TEST_FIELD: undefined } }))).toThrowError('Variable TEST_FIELD is required');
expect(() => generateEnvFile(Object.assign(app, { config: { TEST_FIELD: undefined } }))).toThrowError('Variable test is required');
});
it('Should throw an error if app does not exist', async () => {

6
src/server/services/apps/apps.helpers.ts
View file

@ -197,8 +197,8 @@ export const generateEnvFile = (app: App) => {
const formValue = castAppConfig(app.config)[field.env_variable];
const envVar = field.env_variable;
if (formValue) {
envFile += `${envVar}=${formValue}\n`;
if (formValue || typeof formValue === 'boolean') {
envFile += `${envVar}=${String(formValue)}\n`;
} else if (field.type === 'random') {
if (envMap.has(envVar)) {
envFile += `${envVar}=${envMap.get(envVar)}\n`;
@ -209,7 +209,7 @@ export const generateEnvFile = (app: App) => {
envFile += `${envVar}=${randomString}\n`;
}
} else if (field.required) {
throw new Error(`Variable ${field.env_variable} is required`);
throw new Error(`Variable ${field.label || field.env_variable} is required`);
}
});