From e4a4b47fac4bbdb5e8858c595dadda23412e030a Mon Sep 17 00:00:00 2001
From: Joshua Tauberer <jt@occams.info>
Date: Sat, 26 Dec 2015 08:08:08 -0500
Subject: [PATCH] setup now asks for and sets the system timezone

closes #294
see #328
maybe related to #235
---
 CHANGELOG.md    |  1 +
 setup/start.sh  |  2 ++
 setup/system.sh | 32 ++++++++++++++++++++++++++++++++
 3 files changed, 35 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 4651873..5c98e9c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,7 @@ Control panel:
 
 System:
 
+* Setup (first run only) now asks for your timezone to set the system time.
 * The Exchange/ActiveSync server is now taken offline during nightly backups (along with SMTP and IMAP).
 * The machine's random number generator (/dev/urandom) is now seeded with Ubuntu Pollinate and a blocking read on /dev/random.
 * DNSSEC key generation during install now uses /dev/urandom (instead of /dev/random), which is faster.
diff --git a/setup/start.sh b/setup/start.sh
index 96abd61..201fcee 100755
--- a/setup/start.sh
+++ b/setup/start.sh
@@ -34,6 +34,8 @@ if [ -f /etc/mailinabox.conf ]; then
 	cat /etc/mailinabox.conf | sed s/^/DEFAULT_/ > /tmp/mailinabox.prev.conf
 	source /tmp/mailinabox.prev.conf
 	rm -f /tmp/mailinabox.prev.conf
+else
+	FIRST_TIME_SETUP=1
 fi
 
 # Put a start script in a global location. We tell the user to run 'mailinabox'
diff --git a/setup/system.sh b/setup/system.sh
index 8f7b640..1aeec45 100755
--- a/setup/system.sh
+++ b/setup/system.sh
@@ -55,6 +55,38 @@ apt_install python3 python3-dev python3-pip \
 	haveged pollinate \
 	unattended-upgrades cron ntp fail2ban
 
+# ### Set the system timezone
+#
+# Some systems are missing /etc/timezone, which we cat into the configs for
+# Z-Push and ownCloud, so we need to set it to something. Daily cron tasks
+# like the system backup are run at a time tied to the system timezone, so
+# letting the user choose will help us identify the right time to do those
+# things (i.e. late at night in whatever timezone the user actually lives
+# in).
+#
+# However, changing the timezone once it is set seems to confuse fail2ban
+# and requires restarting fail2ban (done below in the fail2ban
+# section) and syslog (see #328). There might be other issues, and it's
+# not likely the user will want to change this, so we only ask on first
+# setup.
+if [ -z "$NONINTERACTIVE" ]; then
+	if [ ! -f /etc/timezone ] || [ ! -z $FIRST_TIME_SETUP ]; then
+		# If the file is missing or this is the user's first time running
+		# Mail-in-a-Box setup, run the interactive timezone configuration
+		# tool.
+		dpkg-reconfigure tzdata
+		restart_service rsyslog
+	fi
+else
+	# This is a non-interactive setup so we can't ask the user.
+	# If /etc/timezone is missing, set it to UTC.
+	if [ ! -f /etc/timezone ]; then
+		echo "Setting timezone to UTC."
+		echo "Etc/UTC" > /etc/timezone
+		restart_service rsyslog
+	fi
+fi
+
 # ### Seed /dev/urandom
 #
 # /dev/urandom is used by various components for generating random bytes for