d69d4799a3
The goal is to remove function from `docker_utils.go` and setup simple, one-responsability package that can be well tested ; and to ease writing request. This moves all the calls to `sockRequest` (and similar methods) to their counterpart in the `request` package. This introduce `request.Do` to write easier request (with functional argument to easily augment the request) with some pre-defined function for the most used http method (i.e. `request.Get`, `request.Post` and `request.Delete`). Few of the `sockRequest` call have been moved to `request.Do` (and `Get`, etc.) to showcase the usage of the package. There is still a whole lot to do. Signed-off-by: Vincent Demeester <vincent@sbr.pm>
184 lines
6.4 KiB
Go
184 lines
6.4 KiB
Go
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"strings"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/api/types/versions/v1p20"
|
|
"github.com/docker/docker/integration-cli/checker"
|
|
"github.com/docker/docker/integration-cli/request"
|
|
"github.com/docker/docker/pkg/stringutils"
|
|
"github.com/go-check/check"
|
|
)
|
|
|
|
func (s *DockerSuite) TestInspectAPIContainerResponse(c *check.C) {
|
|
out, _ := dockerCmd(c, "run", "-d", "busybox", "true")
|
|
|
|
cleanedContainerID := strings.TrimSpace(out)
|
|
keysBase := []string{"Id", "State", "Created", "Path", "Args", "Config", "Image", "NetworkSettings",
|
|
"ResolvConfPath", "HostnamePath", "HostsPath", "LogPath", "Name", "Driver", "MountLabel", "ProcessLabel", "GraphDriver"}
|
|
|
|
type acase struct {
|
|
version string
|
|
keys []string
|
|
}
|
|
|
|
var cases []acase
|
|
|
|
if daemonPlatform == "windows" {
|
|
cases = []acase{
|
|
{"v1.25", append(keysBase, "Mounts")},
|
|
}
|
|
|
|
} else {
|
|
cases = []acase{
|
|
{"v1.20", append(keysBase, "Mounts")},
|
|
{"v1.19", append(keysBase, "Volumes", "VolumesRW")},
|
|
}
|
|
}
|
|
|
|
for _, cs := range cases {
|
|
body := getInspectBody(c, cs.version, cleanedContainerID)
|
|
|
|
var inspectJSON map[string]interface{}
|
|
err := json.Unmarshal(body, &inspectJSON)
|
|
c.Assert(err, checker.IsNil, check.Commentf("Unable to unmarshal body for version %s", cs.version))
|
|
|
|
for _, key := range cs.keys {
|
|
_, ok := inspectJSON[key]
|
|
c.Check(ok, checker.True, check.Commentf("%s does not exist in response for version %s", key, cs.version))
|
|
}
|
|
|
|
//Issue #6830: type not properly converted to JSON/back
|
|
_, ok := inspectJSON["Path"].(bool)
|
|
c.Assert(ok, checker.False, check.Commentf("Path of `true` should not be converted to boolean `true` via JSON marshalling"))
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestInspectAPIContainerVolumeDriverLegacy(c *check.C) {
|
|
// No legacy implications for Windows
|
|
testRequires(c, DaemonIsLinux)
|
|
out, _ := dockerCmd(c, "run", "-d", "busybox", "true")
|
|
|
|
cleanedContainerID := strings.TrimSpace(out)
|
|
|
|
cases := []string{"v1.19", "v1.20"}
|
|
for _, version := range cases {
|
|
body := getInspectBody(c, version, cleanedContainerID)
|
|
|
|
var inspectJSON map[string]interface{}
|
|
err := json.Unmarshal(body, &inspectJSON)
|
|
c.Assert(err, checker.IsNil, check.Commentf("Unable to unmarshal body for version %s", version))
|
|
|
|
config, ok := inspectJSON["Config"]
|
|
c.Assert(ok, checker.True, check.Commentf("Unable to find 'Config'"))
|
|
cfg := config.(map[string]interface{})
|
|
_, ok = cfg["VolumeDriver"]
|
|
c.Assert(ok, checker.True, check.Commentf("API version %s expected to include VolumeDriver in 'Config'", version))
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestInspectAPIContainerVolumeDriver(c *check.C) {
|
|
out, _ := dockerCmd(c, "run", "-d", "--volume-driver", "local", "busybox", "true")
|
|
|
|
cleanedContainerID := strings.TrimSpace(out)
|
|
|
|
body := getInspectBody(c, "v1.25", cleanedContainerID)
|
|
|
|
var inspectJSON map[string]interface{}
|
|
err := json.Unmarshal(body, &inspectJSON)
|
|
c.Assert(err, checker.IsNil, check.Commentf("Unable to unmarshal body for version 1.25"))
|
|
|
|
config, ok := inspectJSON["Config"]
|
|
c.Assert(ok, checker.True, check.Commentf("Unable to find 'Config'"))
|
|
cfg := config.(map[string]interface{})
|
|
_, ok = cfg["VolumeDriver"]
|
|
c.Assert(ok, checker.False, check.Commentf("API version 1.25 expected to not include VolumeDriver in 'Config'"))
|
|
|
|
config, ok = inspectJSON["HostConfig"]
|
|
c.Assert(ok, checker.True, check.Commentf("Unable to find 'HostConfig'"))
|
|
cfg = config.(map[string]interface{})
|
|
_, ok = cfg["VolumeDriver"]
|
|
c.Assert(ok, checker.True, check.Commentf("API version 1.25 expected to include VolumeDriver in 'HostConfig'"))
|
|
}
|
|
|
|
func (s *DockerSuite) TestInspectAPIImageResponse(c *check.C) {
|
|
dockerCmd(c, "tag", "busybox:latest", "busybox:mytag")
|
|
|
|
endpoint := "/images/busybox/json"
|
|
status, body, err := request.SockRequest("GET", endpoint, nil, daemonHost())
|
|
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(status, checker.Equals, http.StatusOK)
|
|
|
|
var imageJSON types.ImageInspect
|
|
err = json.Unmarshal(body, &imageJSON)
|
|
c.Assert(err, checker.IsNil, check.Commentf("Unable to unmarshal body for latest version"))
|
|
c.Assert(imageJSON.RepoTags, checker.HasLen, 2)
|
|
|
|
c.Assert(stringutils.InSlice(imageJSON.RepoTags, "busybox:latest"), checker.Equals, true)
|
|
c.Assert(stringutils.InSlice(imageJSON.RepoTags, "busybox:mytag"), checker.Equals, true)
|
|
}
|
|
|
|
// #17131, #17139, #17173
|
|
func (s *DockerSuite) TestInspectAPIEmptyFieldsInConfigPre121(c *check.C) {
|
|
// Not relevant on Windows
|
|
testRequires(c, DaemonIsLinux)
|
|
out, _ := dockerCmd(c, "run", "-d", "busybox", "true")
|
|
|
|
cleanedContainerID := strings.TrimSpace(out)
|
|
|
|
cases := []string{"v1.19", "v1.20"}
|
|
for _, version := range cases {
|
|
body := getInspectBody(c, version, cleanedContainerID)
|
|
|
|
var inspectJSON map[string]interface{}
|
|
err := json.Unmarshal(body, &inspectJSON)
|
|
c.Assert(err, checker.IsNil, check.Commentf("Unable to unmarshal body for version %s", version))
|
|
config, ok := inspectJSON["Config"]
|
|
c.Assert(ok, checker.True, check.Commentf("Unable to find 'Config'"))
|
|
cfg := config.(map[string]interface{})
|
|
for _, f := range []string{"MacAddress", "NetworkDisabled", "ExposedPorts"} {
|
|
_, ok := cfg[f]
|
|
c.Check(ok, checker.True, check.Commentf("API version %s expected to include %s in 'Config'", version, f))
|
|
}
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestInspectAPIBridgeNetworkSettings120(c *check.C) {
|
|
// Not relevant on Windows, and besides it doesn't have any bridge network settings
|
|
testRequires(c, DaemonIsLinux)
|
|
out, _ := dockerCmd(c, "run", "-d", "busybox", "top")
|
|
containerID := strings.TrimSpace(out)
|
|
waitRun(containerID)
|
|
|
|
body := getInspectBody(c, "v1.20", containerID)
|
|
|
|
var inspectJSON v1p20.ContainerJSON
|
|
err := json.Unmarshal(body, &inspectJSON)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
settings := inspectJSON.NetworkSettings
|
|
c.Assert(settings.IPAddress, checker.Not(checker.HasLen), 0)
|
|
}
|
|
|
|
func (s *DockerSuite) TestInspectAPIBridgeNetworkSettings121(c *check.C) {
|
|
// Windows doesn't have any bridge network settings
|
|
testRequires(c, DaemonIsLinux)
|
|
out, _ := dockerCmd(c, "run", "-d", "busybox", "top")
|
|
containerID := strings.TrimSpace(out)
|
|
waitRun(containerID)
|
|
|
|
body := getInspectBody(c, "v1.21", containerID)
|
|
|
|
var inspectJSON types.ContainerJSON
|
|
err := json.Unmarshal(body, &inspectJSON)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
settings := inspectJSON.NetworkSettings
|
|
c.Assert(settings.IPAddress, checker.Not(checker.HasLen), 0)
|
|
c.Assert(settings.Networks["bridge"], checker.Not(checker.IsNil))
|
|
c.Assert(settings.IPAddress, checker.Equals, settings.Networks["bridge"].IPAddress)
|
|
}
|