fc7b904dce
`Mounts` allows users to specify in a much safer way the volumes they
want to use in the container.
This replaces `Binds` and `Volumes`, which both still exist, but
`Mounts` and `Binds`/`Volumes` are exclussive.
The CLI will continue to use `Binds` and `Volumes` due to concerns with
parsing the volume specs on the client side and cross-platform support
(for now).
The new API follows exactly the services mount API.
Example usage of `Mounts`:
```
$ curl -XPOST localhost:2375/containers/create -d '{
"Image": "alpine:latest",
"HostConfig": {
"Mounts": [{
"Type": "Volume",
"Target": "/foo"
},{
"Type": "bind",
"Source": "/var/run/docker.sock",
"Target": "/var/run/docker.sock",
},{
"Type": "volume",
"Name": "important_data",
"Target": "/var/data",
"ReadOnly": true,
"VolumeOptions": {
"DriverConfig": {
Name: "awesomeStorage",
Options: {"size": "10m"},
Labels: {"some":"label"}
}
}]
}
}'
```
There are currently 2 types of mounts:
- **bind**: Paths on the host that get mounted into the
container. Paths must exist prior to creating the container.
- **volume**: Volumes that persist after the
container is removed.
Not all fields are available in each type, and validation is done to
ensure these fields aren't mixed up between types.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
51 lines
1.5 KiB
Go
51 lines
1.5 KiB
Go
// +build windows
|
|
|
|
package daemon
|
|
|
|
import (
|
|
"fmt"
|
|
"sort"
|
|
|
|
"github.com/docker/docker/container"
|
|
"github.com/docker/docker/volume"
|
|
)
|
|
|
|
// setupMounts configures the mount points for a container by appending each
|
|
// of the configured mounts on the container to the OCI mount structure
|
|
// which will ultimately be passed into the oci runtime during container creation.
|
|
// It also ensures each of the mounts are lexographically sorted.
|
|
|
|
// BUGBUG TODO Windows containerd. This would be much better if it returned
|
|
// an array of windowsoci mounts, not container mounts. Then no need to
|
|
// do multiple transitions.
|
|
|
|
func (daemon *Daemon) setupMounts(c *container.Container) ([]container.Mount, error) {
|
|
var mnts []container.Mount
|
|
for _, mount := range c.MountPoints { // type is volume.MountPoint
|
|
if err := daemon.lazyInitializeVolume(c.ID, mount); err != nil {
|
|
return nil, err
|
|
}
|
|
// If there is no source, take it from the volume path
|
|
s := mount.Source
|
|
if s == "" && mount.Volume != nil {
|
|
s = mount.Volume.Path()
|
|
}
|
|
if s == "" {
|
|
return nil, fmt.Errorf("No source for mount name '%s' driver %q destination '%s'", mount.Name, mount.Driver, mount.Destination)
|
|
}
|
|
mnts = append(mnts, container.Mount{
|
|
Source: s,
|
|
Destination: mount.Destination,
|
|
Writable: mount.RW,
|
|
})
|
|
}
|
|
|
|
sort.Sort(mounts(mnts))
|
|
return mnts, nil
|
|
}
|
|
|
|
// setBindModeIfNull is platform specific processing which is a no-op on
|
|
// Windows.
|
|
func setBindModeIfNull(bind *volume.MountPoint) {
|
|
return
|
|
}
|