moby/hack
Sebastiaan van Stijn c696fdd003
hack/make/.binary: don't use "netgo" when building Windows binaries
Starting with go1.19, the Go runtime on Windows now supports the `netgo` build-
flag to use a native Go DNS resolver. Prior to that version, the build-flag
only had an effect on non-Windows platforms. When using the `netgo` build-flag,
the Windows's host resolver is not used, and as a result, custom entries in
`etc/hosts` are ignored, which is a change in behavior from binaries compiled
with older versions of the Go runtime.

From the go1.19 release notes: https://go.dev/doc/go1.19#net

> Resolver.PreferGo is now implemented on Windows and Plan 9. It previously
> only worked on Unix platforms. Combined with Dialer.Resolver and Resolver.Dial,
> it's now possible to write portable programs and be in control of all DNS name
> lookups when dialing.
>
> The net package now has initial support for the netgo build tag on Windows.
> When used, the package uses the Go DNS client (as used by Resolver.PreferGo)
> instead of asking Windows for DNS results. The upstream DNS server it discovers
> from Windows may not yet be correct with complex system network configurations,
> however.

Our Windows binaries are compiled with the "static" (`make/binary-daemon`)
script, which has the `netgo` option set by default. This patch unsets the
`netgo` option when cross-compiling for Windows.

Co-authored-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
(cherry picked from commit 53d1b12bc0)
Signed-off-by: Bjorn Neergaard <bjorn.neergaard@docker.com>
2023-05-24 10:48:57 -06:00
..
dockerfile Merge pull request #45371 from thaJeztah/23.0_backport_runc_binary_1.1.6 2023-05-05 20:50:10 +00:00
make hack/make/.binary: don't use "netgo" when building Windows binaries 2023-05-24 10:48:57 -06:00
test ci(test): send coverage to codecov 2022-09-08 13:50:19 +02:00
validate hack: introduce validate/no-module 2022-12-13 14:42:07 -07:00
buildkit-ref hack: replace go-mod-prepare.sh with wrapper script 2022-12-13 14:42:05 -07:00
dind hack/dind: fix cgroup v2 evacuation with docker run --init 2021-04-28 13:30:10 +09:00
generate-authors.sh hack/generate-authors.sh: refactor and simplify 2022-11-30 12:06:21 +01:00
generate-swagger-api.sh api: swagger: move ContainerCreateResponse to definitions 2022-04-28 22:39:16 +02:00
generate-test-certs.sh hack: add script to regenerate certificates 2021-05-18 09:43:18 +02:00
generate-test-rogue-certs.sh integration-cli: fix test rogue certs 2022-05-19 10:54:31 +02:00
make.ps1 ci(integration-cli): move integration-cli run to make script 2022-06-17 10:59:05 +02:00
make.sh hack: remove unnecessary vars in make.sh script 2023-01-30 15:06:32 +01:00
README.md Dockerfile: use TARGETPLATFORM to build Docker 2023-01-02 18:46:01 +01:00
vendor.sh hack: replace go-mod-prepare.sh with wrapper script 2022-12-13 14:42:05 -07:00
with-go-mod.sh hack: replace go-mod-prepare.sh with wrapper script 2022-12-13 14:42:05 -07:00

About

This directory contains a collection of scripts used to build and manage this repository. If there are any issues regarding the intention of a particular script (or even part of a certain script), please reach out to us. It may help us either refine our current scripts, or add on new ones that are appropriate for a given use case.

DinD (dind.sh)

DinD is a wrapper script which allows Docker to be run inside a Docker container. DinD requires the container to be run with privileged mode enabled.

Generate Authors (generate-authors.sh)

Generates AUTHORS; a file with all the names and corresponding emails of individual contributors. AUTHORS can be found in the home directory of this repository.

Make

There are two make files, each with different extensions. Neither are supposed to be called directly; only invoke make. Both scripts run inside a Docker container.

make.ps1

  • The Windows native build script that uses PowerShell semantics; it is limited unlike hack\make.sh since it does not provide support for the full set of operations provided by the Linux counterpart, make.sh. However, make.ps1 does provide support for local Windows development and Windows to Windows CI. More information is found within make.ps1 by the author, @jhowardmsft

make.sh

  • Referenced via make test when running tests on a local machine, or directly referenced when running tests inside a Docker development container.
  • When running on a local machine, make test to run all tests found in test, test-unit, test-integration, and test-docker-py on your local machine. The default timeout is set in make.sh to 60 minutes (${TIMEOUT:=60m}), since it currently takes up to an hour to run all of the tests.
  • When running inside a Docker development container, hack/make.sh does not have a single target that runs all the tests. You need to provide a single command line with multiple targets that performs the same thing. An example referenced from Run targets inside a development container: root@5f8630b873fe:/go/src/github.com/moby/moby# hack/make.sh dynbinary binary test-unit test-integration test-docker-py
  • For more information related to testing outside the scope of this README, refer to Run tests and test documentation

Vendor (vendor.sh)

A shell script that is a wrapper around go mod vendor.