0f6eeecac0
The daemon has made a habit of mutating the DefaultRuntime and Runtimes values in the Config struct to merge defaults. This would be fine if it was a part of the regular configuration loading and merging process, as is done with other config options. The trouble is it does so in surprising places, such as in functions with 'verify' or 'validate' in their name. It has been necessary in order to validate that the user has not defined a custom runtime named "runc" which would shadow the built-in runtime of the same name. Other daemon code depends on the runtime named "runc" always being defined in the config, but merging it with the user config at the same time as the other defaults are merged would trip the validation. The root of the issue is that the daemon has used the same config values for both validating the daemon runtime configuration as supplied by the user and for keeping track of which runtimes have been set up by the daemon. Now that a completely separate value is used for the latter purpose, surprising contortions are no longer required to make the validation work as intended. Consolidate the validation of the runtimes config and merging of the built-in runtimes into the daemon.setupRuntimes() function. Set the result of merging the built-in runtimes config and default default runtime on the returned runtimes struct, without back-propagating it onto the config.Config argument. Signed-off-by: Cory Snider <csnider@mirantis.com>
44 lines
1.3 KiB
Go
44 lines
1.3 KiB
Go
//go:build linux || freebsd
|
|
|
|
package daemon
|
|
|
|
import (
|
|
"testing"
|
|
|
|
containertypes "github.com/docker/docker/api/types/container"
|
|
"github.com/docker/docker/daemon/config"
|
|
"github.com/docker/go-connections/nat"
|
|
"gotest.tools/v3/assert"
|
|
)
|
|
|
|
// TestContainerWarningHostAndPublishPorts that a warning is returned when setting network mode to host and specifying published ports.
|
|
// This should not be tested on Windows because Windows doesn't support "host" network mode.
|
|
func TestContainerWarningHostAndPublishPorts(t *testing.T) {
|
|
testCases := []struct {
|
|
ports nat.PortMap
|
|
warnings []string
|
|
}{
|
|
{ports: nat.PortMap{}},
|
|
{ports: nat.PortMap{
|
|
"8080": []nat.PortBinding{{HostPort: "8989"}},
|
|
}, warnings: []string{"Published ports are discarded when using host network mode"}},
|
|
}
|
|
muteLogs()
|
|
|
|
for _, tc := range testCases {
|
|
hostConfig := &containertypes.HostConfig{
|
|
Runtime: "runc",
|
|
NetworkMode: "host",
|
|
PortBindings: tc.ports,
|
|
}
|
|
d := &Daemon{}
|
|
cfg, err := config.New()
|
|
assert.NilError(t, err)
|
|
runtimes, err := setupRuntimes(cfg)
|
|
assert.NilError(t, err)
|
|
daemonCfg := &configStore{Config: *cfg, Runtimes: runtimes}
|
|
wrns, err := d.verifyContainerSettings(daemonCfg, hostConfig, &containertypes.Config{}, false)
|
|
assert.NilError(t, err)
|
|
assert.DeepEqual(t, tc.warnings, wrns)
|
|
}
|
|
}
|