1401342f46
The Docker CLI already performs version-checks when running commands, but other clients consuming the API client may not do so. This patch adds a version check to various client functions. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
60 lines
1.6 KiB
Go
60 lines
1.6 KiB
Go
package client
|
|
|
|
import (
|
|
"bytes"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/types/swarm"
|
|
"github.com/stretchr/testify/assert"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
func TestSecretUpdateUnsupported(t *testing.T) {
|
|
client := &Client{
|
|
version: "1.24",
|
|
client: &http.Client{},
|
|
}
|
|
err := client.SecretUpdate(context.Background(), "secret_id", swarm.Version{}, swarm.SecretSpec{})
|
|
assert.EqualError(t, err, `"secret update" requires API version 1.25, but the Docker daemon API version is 1.24`)
|
|
}
|
|
|
|
func TestSecretUpdateError(t *testing.T) {
|
|
client := &Client{
|
|
version: "1.25",
|
|
client: newMockClient(errorMock(http.StatusInternalServerError, "Server error")),
|
|
}
|
|
|
|
err := client.SecretUpdate(context.Background(), "secret_id", swarm.Version{}, swarm.SecretSpec{})
|
|
if err == nil || err.Error() != "Error response from daemon: Server error" {
|
|
t.Fatalf("expected a Server Error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestSecretUpdate(t *testing.T) {
|
|
expectedURL := "/v1.25/secrets/secret_id/update"
|
|
|
|
client := &Client{
|
|
version: "1.25",
|
|
client: newMockClient(func(req *http.Request) (*http.Response, error) {
|
|
if !strings.HasPrefix(req.URL.Path, expectedURL) {
|
|
return nil, fmt.Errorf("Expected URL '%s', got '%s'", expectedURL, req.URL)
|
|
}
|
|
if req.Method != "POST" {
|
|
return nil, fmt.Errorf("expected POST method, got %s", req.Method)
|
|
}
|
|
return &http.Response{
|
|
StatusCode: http.StatusOK,
|
|
Body: ioutil.NopCloser(bytes.NewReader([]byte("body"))),
|
|
}, nil
|
|
}),
|
|
}
|
|
|
|
err := client.SecretUpdate(context.Background(), "secret_id", swarm.Version{}, swarm.SecretSpec{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|