moby/integration
Sebastiaan van Stijn ef5dd6e46d Skip TestHealthKillContainer on Windows
This test is failing on Windows currently:

```
11:59:47 --- FAIL: TestHealthKillContainer (8.12s)
11:59:47     health_test.go:57: assertion failed: error is not nil: Error response from daemon: Invalid signal: SIGUSR1
``

That test was added recently in https://github.com/moby/moby/pull/39454, but
rewritten in a commit in the same PR:
f8aef6a92f

In that rewrite, there were some changes:

- originally it was skipped on Windows, but the rewritten test doesn't have that skip:

    ```go
    testRequires(c, DaemonIsLinux) // busybox doesn't work on Windows
    ```

- the original test used `SIGINT`, but the new one uses `SIGUSR1`

Analysis:

- The Error bubbles up from: 8e610b2b55/pkg/signal/signal.go (L29-L44)
- Interestingly; `ContainerKill` should validate if a signal is valid for the given platform, but somehow we don't hit that part; f1b5612f20/daemon/kill.go (L40-L48)
- Windows only looks to support 2 signals currently 8e610b2b55/pkg/signal/signal_windows.go (L17-L26)
- Upstream Golang looks to define `SIGINT` as well; 77f9b2728e/src/runtime/defs_windows.go (L44)
- This looks like the current list of Signals upstream in Go; 3b58ed4ad3/windows/types_windows.go (L52-L67)

```go
const (
	// More invented values for signals
	SIGHUP  = Signal(0x1)
	SIGINT  = Signal(0x2)
	SIGQUIT = Signal(0x3)
	SIGILL  = Signal(0x4)
	SIGTRAP = Signal(0x5)
	SIGABRT = Signal(0x6)
	SIGBUS  = Signal(0x7)
	SIGFPE  = Signal(0x8)
	SIGKILL = Signal(0x9)
	SIGSEGV = Signal(0xb)
	SIGPIPE = Signal(0xd)
	SIGALRM = Signal(0xe)
	SIGTERM = Signal(0xf)
)
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit eeaa0b30d4)
Signed-off-by: Dani Louca <dani.louca@docker.com>
2019-08-14 17:07:39 -04:00
..
build Builder: fix "COPY --from" to non-existing directory on Windows 2019-08-08 17:05:11 +02:00
config Add test for keeping same daemon ID on upgrade 2019-06-18 18:55:00 +00:00
container Skip TestHealthKillContainer on Windows 2019-08-14 17:07:39 -04:00
image Skip TestImagesFilterMultiReference on API < v1.40 2019-05-13 15:26:22 -07:00
internal Enable integrations API tests for Windows CI 2019-06-12 10:16:04 +02:00
network For ipvlan tests check that the ipvlan module is enabled (instead of just ensuring the kernel version is greater than 4.2) 2019-06-25 00:40:32 +02:00
plugin Use assert.NilError() instead of assert.Assert() 2019-01-21 13:16:02 +01:00
secret Fatalf -> Fatal 2019-01-27 00:43:24 +00:00
service Gracefully take care of the error case when a container 2019-06-12 20:00:51 +02:00
session Testing: create new daemon (only) if needed 2019-02-23 13:32:59 +01:00
system Revert "Remove Schema1 integration test suite" 2019-06-18 18:54:45 +00:00
testdata/https integration/plugin/authz: port tests from integration-cli 2017-10-02 14:20:59 +01:00
volume Enable integrations API tests for Windows CI 2019-06-12 10:16:04 +02:00
doc.go Add canonical import comment 2018-02-05 16:51:57 -05:00