3b9370fcf8
see https://github.com/koalaman/shellcheck/wiki/SC2155
Looking at how these were used, I don't think we even need to
export them, so removing that.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 5cfc9c374c)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
39 lines
1.1 KiB
Bash
Executable file
39 lines
1.1 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
set -e
|
|
|
|
SCRIPTDIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
|
|
source "${SCRIPTDIR}/.validate"
|
|
|
|
IFS=$'\n'
|
|
files=($(validate_diff --diff-filter=ACMR --name-only -- 'pkg/*.go' || true))
|
|
unset IFS
|
|
|
|
badFiles=()
|
|
for f in "${files[@]}"; do
|
|
if [ "$f" = "pkg/urlutil/deprecated.go" ]; then
|
|
# pkg/urlutil is deprecated, but has a temporary alias to help migration,
|
|
# see https://github.com/moby/moby/pull/43477
|
|
# TODO(thaJeztah) remove this exception once pkg/urlutil aliases are removed
|
|
continue
|
|
fi
|
|
IFS=$'\n'
|
|
badImports=($(go list -e -f '{{ join .Deps "\n" }}' "$f" | sort -u | grep -vE '^github.com/docker/docker/pkg/' | grep -vE '^github.com/docker/docker/vendor' | grep -E '^github.com/docker/docker' || true))
|
|
unset IFS
|
|
|
|
for import in "${badImports[@]}"; do
|
|
badFiles+=("$f imports $import")
|
|
done
|
|
done
|
|
|
|
if [ ${#badFiles[@]} -eq 0 ]; then
|
|
echo 'Congratulations! Packages in "./pkg/..." are safely isolated from internal code.'
|
|
else
|
|
{
|
|
echo 'These files import internal code: (either directly or indirectly)'
|
|
for f in "${badFiles[@]}"; do
|
|
echo " - $f"
|
|
done
|
|
echo
|
|
} >&2
|
|
false
|
|
fi
|