moby/integration-cli
Cory Snider f77a3274b4
[chore] clean up reexec.Init() calls
Now that most uses of reexec have been replaced with non-reexec
solutions, most of the reexec.Init() calls peppered throughout the test
suites are unnecessary. Furthermore, most of the reexec.Init() calls in
test code neglects to check the return value to determine whether to
exit, which would result in the reexec'ed subprocesses proceeding to run
the tests, which would reexec another subprocess which would proceed to
run the tests, recursively. (That would explain why every reexec
callback used to unconditionally call os.Exit() instead of returning...)

Remove unneeded reexec.Init() calls from test and example code which no
longer needs it, and fix the reexec.Init() calls which are not inert to
exit after a reexec callback is invoked.

Signed-off-by: Cory Snider <csnider@mirantis.com>
(cherry picked from commit 4e0319c878)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-05-11 16:31:41 +02:00
..
checker bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
cli integration-cli: remove cli.Build(), cli.Inspect() 2022-12-28 09:25:27 +01:00
daemon integration-cli: inline filters in tests 2023-04-25 15:14:27 +02:00
environment testutil: make testing packages public 2019-09-11 07:47:23 -05:00
fixtures integration-cli: fix test rogue certs 2022-05-19 10:54:31 +02:00
requirement integration-cli: make testRequires() a Helper 2019-10-09 21:44:22 +02:00
testdata Clean some integration-cli/fixtures package/files 2018-04-16 10:48:58 +02:00
benchmark_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
check_test.go [chore] clean up reexec.Init() calls 2023-05-11 16:31:41 +02:00
daemon_swarm_hack_test.go rm-gocheck: run goimports to compile successfully 2019-09-09 21:06:12 +00:00
docker_api_attach_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_api_build_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_api_build_windows_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_api_containers_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_api_containers_unix_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
docker_api_containers_windows_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_api_exec_resize_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_api_exec_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_api_images_test.go integration-cli: inline filters in tests 2023-04-25 15:14:27 +02:00
docker_api_inspect_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_api_logs_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_api_network_test.go integration-cli: inline filters in tests 2023-04-25 15:14:27 +02:00
docker_api_stats_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_api_swarm_node_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_api_swarm_service_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_api_swarm_test.go Bump swarmkit to v2 2022-04-21 17:33:07 -04:00
docker_api_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_attach_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_attach_unix_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_build_test.go integration-cli: remove cli.Build(), cli.Inspect() 2022-12-28 09:25:27 +01:00
docker_cli_build_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_by_digest_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_commit_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_cp_from_container_test.go gofmt GoDoc comments with go1.19 2022-07-08 19:56:23 +02:00
docker_cli_cp_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_cp_to_container_test.go integration-cli: remove isCpCannotCopyReadOnly utility 2022-09-27 22:15:19 +02:00
docker_cli_cp_to_container_unix_test.go integration-cli: remove uses of pkg/system.Stat() 2022-10-09 17:55:13 +02:00
docker_cli_cp_utils_test.go integration-cli: remove isCpCannotCopyReadOnly utility 2022-09-27 22:15:19 +02:00
docker_cli_create_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_daemon_plugins_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
docker_cli_daemon_test.go integration-cli: remove waitInspectWithArgs() 2022-12-29 18:26:12 +01:00
docker_cli_events_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_cli_events_unix_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_exec_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_cli_exec_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_external_volume_driver_test.go gofmt GoDoc comments with go1.19 2022-07-08 19:56:23 +02:00
docker_cli_health_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_history_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_images_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_import_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_info_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_info_unix_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_cli_inspect_test.go integration(-cli): remove some redundant formatting 2022-10-08 17:41:39 +02:00
docker_cli_links_test.go integration-cli: links: use gotest.tools compare and assert.Check 2022-12-21 11:09:02 +01:00
docker_cli_login_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_logout_test.go test: use T.Setenv to set env vars in tests 2022-04-23 17:44:16 +08:00
docker_cli_logs_test.go integration-cli: Fix hanging TestLogsFollowGoroutines* 2023-01-05 18:10:32 +01:00
docker_cli_netmode_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_network_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_network_unix_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_plugins_logdriver_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_cli_plugins_test.go integration-cli: DockerPluginSuite: use gotest.tools compare utilities 2022-11-01 17:27:18 +01:00
docker_cli_port_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_proxy_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_prune_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_prune_unix_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_ps_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_pull_local_test.go Remove uses of deprecated go-digest.NewDigestFromHex, go-digest.Digest.Hex 2022-11-08 16:42:13 +01:00
docker_cli_pull_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_push_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_registry_user_agent_test.go refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
docker_cli_restart_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_rmi_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_run_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_cli_run_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_save_load_test.go Remove uses of deprecated go-digest.NewDigestFromHex, go-digest.Digest.Hex 2022-11-08 16:42:13 +01:00
docker_cli_save_load_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_search_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_service_create_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
docker_cli_service_health_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_service_logs_test.go integration-cli: Make service process live forever 2022-07-28 16:27:27 +03:00
docker_cli_service_scale_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
docker_cli_sni_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_start_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_stats_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_swarm_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_swarm_unix_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_top_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_update_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_update_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_userns_test.go integration-cli: remove uses of pkg/system.Stat() 2022-10-09 17:55:13 +02:00
docker_cli_v2_only_test.go refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
docker_cli_volume_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
docker_deprecated_api_v124_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_deprecated_api_v124_unix_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
docker_hub_pull_suite_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_utils_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
events_utils_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
fixtures_linux_daemon_test.go refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
requirements_test.go integration-cli: rename vars that collided with imports 2023-04-03 20:01:05 +02:00
requirements_unix_test.go Remove "seccomp" build tag 2022-05-12 14:48:35 -07:00
test_vars_test.go Remove deprecated environment.DaemonPlatform() 2018-01-15 15:32:06 +01:00
test_vars_unix_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
test_vars_windows_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
utils_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
utils_unix_test.go pkg/system: move GetLongPathName to integration-cli 2022-11-29 17:02:53 +01:00
utils_windows_test.go pkg/system: move GetLongPathName to integration-cli 2022-11-29 17:02:53 +01:00