beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
moby/integration-cli
History
Tibor Vass e71e7d8246
integration-cli: fix tests that are silently succeeding when they should not compile 
Tests fixed in this patch used to compile and pass successfully,
despite checking if non-nullable types are not nil.

These would have become compile errors once go-check is removed.

About TestContainerAPIPsOmitFields:
Basically what happened is that this test got refactored to start using the API types
and API client library instead of custom types and stdlib's http functions.
This test used to test an API regression which could possibly be a unit test.
However because PublicPort and IP are not nullable types, this test became useless.

Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit e07a3f2917)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-09-26 23:52:11 +02:00
..
checker Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
cli Update tests to use gotest.tools 👼 2018-06-13 09:04:30 +02:00
daemon Retry service updates on out of sequence errors 2019-09-25 17:33:17 +02:00
environment Various code-cleanup 2018-05-23 17:50:54 +02:00
fixtures Clean some integration-cli/fixtures package/files 2018-04-16 10:48:58 +02:00
requirement Add canonical import comment 2018-02-05 16:51:57 -05:00
testdata Clean some integration-cli/fixtures package/files 2018-04-16 10:48:58 +02:00
benchmark_test.go integration-cli: remove defaultSleepImage constant 2019-09-25 17:25:20 +02:00
check_test.go integration-cli: add daemon.StartNodeWithBusybox function 2019-09-25 21:36:11 +02:00
daemon_swarm_hack_test.go Make internal/test/daemon.Daemon swarm aware 2018-04-11 12:10:17 +02:00
docker_api_attach_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_api_build_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_api_build_windows_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_api_containers_test.go integration-cli: fix tests that are silently succeeding when they should not compile 2019-09-26 23:52:11 +02:00
docker_api_containers_windows_test.go Remove SameHostDaemon, use testEnv.IsLocalDaemon instead 2018-12-24 13:25:53 +01:00
docker_api_exec_resize_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_api_exec_test.go integration-cli: remove ExecSupport check 2019-09-25 17:24:48 +02:00
docker_api_images_test.go integration-cli: Skip TestAPIImagesSaveAndLoad on RS3 and older 2019-09-25 21:36:12 +02:00
docker_api_inspect_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_api_logs_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_api_network_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_api_stats_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_api_swarm_node_test.go Slightly speed up TestAPISwarmNodeDrainPause 2019-01-13 21:08:20 +01:00
docker_api_swarm_service_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_api_swarm_test.go integration-cli: allow temporary errors on leader switch 2019-09-16 13:45:14 +02:00
docker_api_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_attach_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_attach_unix_test.go switch kr/pty to creack/pty v1.1.7 2019-09-12 10:24:55 +02:00
docker_cli_build_test.go integration-cli: fix some bashism's in Dockerfiles 2019-09-25 21:35:59 +02:00
docker_cli_build_unix_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_by_digest_test.go Revert "Remove Schema1 integration test suite" 2019-06-18 18:54:45 +00:00
docker_cli_commit_test.go Fix ineffassign linting 2018-07-11 22:18:45 +02:00
docker_cli_cp_from_container_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_cp_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_cp_to_container_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_cp_to_container_unix_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_cp_utils_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_create_test.go integration-cli: fix tests that are silently succeeding when they should not compile 2019-09-26 23:52:11 +02:00
docker_cli_daemon_plugins_test.go integration-cli: remove redundant "testrequires" 2019-09-25 17:33:51 +02:00
docker_cli_daemon_test.go integration-cli: remove redundant "testrequires" 2019-09-25 17:33:51 +02:00
docker_cli_events_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_events_unix_test.go integration-cli: remove redundant "testrequires" 2019-09-25 17:33:51 +02:00
docker_cli_exec_test.go integration-cli: remove redundant "testrequires" 2019-09-25 17:33:51 +02:00
docker_cli_exec_unix_test.go integration-cli: remove ExecSupport check 2019-09-25 17:24:48 +02:00
docker_cli_external_volume_driver_unix_test.go Entropy cannot be saved 2019-06-11 17:40:09 +02:00
docker_cli_health_test.go Fix ineffassign linting 2018-07-11 22:18:45 +02:00
docker_cli_history_test.go Introduce a cli package for test-integration 2017-03-23 18:35:22 +01:00
docker_cli_images_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_import_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_info_test.go integration-cli: remove redundant "testrequires" 2019-09-25 17:33:51 +02:00
docker_cli_info_unix_test.go Remove SameHostDaemon, use testEnv.IsLocalDaemon instead 2018-12-24 13:25:53 +01:00
docker_cli_inspect_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_links_test.go integration-cli: remove ExecSupport check 2019-09-25 17:24:48 +02:00
docker_cli_login_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_logout_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_logs_bench_test.go Fixes some issues with jsonfile write/read 2016-03-21 11:05:58 -04:00
docker_cli_logs_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_netmode_test.go fix and skip some tests based on API version 2018-05-15 16:05:04 -07:00
docker_cli_network_unix_test.go integration-cli: fix tests that are silently succeeding when they should not compile 2019-09-26 23:52:11 +02:00
docker_cli_plugins_logdriver_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_plugins_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_port_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_proxy_test.go integration-cli: remove redundant "testrequires" 2019-09-25 17:33:51 +02:00
docker_cli_prune_unix_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_ps_test.go Harden TestPsListContainersFilterExited 2019-06-07 14:13:23 +02:00
docker_cli_pull_local_test.go Revert "Remove Schema1 integration test suite" 2019-06-18 18:54:45 +00:00
docker_cli_pull_test.go Use current windows servercore image 2019-04-17 15:24:23 +02:00
docker_cli_push_test.go use gotest.tools assertions in docker_cli_push_test.go 2019-06-18 18:54:55 +00:00
docker_cli_registry_user_agent_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_restart_test.go fix some spelling mistakes 2019-09-25 21:35:49 +02:00
docker_cli_rmi_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_run_test.go TestCase: use icmd.RunCmd instead icmd.StartCmd 2019-09-25 21:36:01 +02:00
docker_cli_run_unix_test.go integration-cli: remove redundant "testrequires" 2019-09-25 17:33:51 +02:00
docker_cli_save_load_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_save_load_unix_test.go switch kr/pty to creack/pty v1.1.7 2019-09-12 10:24:55 +02:00
docker_cli_search_test.go integration-cli: also run Docker Hub search tests on Windows 2019-09-16 14:39:49 +02:00
docker_cli_service_create_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_service_health_test.go integration-cli: increase healthcheck timeout 2019-09-25 17:32:45 +02:00
docker_cli_service_logs_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_service_scale_test.go integration-cli: remove defaultSleepImage constant 2019-09-25 17:25:20 +02:00
docker_cli_sni_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_start_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_stats_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_swarm_test.go Fix Service TTY test so signal handlers work 2019-09-25 21:36:09 +02:00
docker_cli_swarm_unix_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_top_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_update_unix_test.go switch kr/pty to creack/pty v1.1.7 2019-09-12 10:24:55 +02:00
docker_cli_userns_test.go integration-cli: remove redundant "testrequires" 2019-09-25 17:33:51 +02:00
docker_cli_v2_only_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_cli_volume_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_deprecated_api_v124_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_deprecated_api_v124_unix_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
docker_hub_pull_suite_test.go Remove SameHostDaemon, use testEnv.IsLocalDaemon instead 2018-12-24 13:25:53 +01:00
docker_utils_test.go integration-cli: getContainerCount() fix trimming prefix 2019-09-25 21:35:57 +02:00
events_utils_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
fixtures_linux_daemon_test.go Replace some checkers and assertions with gotest.tools 2019-04-05 16:45:37 +02:00
requirements_test.go integration-cli: remove ExecSupport check 2019-09-25 17:24:48 +02:00
requirements_unix_test.go integration-cli: remove unused requirements utils 2019-09-25 17:25:53 +02:00
test_vars_noseccomp_test.go Introduce a environment package in integration-cli 2016-12-29 11:00:50 +01:00
test_vars_seccomp_test.go Introduce a environment package in integration-cli 2016-12-29 11:00:50 +01:00
test_vars_test.go Remove deprecated environment.DaemonPlatform() 2018-01-15 15:32:06 +01:00
test_vars_unix_test.go integration-cli: remove defaultSleepImage constant 2019-09-25 17:25:20 +02:00
test_vars_windows_test.go integration-cli: remove defaultSleepImage constant 2019-09-25 17:25:20 +02:00
utils_test.go Update tests to use gotest.tools 👼 2018-06-13 09:04:30 +02:00