Sebastiaan van Stijn 2e67c827bb errdefs: FromStatusCode() don't log "FIXME" debug message ... This utility is used by the client, which cannot do anything about errors received from the API. In situations where no API connection was possible, for example, if the client has no permissions to connect to the socket, the request would have a "-1" status-code; 3e39ec60da/client/request.go (L133-L134) In this case, a client with "debug" enabled, would print _and_ log a confusing error message: DEBU[0000] FIXME: Got an status-code for which error does not match any expected type!!! error="Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post \"http://%2Fvar%2Frun%2Fdocker.sock/v1.24/build?buildargs=%7B%7D&cachefrom=%5B%5D&cgroupparent=&cpuperiod=0&cpuquota=0&cpusetcpus=&cpusetmems=&cpushares=0&dockerfile=Dockerfile.repro&labels=%7B%7D&memory=0&memswap=0&networkmode=default&rm=1&shmsize=0&t=repro&target=&ulimits=null&version=1\": dial unix /var/run/docker.sock: connect: permission denied" module=api status_code=-1 Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/build?buildargs=%7B%7D&cachefrom=%5B%5D&cgroupparent=&cpuperiod=0&cpuquota=0&cpusetcpus=&cpusetmems=&cpushares=0&dockerfile=Dockerfile.repro&labels=%7B%7D&memory=0&memswap=0&networkmode=default&rm=1&shmsize=0&t=repro&target=&ulimits=null&version=1": dial unix /var/run/docker.sock: connect: permission denied In the above; `DEBU` logs the error (including the "FIXME"), and the second line is the error message printed. This was a mistake on my side when I added the `FromStatusCode` utility. I implemented that to be the counterpart to `FromError`, but in doing so also copied over the logging (see 1af30c50ca). That log-message is only intended to be logged on the daemon side, for situations where we return an error without a proper errdefs (which would result in an 500 "internal server error" to be returned by the API). This patch removes the debug log, and a minor cleanup to explicitly return "nil" if we didn't get an error in the first place. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>		2022-12-20 16:03:46 +01:00
..
defs.go	errdefs: remove "ErrAlreadyExists" because it's not an error	2019-03-21 21:25:15 +00:00
doc.go	Add canonical import comment	2018-02-05 16:51:57 -05:00
helpers.go	Implement Unwrap to errors	2020-11-21 16:36:35 +01:00
helpers_test.go	Implement Unwrap to errors	2020-11-21 16:36:35 +01:00
http_helpers.go	errdefs: FromStatusCode() don't log "FIXME" debug message	2022-12-20 16:03:46 +01:00
http_helpers_test.go	bump gotest.tools v3.0.1 for compatibility with Go 1.14	2020-02-11 00:06:42 +01:00
is.go	errdefs: remove "ErrAlreadyExists" because it's not an error	2019-03-21 21:25:15 +00:00