beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
moby/integration-cli
History
Brian Goff e31086320e Remove cli test for duplicate --net/--network opts 
This seems to be testing a strange case, specifically that one can set
the `--net` and `--network` in the same command with the same network.

Indeed this used to work with older CLIs but newer ones error out when
validating the request before sending it to the daemon.

Opening this for discussion because:

1. This doesn't seem to be testing anything at all related to the rest
   of the test
2. Not really providing any value here.
3. Is testing that a technically invalid option is successful (whether
   the option should be valid as it relates to the CLI accepting it is
   debatable).
4. Such a case seems fringe and even a bug in whatever is calling the
   CLI with such options.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2021-03-18 17:15:02 +00:00
..
checker bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
cli bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
daemon bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
environment testutil: make testing packages public 2019-09-11 07:47:23 -05:00
fixtures run shfmt 2020-03-03 12:27:49 +09:00
requirement integration-cli: make testRequires() a Helper 2019-10-09 21:44:22 +02:00
testdata Clean some integration-cli/fixtures package/files 2018-04-16 10:48:58 +02:00
benchmark_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
check_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
daemon_swarm_hack_test.go rm-gocheck: run goimports to compile successfully 2019-09-09 21:06:12 +00:00
docker_api_attach_test.go Merge pull request #40595 from sfzhu93/GL_2_25 2020-05-08 16:00:52 +02:00
docker_api_build_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_api_build_windows_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_api_containers_test.go Break out non-Windows sys/mount usage into helper 2020-11-08 23:15:15 +11:00
docker_api_containers_unix_test.go Break out non-Windows sys/mount usage into helper 2020-11-08 23:15:15 +11:00
docker_api_containers_windows_test.go Break out non-Windows sys/mount usage into helper 2020-11-08 23:15:15 +11:00
docker_api_exec_resize_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_api_exec_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_api_images_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_api_inspect_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_api_logs_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_api_network_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_api_stats_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_api_swarm_node_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_api_swarm_service_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_api_swarm_test.go Replace errors.Cause() with errors.Is() / errors.As() 2020-04-29 00:28:41 +02:00
docker_api_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_attach_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_attach_unix_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_build_test.go integration-cli: remove TestBuildContChar 2020-11-14 03:57:36 +00:00
docker_cli_build_unix_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_by_digest_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_commit_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_cp_from_container_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_cp_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_cp_to_container_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_cp_to_container_unix_test.go Upgrading the versions of images in Dockerfile. 2020-06-30 12:24:06 +08:00
docker_cli_cp_utils_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_create_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_daemon_plugins_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_daemon_test.go Move use of debian:buster frozen image to debian:bullseye 2020-12-19 17:59:36 +01:00
docker_cli_events_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_events_unix_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_exec_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_exec_unix_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_external_volume_driver_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_health_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_history_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_images_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_import_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_info_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_info_unix_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_inspect_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_links_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_login_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_logout_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_logs_bench_test.go rm-gocheck: run goimports to compile successfully 2019-09-09 21:06:12 +00:00
docker_cli_logs_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_netmode_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_network_test.go Setup tests 2019-09-09 21:09:57 +00:00
docker_cli_network_unix_test.go Remove cli test for duplicate --net/--network opts 2021-03-18 17:15:02 +00:00
docker_cli_plugins_logdriver_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_plugins_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_port_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_proxy_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_prune_unix_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_ps_test.go Fix filter on expose and publish 2020-05-15 11:12:03 +02:00
docker_cli_pull_local_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_pull_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_push_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_registry_user_agent_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_restart_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_rmi_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_run_test.go Move use of debian:buster frozen image to debian:bullseye 2020-12-19 17:59:36 +01:00
docker_cli_run_unix_test.go Fix Error in daemon_unix.go and docker_cli_run_unit_test.go 2021-01-05 16:56:29 +05:30
docker_cli_save_load_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_save_load_unix_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_search_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_service_create_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_service_health_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_service_logs_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_service_scale_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_sni_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_start_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_stats_test.go test: add buffer to prevent goroutine leak 2020-02-27 21:37:26 -05:00
docker_cli_swarm_test.go Fix TestSwarmManagerAddress to not depend on "pretty" format 2020-05-11 14:07:04 +02:00
docker_cli_swarm_unix_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_top_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_update_unix_test.go Set minimum memory limit to 6M, to account for higher startup memory use 2020-07-01 13:29:07 +02:00
docker_cli_userns_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_v2_only_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_cli_volume_test.go Accept platform spec on container create 2020-03-20 16:10:36 -07:00
docker_deprecated_api_v124_test.go Set minimum memory limit to 6M, to account for higher startup memory use 2020-07-01 13:29:07 +02:00
docker_deprecated_api_v124_unix_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_hub_pull_suite_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_utils_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
events_utils_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
fixtures_linux_daemon_test.go Move use of debian:buster frozen image to debian:bullseye 2020-12-19 17:59:36 +01:00
requirements_test.go integration-cli: make testRequires() a Helper 2019-10-09 21:44:22 +02:00
requirements_unix_test.go integration-cli: remove unused requirements utils 2019-07-08 18:58:46 +02:00
test_vars_noseccomp_test.go Introduce a environment package in integration-cli 2016-12-29 11:00:50 +01:00
test_vars_seccomp_test.go Introduce a environment package in integration-cli 2016-12-29 11:00:50 +01:00
test_vars_test.go Remove deprecated environment.DaemonPlatform() 2018-01-15 15:32:06 +01:00
test_vars_unix_test.go integration-cli: remove defaultSleepImage constant 2019-07-08 18:42:08 +02:00
test_vars_windows_test.go integration-cli: remove defaultSleepImage constant 2019-07-08 18:42:08 +02:00
utils_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00