c8da7fbd25
sed -E -i 's#\bcheck\.(Equals|DeepEquals|HasLen|IsNil|Matches|Not|NotNil)\b#checker.\1#g' \
-- "integration-cli/docker_api_containers_test.go" "integration-cli/docker_cli_attach_test.go" "integration-cli/docker_cli_attach_unix_test.go" "integration-cli/docker_cli_build_test.go" "integration-cli/docker_cli_build_unix_test.go" "integration-cli/docker_cli_by_digest_test.go" "integration-cli/docker_cli_create_test.go" "integration-cli/docker_cli_daemon_test.go" "integration-cli/docker_cli_external_volume_driver_unix_test.go" "integration-cli/docker_cli_health_test.go" "integration-cli/docker_cli_images_test.go" "integration-cli/docker_cli_inspect_test.go" "integration-cli/docker_cli_netmode_test.go" "integration-cli/docker_cli_network_unix_test.go" "integration-cli/docker_cli_port_test.go" "integration-cli/docker_cli_run_test.go" "integration-cli/docker_cli_run_unix_test.go" "integration-cli/docker_cli_save_load_test.go" "integration-cli/docker_cli_service_health_test.go" "integration-cli/docker_cli_swarm_test.go" "integration-cli/docker_cli_volume_test.go" "integration-cli/docker_utils_test.go" "pkg/discovery/discovery_test.go" "pkg/discovery/file/file_test.go" "pkg/discovery/generator_test.go" "pkg/discovery/kv/kv_test.go" "pkg/discovery/memory/memory_test.go" "pkg/discovery/nodes/nodes_test.go"
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit 230f7bcc02)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
96 lines
4.1 KiB
Go
96 lines
4.1 KiB
Go
package main
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"github.com/docker/docker/integration-cli/checker"
|
|
"github.com/docker/docker/runconfig"
|
|
"github.com/go-check/check"
|
|
)
|
|
|
|
// GH14530. Validates combinations of --net= with other options
|
|
|
|
// stringCheckPS is how the output of PS starts in order to validate that
|
|
// the command executed in a container did really run PS correctly.
|
|
const stringCheckPS = "PID USER"
|
|
|
|
// DockerCmdWithFail executes a docker command that is supposed to fail and returns
|
|
// the output, the exit code. If the command returns a Nil error, it will fail and
|
|
// stop the tests.
|
|
func dockerCmdWithFail(c *testing.T, args ...string) (string, int) {
|
|
out, status, err := dockerCmdWithError(args...)
|
|
assert.Assert(c, err, checker.NotNil, check.Commentf("%v", out))
|
|
return out, status
|
|
}
|
|
|
|
func (s *DockerSuite) TestNetHostnameWithNetHost(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux, NotUserNamespace)
|
|
|
|
out, _ := dockerCmd(c, "run", "--net=host", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, stringCheckPS)
|
|
}
|
|
|
|
func (s *DockerSuite) TestNetHostname(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux)
|
|
|
|
out, _ := dockerCmd(c, "run", "-h=name", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, stringCheckPS)
|
|
|
|
out, _ = dockerCmd(c, "run", "-h=name", "--net=bridge", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, stringCheckPS)
|
|
|
|
out, _ = dockerCmd(c, "run", "-h=name", "--net=none", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, stringCheckPS)
|
|
|
|
out, _ = dockerCmdWithFail(c, "run", "-h=name", "--net=container:other", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, runconfig.ErrConflictNetworkHostname.Error())
|
|
|
|
out, _ = dockerCmdWithFail(c, "run", "--net=container", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, "invalid container format container:<name|id>")
|
|
|
|
out, _ = dockerCmdWithFail(c, "run", "--net=weird", "busybox", "ps")
|
|
assert.Assert(c, strings.ToLower(out), checker.Contains, "not found")
|
|
}
|
|
|
|
func (s *DockerSuite) TestConflictContainerNetworkAndLinks(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux)
|
|
|
|
out, _ := dockerCmdWithFail(c, "run", "--net=container:other", "--link=zip:zap", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, runconfig.ErrConflictContainerNetworkAndLinks.Error())
|
|
}
|
|
|
|
func (s *DockerSuite) TestConflictContainerNetworkHostAndLinks(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux, NotUserNamespace)
|
|
|
|
out, _ := dockerCmdWithFail(c, "run", "--net=host", "--link=zip:zap", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, runconfig.ErrConflictHostNetworkAndLinks.Error())
|
|
}
|
|
|
|
func (s *DockerSuite) TestConflictNetworkModeNetHostAndOptions(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux, NotUserNamespace)
|
|
|
|
out, _ := dockerCmdWithFail(c, "run", "--net=host", "--mac-address=92:d0:c6:0a:29:33", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, runconfig.ErrConflictContainerNetworkAndMac.Error())
|
|
}
|
|
|
|
func (s *DockerSuite) TestConflictNetworkModeAndOptions(c *testing.T) {
|
|
testRequires(c, DaemonIsLinux)
|
|
|
|
out, _ := dockerCmdWithFail(c, "run", "--net=container:other", "--dns=8.8.8.8", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, runconfig.ErrConflictNetworkAndDNS.Error())
|
|
|
|
out, _ = dockerCmdWithFail(c, "run", "--net=container:other", "--add-host=name:8.8.8.8", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, runconfig.ErrConflictNetworkHosts.Error())
|
|
|
|
out, _ = dockerCmdWithFail(c, "run", "--net=container:other", "--mac-address=92:d0:c6:0a:29:33", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, runconfig.ErrConflictContainerNetworkAndMac.Error())
|
|
|
|
out, _ = dockerCmdWithFail(c, "run", "--net=container:other", "-P", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, runconfig.ErrConflictNetworkPublishPorts.Error())
|
|
|
|
out, _ = dockerCmdWithFail(c, "run", "--net=container:other", "-p", "8080", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, runconfig.ErrConflictNetworkPublishPorts.Error())
|
|
|
|
out, _ = dockerCmdWithFail(c, "run", "--net=container:other", "--expose", "8000-9000", "busybox", "ps")
|
|
assert.Assert(c, out, checker.Contains, runconfig.ErrConflictNetworkExposePorts.Error())
|
|
}
|