713c7d49a1
This removes various skips that accounted for running the integration tests
against older versions of the daemon before 20.10 (API version v1.41). Those
versions are EOL, and we don't run tests against them.
This reverts most of e440831802
, and similar
PRs.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
154 lines
4.3 KiB
Go
154 lines
4.3 KiB
Go
package container // import "github.com/docker/docker/integration/container"
|
|
|
|
import (
|
|
"io"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/api/types/strslice"
|
|
"github.com/docker/docker/integration/internal/container"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
"gotest.tools/v3/skip"
|
|
)
|
|
|
|
// TestExecWithCloseStdin adds case for moby#37870 issue.
|
|
func TestExecWithCloseStdin(t *testing.T) {
|
|
skip.If(t, testEnv.RuntimeIsWindowsContainerd(), "FIXME. Hang on Windows + containerd combination")
|
|
ctx := setupTest(t)
|
|
|
|
apiClient := testEnv.APIClient()
|
|
|
|
// run top with detached mode
|
|
cID := container.Run(ctx, t, apiClient)
|
|
|
|
expected := "closeIO"
|
|
execResp, err := apiClient.ContainerExecCreate(ctx, cID,
|
|
types.ExecConfig{
|
|
AttachStdin: true,
|
|
AttachStdout: true,
|
|
Cmd: strslice.StrSlice([]string{"sh", "-c", "cat && echo " + expected}),
|
|
},
|
|
)
|
|
assert.NilError(t, err)
|
|
|
|
resp, err := apiClient.ContainerExecAttach(ctx, execResp.ID,
|
|
types.ExecStartCheck{
|
|
Detach: false,
|
|
Tty: false,
|
|
},
|
|
)
|
|
assert.NilError(t, err)
|
|
defer resp.Close()
|
|
|
|
// close stdin to send EOF to cat
|
|
assert.NilError(t, resp.CloseWrite())
|
|
|
|
var (
|
|
waitCh = make(chan struct{})
|
|
resCh = make(chan struct {
|
|
content string
|
|
err error
|
|
}, 1)
|
|
)
|
|
|
|
go func() {
|
|
close(waitCh)
|
|
defer close(resCh)
|
|
r, err := io.ReadAll(resp.Reader)
|
|
|
|
resCh <- struct {
|
|
content string
|
|
err error
|
|
}{
|
|
content: string(r),
|
|
err: err,
|
|
}
|
|
}()
|
|
|
|
<-waitCh
|
|
select {
|
|
case <-time.After(3 * time.Second):
|
|
t.Fatal("failed to read the content in time")
|
|
case got := <-resCh:
|
|
assert.NilError(t, got.err)
|
|
|
|
// NOTE: using Contains because no-tty's stream contains UX information
|
|
// like size, stream type.
|
|
assert.Assert(t, is.Contains(got.content, expected))
|
|
}
|
|
}
|
|
|
|
func TestExec(t *testing.T) {
|
|
ctx := setupTest(t)
|
|
apiClient := testEnv.APIClient()
|
|
|
|
cID := container.Run(ctx, t, apiClient, container.WithTty(true), container.WithWorkingDir("/root"))
|
|
|
|
id, err := apiClient.ContainerExecCreate(ctx, cID,
|
|
types.ExecConfig{
|
|
WorkingDir: "/tmp",
|
|
Env: strslice.StrSlice([]string{"FOO=BAR"}),
|
|
AttachStdout: true,
|
|
Cmd: strslice.StrSlice([]string{"sh", "-c", "env"}),
|
|
},
|
|
)
|
|
assert.NilError(t, err)
|
|
|
|
inspect, err := apiClient.ContainerExecInspect(ctx, id.ID)
|
|
assert.NilError(t, err)
|
|
assert.Check(t, is.Equal(inspect.ExecID, id.ID))
|
|
|
|
resp, err := apiClient.ContainerExecAttach(ctx, id.ID,
|
|
types.ExecStartCheck{
|
|
Detach: false,
|
|
Tty: false,
|
|
},
|
|
)
|
|
assert.NilError(t, err)
|
|
defer resp.Close()
|
|
r, err := io.ReadAll(resp.Reader)
|
|
assert.NilError(t, err)
|
|
out := string(r)
|
|
assert.NilError(t, err)
|
|
expected := "PWD=/tmp"
|
|
if testEnv.DaemonInfo.OSType == "windows" {
|
|
expected = "PWD=C:/tmp"
|
|
}
|
|
assert.Assert(t, is.Contains(out, expected), "exec command not running in expected /tmp working directory")
|
|
assert.Assert(t, is.Contains(out, "FOO=BAR"), "exec command not running with expected environment variable FOO")
|
|
}
|
|
|
|
func TestExecUser(t *testing.T) {
|
|
skip.If(t, testEnv.DaemonInfo.OSType == "windows", "FIXME. Probably needs to wait for container to be in running state.")
|
|
ctx := setupTest(t)
|
|
apiClient := testEnv.APIClient()
|
|
|
|
cID := container.Run(ctx, t, apiClient, container.WithTty(true), container.WithUser("1:1"))
|
|
|
|
result, err := container.Exec(ctx, apiClient, cID, []string{"id"})
|
|
assert.NilError(t, err)
|
|
|
|
assert.Assert(t, is.Contains(result.Stdout(), "uid=1(daemon) gid=1(daemon)"), "exec command not running as uid/gid 1")
|
|
}
|
|
|
|
// Test that additional groups set with `--group-add` are kept on exec when the container
|
|
// also has a user set.
|
|
// (regression test for https://github.com/moby/moby/issues/46712)
|
|
func TestExecWithGroupAdd(t *testing.T) {
|
|
skip.If(t, testEnv.DaemonInfo.OSType == "windows", "FIXME. Probably needs to wait for container to be in running state.")
|
|
|
|
ctx := setupTest(t)
|
|
apiClient := testEnv.APIClient()
|
|
|
|
cID := container.Run(ctx, t, apiClient, container.WithTty(true), container.WithUser("root:root"), container.WithAdditionalGroups("staff", "wheel", "audio", "777"), container.WithCmd("sleep", "5"))
|
|
|
|
result, err := container.Exec(ctx, apiClient, cID, []string{"id"})
|
|
assert.NilError(t, err)
|
|
|
|
assert.Assert(t,
|
|
is.Equal(strings.TrimSpace(result.Stdout()), "uid=0(root) gid=0(root) groups=0(root),10(wheel),29(audio),50(staff),777"),
|
|
"exec command not keeping additional groups w/ user")
|
|
}
|