moby/cli/command
Yong Tang c4d773cdfe Return error for incorrect argument of service update --publish-rm <TargetPort>
Currently `--publish-rm` only accepts `<TargetPort>` or `<TargetPort>[/Protocol]`
though there are some confusions.

Since `--publish-add` accepts `<PublishedPort>:<TargetPort>[/Protocol]`, some user
may provide `--publish-rm 80:80`. However, there is no error checking so the incorrect
provided argument is ignored silently.

This fix adds the check to make sure `--publish-rm` only accepts `<TargetPort>[/Protocol]`
and returns error if the format is invalid.

The `--publish-rm` itself may needs to be revisited to have a better UI/UX experience,
see discussions on:
https://github.com/docker/swarmkit/issues/1396
https://github.com/docker/docker/issues/25200#issuecomment-236213242
https://github.com/docker/docker/issues/25338#issuecomment-240787002

This fix is short term measure so that end users are not misled by the silently ignored error
of `--publish-rm`.

This fix is related to (but is not a complete fix):
https://github.com/docker/swarmkit/issues/1396

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2016-12-01 17:46:53 -08:00
..
bundlefile Reinstate --bundle-file argument to 'docker deploy' 2016-11-10 11:28:18 -05:00
checkpoint refactor help func in CLI 2016-11-17 10:54:10 -08:00
commands secrets: secret management for swarm 2016-11-09 14:27:43 -05:00
container Merge pull request #28445 from cpuguy83/28439_fix_client_rm_on_old_daemons 2016-11-22 14:25:03 +01:00
formatter Merge pull request #28538 from yongtang/11162016-Log-Logf-fix 2016-11-17 15:21:22 -05:00
idresolver service ps: Truncate Task IDs 2016-11-08 16:17:15 -08:00
image Merge pull request #28354 from ripcurld00d/tag_creation 2016-11-18 13:02:40 +01:00
inspect add endpoint mode in service pretty 2016-09-27 18:41:19 +08:00
network Update docs of docker network ls --filter 2016-11-24 08:14:36 -08:00
node Revert "Add -a option to service/node ps" 2016-11-28 18:08:45 +01:00
plugin Modify reponame to PLUGIN and fix some typos 2016-11-25 23:09:46 +08:00
prune add docker network prune 2016-10-25 06:43:54 +00:00
registry Fix some typos 2016-11-30 03:01:32 +08:00
secret Merge pull request #28922 from yuexiao-wang/fix-secret 2016-12-01 11:29:58 +01:00
service Return error for incorrect argument of service update --publish-rm <TargetPort> 2016-12-01 17:46:53 -08:00
stack Merge pull request #28876 from vdemeester/28835-better-handling-of-external-networks 2016-11-29 15:00:35 -08:00
swarm fix description of 'docker swarm init' 2016-11-28 13:24:02 +09:00
system Align output of docker version again 2016-11-28 11:38:58 -08:00
task Suppressing digest for docker service ls/ps 2016-11-18 09:39:34 -08:00
volume refactor help func in CLI 2016-11-17 10:54:10 -08:00
cli.go refactor help func in CLI 2016-11-17 10:54:10 -08:00
events_utils.go Add subcommand prune to the container, volume, image and system commands 2016-09-29 07:42:53 -07:00
in.go Fix the incorrect description for NewInStream 2016-10-13 22:33:09 +08:00
out.go Windows: OCI process struct convergence 2016-09-19 10:34:31 -07:00
registry.go Remove remaining registry methods from DockerCLI. 2016-09-09 15:50:01 -04:00
trust.go Move image trust related cli methods into the image package. 2016-09-09 10:50:16 -04:00
utils.go return nil when no node or service to avoid additional api call 2016-10-11 10:59:16 +08:00