aaa1392279
dockerd allows the `--log-level` to be specified, but this log-level was not forwarded to the containerd process. This patch sets containerd's log-level to the same as dockerd if a custom level is provided. Now that `--log-level` is also passed to containerd, the default "info" is removed, so that containerd's default (or the level configured in containerd.toml) is still used if no log-level is set. Before this change: containerd would always be started without a log-level set (only the level that's configured in `containerd.toml`); ``` root 1014 2.5 2.1 496484 43468 pts/0 Sl+ 12:23 0:00 dockerd root 1023 1.2 1.1 681768 23832 ? Ssl 12:23 0:00 \_ docker-containerd --config /var/run/docker/containerd/containerd.toml ``` After this change: when running `dockerd` without options (same as current); ``` root 1014 2.5 2.1 496484 43468 pts/0 Sl+ 12:23 0:00 dockerd root 1023 1.2 1.1 681768 23832 ? Ssl 12:23 0:00 \_ docker-containerd --config /var/run/docker/containerd/containerd.toml ``` when running `dockerd --debug`: ``` root 600 0.8 2.1 512876 43180 pts/0 Sl+ 12:20 0:00 dockerd --debug root 608 0.6 1.1 624428 23672 ? Ssl 12:20 0:00 \_ docker-containerd --config /var/run/docker/containerd/containerd.toml --log-level debug ``` when running `dockerd --log-level=panic` ``` root 747 0.6 2.1 496548 43996 pts/0 Sl+ 12:21 0:00 dockerd --log-level=panic root 755 0.7 1.1 550696 24100 ? Ssl 12:21 0:00 \_ docker-containerd --config /var/run/docker/containerd/containerd.toml --log-level panic ``` combining `--debug` and `--log-level` (`--debug` takes precedence): ``` root 880 2.7 2.1 634692 43336 pts/0 Sl+ 12:23 0:00 dockerd --debug --log-level=panic root 888 1.0 1.1 616232 23652 ? Ssl 12:23 0:00 \_ docker-containerd --config /var/run/docker/containerd/containerd.toml --log-level debug ``` Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
47 lines
1 KiB
Go
47 lines
1 KiB
Go
// +build remote_daemon
|
|
|
|
package libcontainerd // import "github.com/docker/docker/libcontainerd"
|
|
|
|
import (
|
|
"os"
|
|
)
|
|
|
|
const (
|
|
grpcPipeName = `\\.\pipe\docker-containerd-containerd`
|
|
debugPipeName = `\\.\pipe\docker-containerd-debug`
|
|
)
|
|
|
|
func (r *remote) setDefaults() {
|
|
if r.GRPC.Address == "" {
|
|
r.GRPC.Address = grpcPipeName
|
|
}
|
|
if r.Debug.Address == "" {
|
|
r.Debug.Address = debugPipeName
|
|
}
|
|
if r.snapshotter == "" {
|
|
r.snapshotter = "naive" // TODO(mlaventure): switch to "windows" once implemented
|
|
}
|
|
}
|
|
|
|
func (r *remote) stopDaemon() {
|
|
p, err := os.FindProcess(r.daemonPid)
|
|
if err != nil {
|
|
r.logger.WithField("pid", r.daemonPid).Warn("could not find daemon process")
|
|
return
|
|
}
|
|
|
|
if err = p.Kill(); err != nil {
|
|
r.logger.WithError(err).WithField("pid", r.daemonPid).Warn("could not kill daemon process")
|
|
return
|
|
}
|
|
|
|
_, err = p.Wait()
|
|
if err != nil {
|
|
r.logger.WithError(err).WithField("pid", r.daemonPid).Warn("wait for daemon process")
|
|
return
|
|
}
|
|
}
|
|
|
|
func (r *remote) platformCleanup() {
|
|
// Nothing to do
|
|
}
|