beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
moby/daemon
History
Sebastiaan van Stijn bd5d6480e7
daemon: WithNamespaces(): remove redundant "if" 
This check was originally used to only validate the mode if it was set to
a non-empty value (see commit 072400fc4b), but
validation was made unconditional in c3d7a0c603.

Given that a `CgroupnsMode` can't be both [`CgroupnsMode.IsEmpty()`][1]
and [`CgroupnsMode.IsPrivate`][2], we can remove the extra check.

[1]: e0da5cb929/api/types/container/hostconfig.go (L33-L36)
[2]: e0da5cb929/api/types/container/hostconfig.go (L23-L26)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2023-08-24 16:12:22 +02:00
..
cluster remove uses of libnetwork/Network.Info() 2023-08-08 22:05:30 +02:00
config Set default CDI spec dirs after parsing args 2023-08-03 12:21:44 +02:00
containerd c8d/builder: Don't drop fields from created image 2023-08-24 09:44:12 +02:00
events daemon/events: use strings.Cut() 2022-12-21 11:09:01 +01:00
graphdriver daemon/graphdriver: format code with gofumpt 2023-06-29 00:31:34 +02:00
images Don't return an error if the lease is not found 2023-08-22 14:52:41 +02:00
initlayer daemon: format code with gofumpt 2023-06-29 00:33:03 +02:00
links daemon/links: use strings.Cut() 2022-12-21 11:09:01 +01:00
listeners Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
logger swap logrus types for their containerd/logs aliases 2023-08-01 13:02:55 +02:00
names Add canonical import comment 2018-02-05 16:51:57 -05:00
network daemon/network: Settings: move sandbox fields together 2023-08-23 14:26:58 +02:00
snapshotter daemon/snapshotter: format code with gofumpt 2023-06-29 00:32:38 +02:00
stats Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
testdata Remove libtrust dep from api 2017-09-06 12:05:19 -04:00
apparmor_default.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
apparmor_default_unsupported.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
archive.go daemon: refactor isOnlineFSOperationPermitted 2022-10-26 12:06:31 -04:00
archive_tarcopyoptions.go Finish refactor of UID/GID usage to a new struct 2022-03-14 16:28:57 -04:00
archive_tarcopyoptions_unix.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
archive_tarcopyoptions_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
archive_unix.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
archive_windows.go pkg/system: move CheckSystemDriveAndRemoveDriveLetter to pkg/archive 2022-11-29 17:07:48 +01:00
attach.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
auth.go daemon: use types/registry.AuthConfig 2022-07-29 23:05:18 +02:00
cdi.go Skip CDI driver registration if CDISpecDirs is empty 2023-08-03 12:21:44 +02:00
changes.go c8d: add support for docker diff 2023-03-30 10:29:07 +01:00
checkpoint.go daemon: format code with gofumpt 2023-06-29 00:33:03 +02:00
cluster.go Fix libnetwork imports 2021-06-01 21:51:23 +00:00
commit.go Add health start interval 2023-07-05 23:44:17 +00:00
configs.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
configs_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
configs_unsupported.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
configs_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
container.go daemon: remove Daemon.checkContainer and related utils 2023-08-24 16:12:18 +02:00
container_linux.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
container_operations.go daemon: updateSandboxNetworkSettings: remove unused error-return 2023-08-23 14:26:58 +02:00
container_operations_unix.go daemon: remove Daemon.checkContainer and related utils 2023-08-24 16:12:18 +02:00
container_operations_windows.go daemon: change Daemon.setupPathsAndSandboxOptions to a regular func 2023-08-02 16:14:15 +02:00
container_unix_test.go daemon: consolidate runtimes config validation 2023-06-01 14:45:25 -04:00
container_windows.go daemon: fix capitalization of some functions 2020-04-14 17:22:19 +02:00
containerfs_linux.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
content.go daemon: configureLocalContentStore: return concrete types 2023-07-18 14:18:42 +02:00
create.go api/types/container: add RestartPolicyMode type and enum 2023-08-22 16:40:57 +02:00
create_test.go daemon: Remove unneeded error wrapping in verifyNetworkingConfig 2023-08-03 11:21:52 +02:00
create_unix.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
create_windows.go Fix pruning anon volume created from image config 2023-03-14 11:06:26 +01:00
daemon.go api/types/container: add RestartPolicyMode type and enum 2023-08-22 16:40:57 +02:00
daemon_linux.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
daemon_linux_test.go tests: Move libnetwork/testutils to internal/testutils/netnsutils 2023-07-26 21:06:36 +02:00
daemon_test.go daemon: format code with gofumpt 2023-06-29 00:33:03 +02:00
daemon_unix.go remove uses of libnetwork/Network.Info() 2023-08-08 22:05:30 +02:00
daemon_unix_test.go daemon: use string-literals for easier grep'ing 2023-07-05 12:27:00 +02:00
daemon_unsupported.go daemon: read-copy-update the daemon config 2023-06-01 14:45:24 -04:00
daemon_windows.go remove uses of libnetwork/Network.Info() 2023-08-08 22:05:30 +02:00
daemon_windows_test.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
debugtrap_unix.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
debugtrap_unsupported.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
debugtrap_windows.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
delete.go Merge pull request #46213 from thaJeztah/daemon_remove_errors 2023-08-24 13:34:43 +02:00
delete_test.go daemon: cleanupContainer: slightly cleanup error messages 2023-08-23 15:50:43 +02:00
dependency.go Bump swarmkit to v2 2022-04-21 17:33:07 -04:00
devices.go Remove need to set Capabilities for cdi driver 2023-05-16 17:07:58 +02:00
disk_usage.go daemon/disk_usage: Use context aware singleflight 2022-11-29 16:46:19 +01:00
errors.go daemon: cleanupContainer: don't fail if container is already stopped 2023-08-23 15:47:43 +02:00
errors_test.go daemon: cleanupContainer: don't fail if container is already stopped 2023-08-23 15:47:43 +02:00
events.go libnetwork: remove Network interface 2023-07-22 11:56:41 +02:00
events_test.go daemon: rename variables that collide with imported package names 2020-04-14 17:22:23 +02:00
exec.go daemon: rename containerdCli to containerdClient 2023-07-18 13:57:27 +02:00
exec_linux.go daemon: rename containerdCli to containerdClient 2023-07-18 13:57:27 +02:00
exec_linux_test.go daemon: reload runtimes w/o breaking containers 2023-06-01 14:45:25 -04:00
exec_windows.go daemon: read-copy-update the daemon config 2023-06-01 14:45:24 -04:00
export.go remove GetLayerByID from ImageService interface 2023-03-10 17:54:55 +01:00
health.go Add health start interval 2023-07-05 23:44:17 +00:00
health_test.go daemon: suppress logs in unit tests 2019-10-18 00:57:56 +02:00
id.go daemon: format code with gofumpt 2023-06-29 00:33:03 +02:00
image_service.go c8d: implement classic builder 2023-05-11 11:57:01 +01:00
info.go Add CDISpecDirs to Info output 2023-08-04 11:46:34 +02:00
info_unix.go api/types: move system info types to api/types/system 2023-07-07 13:01:36 +02:00
info_unix_test.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
info_windows.go api/types: move system info types to api/types/system 2023-07-07 13:01:36 +02:00
inspect.go daemon/network: Settings: move sandbox fields together 2023-08-23 14:26:58 +02:00
inspect_linux.go daemon: reload runtimes w/o breaking containers 2023-06-01 14:45:25 -04:00
inspect_test.go daemon: reload runtimes w/o breaking containers 2023-06-01 14:45:25 -04:00
inspect_windows.go c8d: Compute container's layer size 2023-03-08 00:58:02 +01:00
keys.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
keys_unsupported.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
kill.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
licensing.go api/types: move system info types to api/types/system 2023-07-07 13:01:36 +02:00
licensing_test.go api/types: move system info types to api/types/system 2023-07-07 13:01:36 +02:00
links.go Add canonical import comment 2018-02-05 16:51:57 -05:00
list.go swap logrus types for their containerd/logs aliases 2023-08-01 13:02:55 +02:00
list_test.go daemon: format code with gofumpt 2023-06-29 00:33:03 +02:00
list_unix.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
list_windows.go pkg/containerfs: alias ContainerFS to string 2022-09-23 16:56:52 -04:00
logdrivers_linux.go Support configuration of log cacher. 2020-02-19 17:02:34 -05:00
logdrivers_windows.go Support configuration of log cacher. 2020-02-19 17:02:34 -05:00
logs.go swap logrus types for their containerd/logs aliases 2023-08-01 13:02:55 +02:00
logs_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
metrics.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
metrics_unix.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
metrics_unsupported.go daemon: read-copy-update the daemon config 2023-06-01 14:45:24 -04:00
monitor.go daemon: Daemon.handleContainerExit(): rename err-var for clarity 2023-08-14 15:17:43 +02:00
mounts.go swap logrus types for their containerd/logs aliases 2023-08-01 13:02:55 +02:00
names.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
network.go api: Validate IPAM config before creating a network 2023-08-22 17:11:54 +02:00
network_windows.go libnetwork: remove Network interface 2023-07-22 11:56:41 +02:00
nvidia_linux.go goimports: fix imports 2019-09-18 12:56:54 +02:00
oci_linux.go daemon: WithNamespaces(): remove redundant "if" 2023-08-24 16:12:22 +02:00
oci_linux_test.go daemon: format code with gofumpt 2023-06-29 00:33:03 +02:00
oci_opts.go daemon: ensure OCI options play nicely together 2023-06-06 13:10:05 -04:00
oci_utils.go daemon: ensure OCI options play nicely together 2023-06-06 13:10:05 -04:00
oci_windows.go daemon: inline Daemon.getDNSSearchSettings 2023-08-02 16:14:15 +02:00
oci_windows_test.go daemon: format code with gofumpt 2023-06-29 00:33:03 +02:00
pause.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
prune.go remove uses of libnetwork/Network.Info() 2023-08-08 22:05:30 +02:00
reload.go swap logrus types for their containerd/logs aliases 2023-08-01 13:02:55 +02:00
reload_test.go daemon: reload runtimes w/o breaking containers 2023-06-01 14:45:25 -04:00
reload_unix.go daemon: consolidate runtimes config validation 2023-06-01 14:45:25 -04:00
reload_windows.go daemon: reload runtimes w/o breaking containers 2023-06-01 14:45:25 -04:00
rename.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
resize.go Fix npe in exec resize when exec errored 2023-05-28 00:14:47 +00:00
resize_test.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
restart.go daemon: format code with gofumpt 2023-06-29 00:33:03 +02:00
runtime_unix.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
runtime_unix_test.go api/types: move system info types to api/types/system 2023-07-07 13:01:36 +02:00
runtime_windows.go daemon: reload runtimes w/o breaking containers 2023-06-01 14:45:25 -04:00
seccomp_linux.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
seccomp_linux_test.go container: split security options to a SecurityOptions struct 2023-04-29 00:03:37 +02:00
seccomp_unsupported.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
secrets.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
secrets_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
secrets_unsupported.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
secrets_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
start.go daemon: remove containerNotModifiedError 2023-08-11 21:28:06 +02:00
start_unix.go daemon: consolidate runtimes config validation 2023-06-01 14:45:25 -04:00
start_windows.go daemon: reload runtimes w/o breaking containers 2023-06-01 14:45:25 -04:00
stats.go Merge pull request #40478 from cpuguy83/dont-prime-the-stats 2020-04-16 20:57:06 +02:00
stats_collector.go pkg/sysinfo: move MemInfo and ReadMemInfo to a separate package 2023-03-15 17:52:45 +01:00
stats_unix.go remove pre-go1.17 build-tags 2023-05-19 20:38:51 +02:00
stats_windows.go daemon: move code related to stats together 2023-04-08 19:00:01 +02:00
stop.go daemon: remove containerNotModifiedError 2023-08-11 21:28:06 +02:00
top_unix.go daemon: use string-literals for easier grep'ing 2023-07-05 12:27:00 +02:00
top_unix_test.go daemon: use string-literals for easier grep'ing 2023-07-05 12:27:00 +02:00
top_windows.go daemon: format code with gofumpt 2023-06-29 00:33:03 +02:00
unpause.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00
update.go daemon: use string-literals for easier grep'ing 2023-07-05 12:27:00 +02:00
update_linux.go daemon: stop setting container resources to zero 2023-06-06 12:13:05 -04:00
update_linux_test.go daemon: stop setting container resources to zero 2023-06-06 12:13:05 -04:00
update_windows.go Windows: Experimental: Allow containerd for runtime 2019-03-12 18:41:55 -07:00
volumes.go Restore active mount counts on live-restore 2023-06-27 16:33:23 +00:00
volumes_linux.go Fix the several typos detected by github.com/client9/misspell 2018-08-09 00:45:00 +09:00
volumes_linux_test.go daemon: rename variables that collide with imported package names 2020-04-14 17:22:23 +02:00
volumes_unit_test.go volume/mounts: remove "containerOS" argument from NewParser (LCOW code) 2021-07-02 13:51:55 +02:00
volumes_unix.go Support recursively read-only (RRO) mounts 2023-05-26 01:58:24 +09:00
volumes_windows.go Add ADD/COPY --chown flag support to Windows 2018-08-13 21:59:11 -07:00
wait.go Switch from x/net/context -> context 2018-04-23 13:52:44 -07:00
workdir.go Add ADD/COPY --chown flag support to Windows 2018-08-13 21:59:11 -07:00