7d4dd91a52
This prevents getting into a situation where a container log cannot make
progress because we tried to rotate a file, got an error, and now the
file is closed. The next time we try to write a log entry it will try
and rotate again but error that the file is already closed.
I wonder if there is more we can do to beef up this rotation logic.
Found this issue while investigating missing logs with errors in the
docker daemon logs like:
```
Failed to log message for json-file: error closing file: close <file>:
file already closed
```
I'm not sure why the original rotation failed since the data was no
longer available.
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit
|
||
---|---|---|
.. | ||
awslogs | ||
etwlogs | ||
fluentd | ||
gcplogs | ||
gelf | ||
journald | ||
jsonfilelog | ||
local | ||
logentries | ||
loggerutils | ||
splunk | ||
syslog | ||
templates | ||
adapter.go | ||
adapter_test.go | ||
copier.go | ||
copier_test.go | ||
factory.go | ||
logger.go | ||
logger_test.go | ||
loginfo.go | ||
metrics.go | ||
plugin.go | ||
plugin_unix.go | ||
plugin_unsupported.go | ||
proxy.go | ||
ring.go | ||
ring_test.go |