00a4f67ddf
The test sometimes failed because no error was returned: === Failed === FAIL: pkg/plugins TestClientWithRequestTimeout (0.00s) client_test.go:254: assertion failed: expected an error, got nil: expected error Possibly caused by a race condition, as the sleep was just 1 ms longer than the timeout; this patch is increasing the sleep in the response to try to reduce flakiness. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
276 lines
6.5 KiB
Go
276 lines
6.5 KiB
Go
package plugins // import "github.com/docker/docker/pkg/plugins"
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"net/url"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/docker/docker/pkg/plugins/transport"
|
|
"github.com/docker/go-connections/tlsconfig"
|
|
"github.com/pkg/errors"
|
|
"gotest.tools/v3/assert"
|
|
is "gotest.tools/v3/assert/cmp"
|
|
)
|
|
|
|
var (
|
|
mux *http.ServeMux
|
|
server *httptest.Server
|
|
)
|
|
|
|
func setupRemotePluginServer() string {
|
|
mux = http.NewServeMux()
|
|
server = httptest.NewServer(mux)
|
|
return server.URL
|
|
}
|
|
|
|
func teardownRemotePluginServer() {
|
|
if server != nil {
|
|
server.Close()
|
|
}
|
|
}
|
|
|
|
func TestFailedConnection(t *testing.T) {
|
|
c, _ := NewClient("tcp://127.0.0.1:1", &tlsconfig.Options{InsecureSkipVerify: true})
|
|
_, err := c.callWithRetry("Service.Method", nil, false)
|
|
if err == nil {
|
|
t.Fatal("Unexpected successful connection")
|
|
}
|
|
}
|
|
|
|
func TestFailOnce(t *testing.T) {
|
|
addr := setupRemotePluginServer()
|
|
defer teardownRemotePluginServer()
|
|
|
|
failed := false
|
|
mux.HandleFunc("/Test.FailOnce", func(w http.ResponseWriter, r *http.Request) {
|
|
if !failed {
|
|
failed = true
|
|
panic("Plugin not ready")
|
|
}
|
|
})
|
|
|
|
c, _ := NewClient(addr, &tlsconfig.Options{InsecureSkipVerify: true})
|
|
b := strings.NewReader("body")
|
|
_, err := c.callWithRetry("Test.FailOnce", b, true)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestEchoInputOutput(t *testing.T) {
|
|
addr := setupRemotePluginServer()
|
|
defer teardownRemotePluginServer()
|
|
|
|
m := Manifest{[]string{"VolumeDriver", "NetworkDriver"}}
|
|
|
|
mux.HandleFunc("/Test.Echo", func(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodPost {
|
|
t.Fatalf("Expected POST, got %s\n", r.Method)
|
|
}
|
|
|
|
header := w.Header()
|
|
header.Set("Content-Type", transport.VersionMimetype)
|
|
|
|
io.Copy(w, r.Body)
|
|
})
|
|
|
|
c, _ := NewClient(addr, &tlsconfig.Options{InsecureSkipVerify: true})
|
|
var output Manifest
|
|
err := c.Call("Test.Echo", m, &output)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
assert.Check(t, is.DeepEqual(m, output))
|
|
err = c.Call("Test.Echo", nil, nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
|
|
func TestBackoff(t *testing.T) {
|
|
cases := []struct {
|
|
retries int
|
|
expTimeOff time.Duration
|
|
}{
|
|
{0, time.Duration(1)},
|
|
{1, time.Duration(2)},
|
|
{2, time.Duration(4)},
|
|
{4, time.Duration(16)},
|
|
{6, time.Duration(30)},
|
|
{10, time.Duration(30)},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
s := c.expTimeOff * time.Second
|
|
if d := backoff(c.retries); d != s {
|
|
t.Fatalf("Retry %v, expected %v, was %v\n", c.retries, s, d)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestAbortRetry(t *testing.T) {
|
|
cases := []struct {
|
|
timeOff time.Duration
|
|
expAbort bool
|
|
}{
|
|
{time.Duration(1), false},
|
|
{time.Duration(2), false},
|
|
{time.Duration(10), false},
|
|
{time.Duration(30), true},
|
|
{time.Duration(40), true},
|
|
}
|
|
|
|
for _, c := range cases {
|
|
s := c.timeOff * time.Second
|
|
if a := abort(time.Now(), s); a != c.expAbort {
|
|
t.Fatalf("Duration %v, expected %v, was %v\n", c.timeOff, s, a)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestClientScheme(t *testing.T) {
|
|
cases := map[string]string{
|
|
"tcp://127.0.0.1:8080": "http",
|
|
"unix:///usr/local/plugins/foo": "http",
|
|
"http://127.0.0.1:8080": "http",
|
|
"https://127.0.0.1:8080": "https",
|
|
}
|
|
|
|
for addr, scheme := range cases {
|
|
u, err := url.Parse(addr)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
s := httpScheme(u)
|
|
|
|
if s != scheme {
|
|
t.Fatalf("URL scheme mismatch, expected %s, got %s", scheme, s)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestNewClientWithTimeout(t *testing.T) {
|
|
addr := setupRemotePluginServer()
|
|
defer teardownRemotePluginServer()
|
|
|
|
m := Manifest{[]string{"VolumeDriver", "NetworkDriver"}}
|
|
|
|
mux.HandleFunc("/Test.Echo", func(w http.ResponseWriter, r *http.Request) {
|
|
time.Sleep(time.Duration(600) * time.Millisecond)
|
|
io.Copy(w, r.Body)
|
|
})
|
|
|
|
// setting timeout of 500ms
|
|
timeout := time.Duration(500) * time.Millisecond
|
|
c, _ := NewClientWithTimeout(addr, &tlsconfig.Options{InsecureSkipVerify: true}, timeout)
|
|
var output Manifest
|
|
err := c.Call("Test.Echo", m, &output)
|
|
if err == nil {
|
|
t.Fatal("Expected timeout error")
|
|
}
|
|
}
|
|
|
|
func TestClientStream(t *testing.T) {
|
|
addr := setupRemotePluginServer()
|
|
defer teardownRemotePluginServer()
|
|
|
|
m := Manifest{[]string{"VolumeDriver", "NetworkDriver"}}
|
|
var output Manifest
|
|
|
|
mux.HandleFunc("/Test.Echo", func(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodPost {
|
|
t.Fatalf("Expected POST, got %s", r.Method)
|
|
}
|
|
|
|
header := w.Header()
|
|
header.Set("Content-Type", transport.VersionMimetype)
|
|
|
|
io.Copy(w, r.Body)
|
|
})
|
|
|
|
c, _ := NewClient(addr, &tlsconfig.Options{InsecureSkipVerify: true})
|
|
body, err := c.Stream("Test.Echo", m)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer body.Close()
|
|
if err := json.NewDecoder(body).Decode(&output); err != nil {
|
|
t.Fatalf("Test.Echo: error reading plugin resp: %v", err)
|
|
}
|
|
assert.Check(t, is.DeepEqual(m, output))
|
|
}
|
|
|
|
func TestClientSendFile(t *testing.T) {
|
|
addr := setupRemotePluginServer()
|
|
defer teardownRemotePluginServer()
|
|
|
|
m := Manifest{[]string{"VolumeDriver", "NetworkDriver"}}
|
|
var output Manifest
|
|
var buf bytes.Buffer
|
|
if err := json.NewEncoder(&buf).Encode(m); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
mux.HandleFunc("/Test.Echo", func(w http.ResponseWriter, r *http.Request) {
|
|
if r.Method != http.MethodPost {
|
|
t.Fatalf("Expected POST, got %s\n", r.Method)
|
|
}
|
|
|
|
header := w.Header()
|
|
header.Set("Content-Type", transport.VersionMimetype)
|
|
|
|
io.Copy(w, r.Body)
|
|
})
|
|
|
|
c, _ := NewClient(addr, &tlsconfig.Options{InsecureSkipVerify: true})
|
|
if err := c.SendFile("Test.Echo", &buf, &output); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
assert.Check(t, is.DeepEqual(m, output))
|
|
}
|
|
|
|
func TestClientWithRequestTimeout(t *testing.T) {
|
|
type timeoutError interface {
|
|
Timeout() bool
|
|
}
|
|
|
|
timeout := 1 * time.Millisecond
|
|
testHandler := func(w http.ResponseWriter, r *http.Request) {
|
|
time.Sleep(timeout + 10*time.Millisecond)
|
|
w.WriteHeader(http.StatusOK)
|
|
}
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(testHandler))
|
|
defer srv.Close()
|
|
|
|
client := &Client{http: srv.Client(), requestFactory: &testRequestWrapper{srv}}
|
|
_, err := client.callWithRetry("/Plugin.Hello", nil, false, WithRequestTimeout(timeout))
|
|
assert.Assert(t, is.ErrorContains(err, ""), "expected error")
|
|
|
|
var tErr timeoutError
|
|
assert.Assert(t, errors.As(err, &tErr))
|
|
assert.Assert(t, tErr.Timeout())
|
|
}
|
|
|
|
type testRequestWrapper struct {
|
|
*httptest.Server
|
|
}
|
|
|
|
func (w *testRequestWrapper) NewRequest(path string, data io.Reader) (*http.Request, error) {
|
|
req, err := http.NewRequest(http.MethodPost, path, data)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
u, err := url.Parse(w.Server.URL)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
req.URL = u
|
|
return req, nil
|
|
}
|