735e250326
unix.Kill() does not produce an error for PID 0, -1. As a result, checking process.Alive() would return "true" for both 0 and -1 on macOS (and previously on Linux as well). Let's shortcut these values to consider them "not alive", to prevent someone trying to kill them. A basic test was added to check the behavior. Given that the intent of these functions is to handle single processes, this patch also prevents 0 and negative values to be used. From KILL(2): https://man7.org/linux/man-pages/man2/kill.2.html If pid is positive, then signal sig is sent to the process with the ID specified by pid. If pid equals 0, then sig is sent to every process in the process group of the calling process. If pid equals -1, then sig is sent to every process for which the calling process has permission to send signals, except for process 1 (init), but see below. If pid is less than -1, then sig is sent to every process in the process group whose ID is -pid. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
40 lines
839 B
Go
40 lines
839 B
Go
package process
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"runtime"
|
|
"testing"
|
|
)
|
|
|
|
func TestAlive(t *testing.T) {
|
|
for _, pid := range []int{0, -1, -123} {
|
|
t.Run(fmt.Sprintf("invalid process (%d)", pid), func(t *testing.T) {
|
|
if Alive(pid) {
|
|
t.Errorf("PID %d should not be alive", pid)
|
|
}
|
|
})
|
|
}
|
|
t.Run("current process", func(t *testing.T) {
|
|
if pid := os.Getpid(); !Alive(pid) {
|
|
t.Errorf("current PID (%d) should be alive", pid)
|
|
}
|
|
})
|
|
t.Run("exited process", func(t *testing.T) {
|
|
if runtime.GOOS == "windows" {
|
|
t.Skip("TODO: make this work on Windows")
|
|
}
|
|
|
|
// Get a PID of an exited process.
|
|
cmd := exec.Command("echo", "hello world")
|
|
err := cmd.Run()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
exitedPID := cmd.ProcessState.Pid()
|
|
if Alive(exitedPID) {
|
|
t.Errorf("PID %d should not be alive", exitedPID)
|
|
}
|
|
})
|
|
}
|