moby/pkg/loopback
Daniel Sweet db2bc43017 Use correct LOOP_CTL_GET_FREE API in pkg/loopback
The `ioctl` interface for the `LOOP_CTL_GET_FREE` request on
`/dev/loop-control` is a little different from what `unix.IoctlGetInt`
expects: the first index is the returned status in `r1`, not an `int`
pointer as the first parameter.

Unfortunately we have to go a little lower level to get the appropriate
loop device index out, using `unix.Syscall` directly to read from
`r1`. Internally, the index is returned as a signed integer to match the
internal `ioctl` expectations of interpreting a negative signed integer
as an error at the userspace ABI boundary, so the direct interface of
`ioctlLoopCtlGetFree` can remain as-is.

[@kolyshkin: it still worked before this fix because of
/dev scan fallback in ioctlLoopCtlGetFree()]

Signed-off-by: Daniel Sweet <danieljsweet@icloud.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2019-08-27 06:22:10 -07:00
..
attach_loopback.go Use loopback types and constants from x/sys/unix to implement pkg/loopback without cgo 2019-08-22 08:25:13 +02:00
ioctl.go Use correct LOOP_CTL_GET_FREE API in pkg/loopback 2019-08-27 06:22:10 -07:00
loop_wrapper.go Use loopback types and constants from x/sys/unix to implement pkg/loopback without cgo 2019-08-22 08:25:13 +02:00
loopback.go Use loopback types and constants from x/sys/unix to implement pkg/loopback without cgo 2019-08-22 08:25:13 +02:00