beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
moby/integration-cli
History
Sebastiaan van Stijn c207947508
integration-cli: DockerPluginSuite: use gotest.tools compare utilities 
Some of these tests are failing (but not enabled in CI), but the current output
doesn't provide any details on the failure, so this patch is just to improve the
test output to allow debugging the actual failure.

Before this, tests would fail like:

    make BIND_DIR=. TEST_FILTER=TestPluginInstallImage test-integration
    ...
    === FAIL: amd64.integration-cli TestDockerPluginSuite/TestPluginInstallImage (15.22s)
        docker_cli_plugins_test.go:220: assertion failed: expression is false: strings.Contains(out, `Encountered remote "application/vnd.docker.container.image.v1+json"(image) when fetching`)
        --- FAIL: TestDockerPluginSuite/TestPluginInstallImage (15.22s)

With this patch, tests provide more useful output:

    make BIND_DIR=. TEST_FILTER=TestPluginInstallImage test-integration
    ...
    === FAIL: amd64.integration-cli TestDockerPluginSuite/TestPluginInstallImage (1.15s)
    time="2022-10-18T10:21:22Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json"
    time="2022-10-18T10:21:22Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json" digest="sha256:bee151d3fef5c1f787e7846efe4fa42b25a02db4e7543e54e8c679cf19d78598"
mediatype=application/vnd.docker.plugin.v1+json size=522
    time="2022-10-18T10:21:22Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json"
    time="2022-10-18T10:21:22Z" level=warning msg="reference for unknown type: application/vnd.docker.plugin.v1+json" digest="sha256:bee151d3fef5c1f787e7846efe4fa42b25a02db4e7543e54e8c679cf19d78598"
mediatype=application/vnd.docker.plugin.v1+json size=522
        docker_cli_plugins_test.go:221: assertion failed: string "Error response from daemon: application/vnd.docker.distribution.manifest.v1+prettyjws not supported\n" does not contain "Encountered remote
\"application/vnd.docker.container.image.v1+json\"(image) when fetching"
        --- FAIL: TestDockerPluginSuite/TestPluginInstallImage (1.15s)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-11-01 17:27:18 +01:00
..
checker bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
cli TestPushMultipleTags: Add support for 20.10 CLI 2021-03-18 19:26:17 +00:00
daemon integration-cli: remove some redundant fmt.Sprintf()'s 2022-02-15 12:50:21 +01:00
environment testutil: make testing packages public 2019-09-11 07:47:23 -05:00
fixtures integration-cli: fix test rogue certs 2022-05-19 10:54:31 +02:00
requirement integration-cli: make testRequires() a Helper 2019-10-09 21:44:22 +02:00
testdata Clean some integration-cli/fixtures package/files 2018-04-16 10:48:58 +02:00
benchmark_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
check_test.go integration-cli: remove TestDockerSuite func 2022-09-12 16:35:41 +02:00
daemon_swarm_hack_test.go rm-gocheck: run goimports to compile successfully 2019-09-09 21:06:12 +00:00
docker_api_attach_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_api_build_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_api_build_windows_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_api_containers_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_api_containers_unix_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
docker_api_containers_windows_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_api_exec_resize_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_api_exec_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_api_images_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_api_inspect_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_api_logs_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_api_network_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_api_stats_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_api_swarm_node_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_api_swarm_service_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_api_swarm_test.go Bump swarmkit to v2 2022-04-21 17:33:07 -04:00
docker_api_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_attach_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_attach_unix_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_build_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_build_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_by_digest_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_commit_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_cp_from_container_test.go gofmt GoDoc comments with go1.19 2022-07-08 19:56:23 +02:00
docker_cli_cp_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_cp_to_container_test.go integration-cli: remove isCpCannotCopyReadOnly utility 2022-09-27 22:15:19 +02:00
docker_cli_cp_to_container_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_cp_utils_test.go integration-cli: remove isCpCannotCopyReadOnly utility 2022-09-27 22:15:19 +02:00
docker_cli_create_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_daemon_plugins_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
docker_cli_daemon_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_events_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_events_unix_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_exec_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_exec_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_external_volume_driver_test.go gofmt GoDoc comments with go1.19 2022-07-08 19:56:23 +02:00
docker_cli_health_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_history_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_images_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_import_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_info_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_info_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_inspect_test.go integration(-cli): remove some redundant formatting 2022-10-08 17:41:39 +02:00
docker_cli_links_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_login_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_logout_test.go test: use T.Setenv to set env vars in tests 2022-04-23 17:44:16 +08:00
docker_cli_logs_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_netmode_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_network_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_network_unix_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_plugins_logdriver_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_plugins_test.go integration-cli: DockerPluginSuite: use gotest.tools compare utilities 2022-11-01 17:27:18 +01:00
docker_cli_port_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_proxy_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_prune_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_prune_unix_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_ps_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_pull_local_test.go test: use T.Setenv to set env vars in tests 2022-04-23 17:44:16 +08:00
docker_cli_pull_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_push_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_registry_user_agent_test.go refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
docker_cli_restart_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_rmi_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_run_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_run_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_save_load_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_save_load_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_search_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_service_create_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
docker_cli_service_health_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_service_logs_test.go integration-cli: Make service process live forever 2022-07-28 16:27:27 +03:00
docker_cli_service_scale_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
docker_cli_sni_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_start_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_stats_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_swarm_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_swarm_unix_test.go integration-cli: fix empty-lines (revive) 2022-09-28 01:58:49 +02:00
docker_cli_top_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_update_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_update_unix_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_cli_userns_test.go refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
docker_cli_v2_only_test.go refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
docker_cli_volume_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_deprecated_api_v124_test.go integration-cli: split DockerSuite into subsequent build suites 2022-06-17 10:59:04 +02:00
docker_deprecated_api_v124_unix_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
docker_hub_pull_suite_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
docker_utils_test.go integration-cli: remove some redundant fmt.Sprintf()'s 2022-02-15 12:50:21 +01:00
events_utils_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
fixtures_linux_daemon_test.go refactor: move from io/ioutil to io and os package 2021-08-27 14:56:57 +08:00
requirements_test.go integration-cli: TestEventsOOM* broken on GitHub Runner 2022-09-08 12:12:02 +02:00
requirements_unix_test.go Remove "seccomp" build tag 2022-05-12 14:48:35 -07:00
test_vars_test.go Remove deprecated environment.DaemonPlatform() 2018-01-15 15:32:06 +01:00
test_vars_unix_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
test_vars_windows_test.go Update to Go 1.17.0, and gofmt with Go 1.17 2021-08-24 23:33:27 +02:00
utils_test.go bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00