222 lines
8.8 KiB
Go
222 lines
8.8 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
|
|
"github.com/docker/docker/integration-cli/checker"
|
|
"github.com/docker/docker/integration-cli/cli"
|
|
"github.com/docker/docker/integration-cli/cli/build"
|
|
"github.com/go-check/check"
|
|
"github.com/gotestyourself/gotestyourself/icmd"
|
|
)
|
|
|
|
func (s *DockerTrustSuite) TestTrustedPull(c *check.C) {
|
|
repoName := s.setupTrustedImage(c, "trusted-pull")
|
|
|
|
// Try pull
|
|
cli.Docker(cli.Args("pull", repoName), trustedCmd).Assert(c, SuccessTagging)
|
|
|
|
cli.DockerCmd(c, "rmi", repoName)
|
|
// Try untrusted pull to ensure we pushed the tag to the registry
|
|
cli.Docker(cli.Args("pull", "--disable-content-trust=true", repoName), trustedCmd).Assert(c, SuccessDownloaded)
|
|
}
|
|
|
|
func (s *DockerTrustSuite) TestTrustedIsolatedPull(c *check.C) {
|
|
repoName := s.setupTrustedImage(c, "trusted-isolated-pull")
|
|
|
|
// Try pull (run from isolated directory without trust information)
|
|
cli.Docker(cli.Args("--config", "/tmp/docker-isolated", "pull", repoName), trustedCmd).Assert(c, SuccessTagging)
|
|
|
|
cli.DockerCmd(c, "rmi", repoName)
|
|
}
|
|
|
|
func (s *DockerTrustSuite) TestUntrustedPull(c *check.C) {
|
|
repoName := fmt.Sprintf("%v/dockercliuntrusted/pulltest:latest", privateRegistryURL)
|
|
// tag the image and upload it to the private registry
|
|
cli.DockerCmd(c, "tag", "busybox", repoName)
|
|
cli.DockerCmd(c, "push", repoName)
|
|
cli.DockerCmd(c, "rmi", repoName)
|
|
|
|
// Try trusted pull on untrusted tag
|
|
cli.Docker(cli.Args("pull", repoName), trustedCmd).Assert(c, icmd.Expected{
|
|
ExitCode: 1,
|
|
Err: "Error: remote trust data does not exist",
|
|
})
|
|
}
|
|
|
|
func (s *DockerTrustSuite) TestTrustedPullFromBadTrustServer(c *check.C) {
|
|
repoName := fmt.Sprintf("%v/dockerclievilpull/trusted:latest", privateRegistryURL)
|
|
evilLocalConfigDir, err := ioutil.TempDir("", "evil-local-config-dir")
|
|
if err != nil {
|
|
c.Fatalf("Failed to create local temp dir")
|
|
}
|
|
|
|
// tag the image and upload it to the private registry
|
|
cli.DockerCmd(c, "tag", "busybox", repoName)
|
|
|
|
cli.Docker(cli.Args("push", repoName), trustedCmd).Assert(c, SuccessSigningAndPushing)
|
|
cli.DockerCmd(c, "rmi", repoName)
|
|
|
|
// Try pull
|
|
cli.Docker(cli.Args("pull", repoName), trustedCmd).Assert(c, SuccessTagging)
|
|
cli.DockerCmd(c, "rmi", repoName)
|
|
|
|
// Kill the notary server, start a new "evil" one.
|
|
s.not.Close()
|
|
s.not, err = newTestNotary(c)
|
|
|
|
c.Assert(err, check.IsNil, check.Commentf("Restarting notary server failed."))
|
|
|
|
// In order to make an evil server, lets re-init a client (with a different trust dir) and push new data.
|
|
// tag an image and upload it to the private registry
|
|
cli.DockerCmd(c, "--config", evilLocalConfigDir, "tag", "busybox", repoName)
|
|
|
|
// Push up to the new server
|
|
cli.Docker(cli.Args("--config", evilLocalConfigDir, "push", repoName), trustedCmd).Assert(c, SuccessSigningAndPushing)
|
|
|
|
// Now, try pulling with the original client from this new trust server. This should fail because the new root is invalid.
|
|
cli.Docker(cli.Args("pull", repoName), trustedCmd).Assert(c, icmd.Expected{
|
|
ExitCode: 1,
|
|
Err: "could not rotate trust to a new trusted root",
|
|
})
|
|
}
|
|
|
|
func (s *DockerTrustSuite) TestTrustedOfflinePull(c *check.C) {
|
|
repoName := s.setupTrustedImage(c, "trusted-offline-pull")
|
|
|
|
cli.Docker(cli.Args("pull", repoName), trustedCmdWithServer("https://invalidnotaryserver")).Assert(c, icmd.Expected{
|
|
ExitCode: 1,
|
|
Err: "error contacting notary server",
|
|
})
|
|
// Do valid trusted pull to warm cache
|
|
cli.Docker(cli.Args("pull", repoName), trustedCmd).Assert(c, SuccessTagging)
|
|
cli.DockerCmd(c, "rmi", repoName)
|
|
|
|
// Try pull again with invalid notary server, should use cache
|
|
cli.Docker(cli.Args("pull", repoName), trustedCmdWithServer("https://invalidnotaryserver")).Assert(c, SuccessTagging)
|
|
}
|
|
|
|
func (s *DockerTrustSuite) TestTrustedPullDelete(c *check.C) {
|
|
repoName := fmt.Sprintf("%v/dockercli/%s:latest", privateRegistryURL, "trusted-pull-delete")
|
|
// tag the image and upload it to the private registry
|
|
cli.BuildCmd(c, repoName, build.WithDockerfile(`
|
|
FROM busybox
|
|
CMD echo trustedpulldelete
|
|
`))
|
|
cli.Docker(cli.Args("push", repoName), trustedCmd).Assert(c, SuccessSigningAndPushing)
|
|
|
|
cli.DockerCmd(c, "rmi", repoName)
|
|
|
|
// Try pull
|
|
result := cli.Docker(cli.Args("pull", repoName), trustedCmd).Assert(c, icmd.Success)
|
|
|
|
matches := digestRegex.FindStringSubmatch(result.Combined())
|
|
c.Assert(matches, checker.HasLen, 2, check.Commentf("unable to parse digest from pull output: %s", result.Combined()))
|
|
pullDigest := matches[1]
|
|
|
|
imageID := inspectField(c, repoName, "Id")
|
|
|
|
imageByDigest := repoName + "@" + pullDigest
|
|
byDigestID := inspectField(c, imageByDigest, "Id")
|
|
|
|
c.Assert(byDigestID, checker.Equals, imageID)
|
|
|
|
// rmi of tag should also remove the digest reference
|
|
cli.DockerCmd(c, "rmi", repoName)
|
|
|
|
_, err := inspectFieldWithError(imageByDigest, "Id")
|
|
c.Assert(err, checker.NotNil, check.Commentf("digest reference should have been removed"))
|
|
|
|
_, err = inspectFieldWithError(imageID, "Id")
|
|
c.Assert(err, checker.NotNil, check.Commentf("image should have been deleted"))
|
|
}
|
|
|
|
func (s *DockerTrustSuite) TestTrustedPullReadsFromReleasesRole(c *check.C) {
|
|
testRequires(c, NotaryHosting)
|
|
repoName := fmt.Sprintf("%v/dockerclireleasesdelegationpulling/trusted", privateRegistryURL)
|
|
targetName := fmt.Sprintf("%s:latest", repoName)
|
|
|
|
// Push with targets first, initializing the repo
|
|
cli.DockerCmd(c, "tag", "busybox", targetName)
|
|
cli.Docker(cli.Args("push", targetName), trustedCmd).Assert(c, icmd.Success)
|
|
s.assertTargetInRoles(c, repoName, "latest", "targets")
|
|
|
|
// Try pull, check we retrieve from targets role
|
|
cli.Docker(cli.Args("-D", "pull", repoName), trustedCmd).Assert(c, icmd.Expected{
|
|
Err: "retrieving target for targets role",
|
|
})
|
|
|
|
// Now we'll create the releases role, and try pushing and pulling
|
|
s.notaryCreateDelegation(c, repoName, "targets/releases", s.not.keys[0].Public)
|
|
s.notaryImportKey(c, repoName, "targets/releases", s.not.keys[0].Private)
|
|
s.notaryPublish(c, repoName)
|
|
|
|
// try a pull, check that we can still pull because we can still read the
|
|
// old tag in the targets role
|
|
cli.Docker(cli.Args("-D", "pull", repoName), trustedCmd).Assert(c, icmd.Expected{
|
|
Err: "retrieving target for targets role",
|
|
})
|
|
|
|
// try a pull -a, check that it succeeds because we can still pull from the
|
|
// targets role
|
|
cli.Docker(cli.Args("-D", "pull", "-a", repoName), trustedCmd).Assert(c, icmd.Success)
|
|
|
|
// Push, should sign with targets/releases
|
|
cli.DockerCmd(c, "tag", "busybox", targetName)
|
|
cli.Docker(cli.Args("push", targetName), trustedCmd).Assert(c, icmd.Success)
|
|
s.assertTargetInRoles(c, repoName, "latest", "targets", "targets/releases")
|
|
|
|
// Try pull, check we retrieve from targets/releases role
|
|
cli.Docker(cli.Args("-D", "pull", repoName), trustedCmd).Assert(c, icmd.Expected{
|
|
Err: "retrieving target for targets/releases role",
|
|
})
|
|
|
|
// Create another delegation that we'll sign with
|
|
s.notaryCreateDelegation(c, repoName, "targets/other", s.not.keys[1].Public)
|
|
s.notaryImportKey(c, repoName, "targets/other", s.not.keys[1].Private)
|
|
s.notaryPublish(c, repoName)
|
|
|
|
cli.DockerCmd(c, "tag", "busybox", targetName)
|
|
cli.Docker(cli.Args("push", targetName), trustedCmd).Assert(c, icmd.Success)
|
|
s.assertTargetInRoles(c, repoName, "latest", "targets", "targets/releases", "targets/other")
|
|
|
|
// Try pull, check we retrieve from targets/releases role
|
|
cli.Docker(cli.Args("-D", "pull", repoName), trustedCmd).Assert(c, icmd.Expected{
|
|
Err: "retrieving target for targets/releases role",
|
|
})
|
|
}
|
|
|
|
func (s *DockerTrustSuite) TestTrustedPullIgnoresOtherDelegationRoles(c *check.C) {
|
|
testRequires(c, NotaryHosting)
|
|
repoName := fmt.Sprintf("%v/dockerclipullotherdelegation/trusted", privateRegistryURL)
|
|
targetName := fmt.Sprintf("%s:latest", repoName)
|
|
|
|
// We'll create a repo first with a non-release delegation role, so that when we
|
|
// push we'll sign it into the delegation role
|
|
s.notaryInitRepo(c, repoName)
|
|
s.notaryCreateDelegation(c, repoName, "targets/other", s.not.keys[0].Public)
|
|
s.notaryImportKey(c, repoName, "targets/other", s.not.keys[0].Private)
|
|
s.notaryPublish(c, repoName)
|
|
|
|
// Push should write to the delegation role, not targets
|
|
cli.DockerCmd(c, "tag", "busybox", targetName)
|
|
cli.Docker(cli.Args("push", targetName), trustedCmd).Assert(c, icmd.Success)
|
|
s.assertTargetInRoles(c, repoName, "latest", "targets/other")
|
|
s.assertTargetNotInRoles(c, repoName, "latest", "targets")
|
|
|
|
// Try pull - we should fail, since pull will only pull from the targets/releases
|
|
// role or the targets role
|
|
cli.DockerCmd(c, "tag", "busybox", targetName)
|
|
cli.Docker(cli.Args("-D", "pull", repoName), trustedCmd).Assert(c, icmd.Expected{
|
|
ExitCode: 1,
|
|
Err: "No trust data for",
|
|
})
|
|
|
|
// try a pull -a: we should fail since pull will only pull from the targets/releases
|
|
// role or the targets role
|
|
cli.Docker(cli.Args("-D", "pull", "-a", repoName), trustedCmd).Assert(c, icmd.Expected{
|
|
ExitCode: 1,
|
|
Err: "No trusted tags for",
|
|
})
|
|
}
|