8a7ff5ff74
This changes the long-standing bug of copy operations not preserving the UID/GID information after the files arrive to the container. Signed-off-by: Erik Hollensbe <github@hollensbe.org>
81 lines
2.5 KiB
Go
81 lines
2.5 KiB
Go
// +build !windows
|
|
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"strconv"
|
|
"strings"
|
|
|
|
"github.com/docker/docker/integration-cli/checker"
|
|
"github.com/docker/docker/pkg/system"
|
|
"github.com/go-check/check"
|
|
)
|
|
|
|
func (s *DockerSuite) TestCpToContainerWithPermissions(c *check.C) {
|
|
testRequires(c, SameHostDaemon, DaemonIsLinux)
|
|
|
|
tmpDir := getTestDir(c, "test-cp-to-host-with-permissions")
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
makeTestContentInDir(c, tmpDir)
|
|
|
|
containerName := "permtest"
|
|
|
|
_, exc := dockerCmd(c, "create", "--name", containerName, "debian:jessie", "/bin/bash", "-c", "stat -c '%u %g %a' /permdirtest /permdirtest/permtest")
|
|
c.Assert(exc, checker.Equals, 0)
|
|
defer dockerCmd(c, "rm", "-f", containerName)
|
|
|
|
srcPath := cpPath(tmpDir, "permdirtest")
|
|
dstPath := containerCpPath(containerName, "/")
|
|
c.Assert(runDockerCp(c, srcPath, dstPath, []string{"-a"}), checker.IsNil)
|
|
|
|
out, err := startContainerGetOutput(c, containerName)
|
|
c.Assert(err, checker.IsNil, check.Commentf("output: %v", out))
|
|
c.Assert(strings.TrimSpace(out), checker.Equals, "2 2 700\n65534 65534 400", check.Commentf("output: %v", out))
|
|
}
|
|
|
|
// Check ownership is root, both in non-userns and userns enabled modes
|
|
func (s *DockerSuite) TestCpCheckDestOwnership(c *check.C) {
|
|
testRequires(c, DaemonIsLinux, SameHostDaemon)
|
|
tmpVolDir := getTestDir(c, "test-cp-tmpvol")
|
|
containerID := makeTestContainer(c,
|
|
testContainerOptions{volumes: []string{fmt.Sprintf("%s:/tmpvol", tmpVolDir)}})
|
|
|
|
tmpDir := getTestDir(c, "test-cp-to-check-ownership")
|
|
defer os.RemoveAll(tmpDir)
|
|
|
|
makeTestContentInDir(c, tmpDir)
|
|
|
|
srcPath := cpPath(tmpDir, "file1")
|
|
dstPath := containerCpPath(containerID, "/tmpvol", "file1")
|
|
|
|
err := runDockerCp(c, srcPath, dstPath, nil)
|
|
c.Assert(err, checker.IsNil)
|
|
|
|
stat, err := system.Stat(filepath.Join(tmpVolDir, "file1"))
|
|
c.Assert(err, checker.IsNil)
|
|
uid, gid, err := getRootUIDGID()
|
|
c.Assert(err, checker.IsNil)
|
|
c.Assert(stat.UID(), checker.Equals, uint32(uid), check.Commentf("Copied file not owned by container root UID"))
|
|
c.Assert(stat.GID(), checker.Equals, uint32(gid), check.Commentf("Copied file not owned by container root GID"))
|
|
}
|
|
|
|
func getRootUIDGID() (int, int, error) {
|
|
uidgid := strings.Split(filepath.Base(testEnv.DockerBasePath()), ".")
|
|
if len(uidgid) == 1 {
|
|
//user namespace remapping is not turned on; return 0
|
|
return 0, 0, nil
|
|
}
|
|
uid, err := strconv.Atoi(uidgid[0])
|
|
if err != nil {
|
|
return 0, 0, err
|
|
}
|
|
gid, err := strconv.Atoi(uidgid[1])
|
|
if err != nil {
|
|
return 0, 0, err
|
|
}
|
|
return uid, gid, nil
|
|
}
|