412c650e05
pkg/directory/directory.go:9:49: empty-lines: extra empty line at the start of a block (revive) pkg/pubsub/publisher.go:8:48: empty-lines: extra empty line at the start of a block (revive) pkg/loopback/attach_loopback.go:96:69: empty-lines: extra empty line at the start of a block (revive) pkg/devicemapper/devmapper_wrapper.go:136:48: empty-lines: extra empty line at the start of a block (revive) pkg/devicemapper/devmapper.go:391:35: empty-lines: extra empty line at the end of a block (revive) pkg/devicemapper/devmapper.go:676:35: empty-lines: extra empty line at the end of a block (revive) pkg/archive/changes_posix_test.go:15:38: empty-lines: extra empty line at the end of a block (revive) pkg/devicemapper/devmapper.go:241:51: empty-lines: extra empty line at the start of a block (revive) pkg/fileutils/fileutils_test.go:17:47: empty-lines: extra empty line at the end of a block (revive) pkg/fileutils/fileutils_test.go:34:48: empty-lines: extra empty line at the end of a block (revive) pkg/fileutils/fileutils_test.go:318:32: empty-lines: extra empty line at the end of a block (revive) pkg/tailfile/tailfile.go:171:6: empty-lines: extra empty line at the end of a block (revive) pkg/tarsum/fileinfosums_test.go:16:41: empty-lines: extra empty line at the end of a block (revive) pkg/tarsum/tarsum_test.go:198:42: empty-lines: extra empty line at the start of a block (revive) pkg/tarsum/tarsum_test.go:294:25: empty-lines: extra empty line at the start of a block (revive) pkg/tarsum/tarsum_test.go:407:34: empty-lines: extra empty line at the end of a block (revive) pkg/ioutils/fswriters_test.go:52:45: empty-lines: extra empty line at the end of a block (revive) pkg/ioutils/writers_test.go:24:39: empty-lines: extra empty line at the end of a block (revive) pkg/ioutils/bytespipe_test.go:78:26: empty-lines: extra empty line at the end of a block (revive) pkg/sysinfo/sysinfo_linux_test.go:13:37: empty-lines: extra empty line at the end of a block (revive) pkg/archive/archive_linux_test.go:57:64: empty-lines: extra empty line at the end of a block (revive) pkg/archive/changes.go:248:72: empty-lines: extra empty line at the start of a block (revive) pkg/archive/changes_posix_test.go:15:38: empty-lines: extra empty line at the end of a block (revive) pkg/archive/copy.go:248:124: empty-lines: extra empty line at the end of a block (revive) pkg/archive/diff_test.go:198:44: empty-lines: extra empty line at the end of a block (revive) pkg/archive/archive.go:304:12: empty-lines: extra empty line at the end of a block (revive) pkg/archive/archive.go:749:37: empty-lines: extra empty line at the end of a block (revive) pkg/archive/archive.go:812:81: empty-lines: extra empty line at the start of a block (revive) pkg/archive/copy_unix_test.go:347:34: empty-lines: extra empty line at the end of a block (revive) pkg/system/path.go:11:39: empty-lines: extra empty line at the end of a block (revive) pkg/system/meminfo_linux.go:29:21: empty-lines: extra empty line at the end of a block (revive) pkg/plugins/plugins.go:135:32: empty-lines: extra empty line at the end of a block (revive) pkg/authorization/response.go:71:48: empty-lines: extra empty line at the start of a block (revive) pkg/authorization/api_test.go:18:51: empty-lines: extra empty line at the end of a block (revive) pkg/authorization/middleware_test.go:23:44: empty-lines: extra empty line at the end of a block (revive) pkg/authorization/middleware_unix_test.go:17:46: empty-lines: extra empty line at the end of a block (revive) pkg/authorization/api_test.go:57:45: empty-lines: extra empty line at the end of a block (revive) pkg/authorization/response.go:83:50: empty-lines: extra empty line at the start of a block (revive) pkg/authorization/api_test.go:66:47: empty-lines: extra empty line at the end of a block (revive) pkg/authorization/middleware_unix_test.go:45:48: empty-lines: extra empty line at the end of a block (revive) pkg/authorization/response.go:145:75: empty-lines: extra empty line at the start of a block (revive) pkg/authorization/middleware_unix_test.go:56:51: empty-lines: extra empty line at the end of a block (revive) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
127 lines
2.9 KiB
Go
127 lines
2.9 KiB
Go
package archive // import "github.com/docker/docker/pkg/archive"
|
|
|
|
import (
|
|
"archive/tar"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"path"
|
|
"sort"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/pkg/idtools"
|
|
)
|
|
|
|
func TestHardLinkOrder(t *testing.T) {
|
|
names := []string{"file1.txt", "file2.txt", "file3.txt"}
|
|
msg := []byte("Hey y'all")
|
|
|
|
// Create dir
|
|
src, err := os.MkdirTemp("", "docker-hardlink-test-src-")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(src)
|
|
for _, name := range names {
|
|
func() {
|
|
fh, err := os.Create(path.Join(src, name))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer fh.Close()
|
|
if _, err = fh.Write(msg); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}()
|
|
}
|
|
// Create dest, with changes that includes hardlinks
|
|
dest, err := os.MkdirTemp("", "docker-hardlink-test-dest-")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
os.RemoveAll(dest) // we just want the name, at first
|
|
if err := copyDir(src, dest); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer os.RemoveAll(dest)
|
|
for _, name := range names {
|
|
for i := 0; i < 5; i++ {
|
|
if err := os.Link(path.Join(dest, name), path.Join(dest, fmt.Sprintf("%s.link%d", name, i))); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
}
|
|
|
|
// get changes
|
|
changes, err := ChangesDirs(dest, src)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// sort
|
|
sort.Sort(changesByPath(changes))
|
|
|
|
// ExportChanges
|
|
ar, err := ExportChanges(dest, changes, idtools.IdentityMapping{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
hdrs, err := walkHeaders(ar)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// reverse sort
|
|
sort.Sort(sort.Reverse(changesByPath(changes)))
|
|
// ExportChanges
|
|
arRev, err := ExportChanges(dest, changes, idtools.IdentityMapping{})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
hdrsRev, err := walkHeaders(arRev)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
// line up the two sets
|
|
sort.Sort(tarHeaders(hdrs))
|
|
sort.Sort(tarHeaders(hdrsRev))
|
|
|
|
// compare Size and LinkName
|
|
for i := range hdrs {
|
|
if hdrs[i].Name != hdrsRev[i].Name {
|
|
t.Errorf("headers - expected name %q; but got %q", hdrs[i].Name, hdrsRev[i].Name)
|
|
}
|
|
if hdrs[i].Size != hdrsRev[i].Size {
|
|
t.Errorf("headers - %q expected size %d; but got %d", hdrs[i].Name, hdrs[i].Size, hdrsRev[i].Size)
|
|
}
|
|
if hdrs[i].Typeflag != hdrsRev[i].Typeflag {
|
|
t.Errorf("headers - %q expected type %d; but got %d", hdrs[i].Name, hdrs[i].Typeflag, hdrsRev[i].Typeflag)
|
|
}
|
|
if hdrs[i].Linkname != hdrsRev[i].Linkname {
|
|
t.Errorf("headers - %q expected linkname %q; but got %q", hdrs[i].Name, hdrs[i].Linkname, hdrsRev[i].Linkname)
|
|
}
|
|
}
|
|
}
|
|
|
|
type tarHeaders []tar.Header
|
|
|
|
func (th tarHeaders) Len() int { return len(th) }
|
|
func (th tarHeaders) Swap(i, j int) { th[j], th[i] = th[i], th[j] }
|
|
func (th tarHeaders) Less(i, j int) bool { return th[i].Name < th[j].Name }
|
|
|
|
func walkHeaders(r io.Reader) ([]tar.Header, error) {
|
|
t := tar.NewReader(r)
|
|
var headers []tar.Header
|
|
for {
|
|
hdr, err := t.Next()
|
|
if err != nil {
|
|
if err == io.EOF {
|
|
break
|
|
}
|
|
return headers, err
|
|
}
|
|
headers = append(headers, *hdr)
|
|
}
|
|
return headers, nil
|
|
}
|