9a072adff3
This package doesn't really seem to do anything of real interest. Removing it and replacing with a few helper functions. Most of this was maintaining a fork of ctxhttp to support a mock that was unnecessary. We could probably do with a further refactor of the client interface. There is a lot of confusion of between transport, http layer and application layer that makes for some awkward code. This change improves the situation to the point where no breaking changes are introduced. Signed-off-by: Stephen J Day <stephen.day@docker.com>
97 lines
2.4 KiB
Go
97 lines
2.4 KiB
Go
package client
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/api/types"
|
|
"github.com/docker/docker/api/types/filters"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
func TestVolumeListError(t *testing.T) {
|
|
client := &Client{
|
|
client: newMockClient(errorMock(http.StatusInternalServerError, "Server error")),
|
|
}
|
|
|
|
_, err := client.VolumeList(context.Background(), filters.NewArgs())
|
|
if err == nil || err.Error() != "Error response from daemon: Server error" {
|
|
t.Fatalf("expected a Server Error, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestVolumeList(t *testing.T) {
|
|
expectedURL := "/volumes"
|
|
|
|
noDanglingFilters := filters.NewArgs()
|
|
noDanglingFilters.Add("dangling", "false")
|
|
|
|
danglingFilters := filters.NewArgs()
|
|
danglingFilters.Add("dangling", "true")
|
|
|
|
labelFilters := filters.NewArgs()
|
|
labelFilters.Add("label", "label1")
|
|
labelFilters.Add("label", "label2")
|
|
|
|
listCases := []struct {
|
|
filters filters.Args
|
|
expectedFilters string
|
|
}{
|
|
{
|
|
filters: filters.NewArgs(),
|
|
expectedFilters: "",
|
|
}, {
|
|
filters: noDanglingFilters,
|
|
expectedFilters: `{"dangling":{"false":true}}`,
|
|
}, {
|
|
filters: danglingFilters,
|
|
expectedFilters: `{"dangling":{"true":true}}`,
|
|
}, {
|
|
filters: labelFilters,
|
|
expectedFilters: `{"label":{"label1":true,"label2":true}}`,
|
|
},
|
|
}
|
|
|
|
for _, listCase := range listCases {
|
|
client := &Client{
|
|
client: newMockClient(func(req *http.Request) (*http.Response, error) {
|
|
if !strings.HasPrefix(req.URL.Path, expectedURL) {
|
|
return nil, fmt.Errorf("Expected URL '%s', got '%s'", expectedURL, req.URL)
|
|
}
|
|
query := req.URL.Query()
|
|
actualFilters := query.Get("filters")
|
|
if actualFilters != listCase.expectedFilters {
|
|
return nil, fmt.Errorf("filters not set in URL query properly. Expected '%s', got %s", listCase.expectedFilters, actualFilters)
|
|
}
|
|
content, err := json.Marshal(types.VolumesListResponse{
|
|
Volumes: []*types.Volume{
|
|
{
|
|
Name: "volume",
|
|
Driver: "local",
|
|
},
|
|
},
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &http.Response{
|
|
StatusCode: http.StatusOK,
|
|
Body: ioutil.NopCloser(bytes.NewReader(content)),
|
|
}, nil
|
|
}),
|
|
}
|
|
|
|
volumeResponse, err := client.VolumeList(context.Background(), listCase.filters)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(volumeResponse.Volumes) != 1 {
|
|
t.Fatalf("expected 1 volume, got %v", volumeResponse.Volumes)
|
|
}
|
|
}
|
|
}
|