d942c59b69
When we use the engine/env object we can run into a situation where a string is passed in as the value but later on when we json serialize the name/value pairs, because the string is made up of just numbers it appears as an integer and not a string - meaning no quotes. This can cause parsing issues for clients. I tried to find all spots where we call env.Set() and the type of the name being set might end up having a value that could look like an int (like author). In those cases I switched it to use env.SetJson() instead because that will wrap it in quotes. One interesting thing to note about the testcase that I modified is that the escaped quotes should have been there all along and we were incorrectly letting it thru. If you look at the metadata stored for that resource you can see the quotes were escaped and we lost them during the serialization steps because of the env.Set() stuff. The use of env is probably not the best way to do all of this. Closes: #9602 Signed-off-by: Doug Davis <dug@us.ibm.com>
46 lines
1.2 KiB
Go
46 lines
1.2 KiB
Go
package graph
|
|
|
|
import (
|
|
"strings"
|
|
|
|
"github.com/docker/docker/engine"
|
|
"github.com/docker/docker/image"
|
|
)
|
|
|
|
func (s *TagStore) CmdHistory(job *engine.Job) engine.Status {
|
|
if n := len(job.Args); n != 1 {
|
|
return job.Errorf("Usage: %s IMAGE", job.Name)
|
|
}
|
|
name := job.Args[0]
|
|
foundImage, err := s.LookupImage(name)
|
|
if err != nil {
|
|
return job.Error(err)
|
|
}
|
|
|
|
lookupMap := make(map[string][]string)
|
|
for name, repository := range s.Repositories {
|
|
for tag, id := range repository {
|
|
// If the ID already has a reverse lookup, do not update it unless for "latest"
|
|
if _, exists := lookupMap[id]; !exists {
|
|
lookupMap[id] = []string{}
|
|
}
|
|
lookupMap[id] = append(lookupMap[id], name+":"+tag)
|
|
}
|
|
}
|
|
|
|
outs := engine.NewTable("Created", 0)
|
|
err = foundImage.WalkHistory(func(img *image.Image) error {
|
|
out := &engine.Env{}
|
|
out.SetJson("Id", img.ID)
|
|
out.SetInt64("Created", img.Created.Unix())
|
|
out.Set("CreatedBy", strings.Join(img.ContainerConfig.Cmd, " "))
|
|
out.SetList("Tags", lookupMap[img.ID])
|
|
out.SetInt64("Size", img.Size)
|
|
outs.Add(out)
|
|
return nil
|
|
})
|
|
if _, err := outs.WriteListTo(job.Stdout); err != nil {
|
|
return job.Error(err)
|
|
}
|
|
return engine.StatusOK
|
|
}
|