4bafaa00aa
The containerd client is very chatty at the best of times. Because the libcontained API is stateless and references containers and processes by string ID for every method call, the implementation is essentially forced to use the containerd client in a way which amplifies the number of redundant RPCs invoked to perform any operation. The libcontainerd remote implementation has to reload the containerd container, task and/or process metadata for nearly every operation. This in turn amplifies the number of context switches between dockerd and containerd to perform any container operation or handle a containerd event, increasing the load on the system which could otherwise be allocated to workloads. Overhaul the libcontainerd interface to reduce the impedance mismatch with the containerd client so that the containerd client can be used more efficiently. Split the API out into container, task and process interfaces which the consumer is expected to retain so that libcontainerd can retain state---especially the analogous containerd client objects---without having to manage any state-store inside the libcontainerd client. Signed-off-by: Cory Snider <csnider@mirantis.com>
54 lines
1.5 KiB
Go
54 lines
1.5 KiB
Go
package daemon // import "github.com/docker/docker/daemon"
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
)
|
|
|
|
// ContainerResize changes the size of the TTY of the process running
|
|
// in the container with the given name to the given height and width.
|
|
func (daemon *Daemon) ContainerResize(name string, height, width int) error {
|
|
container, err := daemon.GetContainer(name)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
container.Lock()
|
|
tsk, err := container.GetRunningTask()
|
|
container.Unlock()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if err = tsk.Resize(context.Background(), uint32(width), uint32(height)); err == nil {
|
|
attributes := map[string]string{
|
|
"height": fmt.Sprintf("%d", height),
|
|
"width": fmt.Sprintf("%d", width),
|
|
}
|
|
daemon.LogContainerEventWithAttributes(container, "resize", attributes)
|
|
}
|
|
return err
|
|
}
|
|
|
|
// ContainerExecResize changes the size of the TTY of the process
|
|
// running in the exec with the given name to the given height and
|
|
// width.
|
|
func (daemon *Daemon) ContainerExecResize(name string, height, width int) error {
|
|
ec, err := daemon.getExecConfig(name)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// TODO: the timeout is hardcoded here, it would be more flexible to make it
|
|
// a parameter in resize request context, which would need API changes.
|
|
timeout := time.NewTimer(10 * time.Second)
|
|
defer timeout.Stop()
|
|
|
|
select {
|
|
case <-ec.Started:
|
|
return ec.Process.Resize(context.Background(), uint32(width), uint32(height))
|
|
case <-timeout.C:
|
|
return fmt.Errorf("timeout waiting for exec session ready")
|
|
}
|
|
}
|