beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
moby/integration-cli
History
Yong Tang 5aa5a1cb00 Show usage when docker swarm update has no flags 
This fix tries to address the issue raised in 24352. Previously,
when `docker swarm update` has no flags, the output is
```
Swarm updated.
```
even though nothing was updated. This could be misleading for
users.

This fix tries to address the issue by adding a `PreRunE` function
in the command so that in case no flag is provided (`cmd.Flags().NFlag() == 0`),
the usage will be outputed instead.

An integration has been added to cover the changes.

This fix fixes 24352.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2016-12-13 05:05:04 -08:00
..
daemon Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
fixtures Add integration test for stack deploy. 2016-11-10 11:28:18 -05:00
benchmark_test.go Windows: docker top implementation 2016-09-07 16:29:02 -07:00
check_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
daemon_swarm_hack.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_api_attach_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_api_auth_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_build_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_api_containers_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_api_create_test.go Fix /proc/<pid>/oom_score_adj: invalid argument error caused by empty env name 2016-11-07 08:15:26 -08:00
docker_api_events_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_exec_resize_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_exec_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_api_images_test.go Generate api/types:Image from the swagger spec 2016-10-20 13:24:23 -07:00
docker_api_info_test.go Windows: Require REST 1.25 or later 2016-10-31 14:33:59 -07:00
docker_api_inspect_test.go Windows: Require REST 1.25 or later 2016-10-31 14:33:59 -07:00
docker_api_inspect_unix_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_logs_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_network_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_resize_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_service_update_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_api_stats_test.go Rename Remote API to Engine API 2016-11-22 12:49:38 +00:00
docker_api_stats_unix_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_swarm_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_api_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_api_update_unix_test.go [nit] integration-cli: obey Go's naming convention 2016-09-30 01:21:05 +00:00
docker_api_version_test.go Add engine-api types to docker 2016-09-07 11:05:58 -07:00
docker_api_volumes_test.go Use a config to generate swagger api types 2016-10-31 11:13:41 -04:00
docker_cli_attach_test.go Use check in params so we don't ignore errors 2016-12-08 10:56:29 +01:00
docker_cli_attach_unix_test.go Improve TestAttachClosedOnContainerStop 2016-10-05 15:52:09 -07:00
docker_cli_authz_plugin_v2_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_authz_unix_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_build_test.go Fix processing of unset build-args during build 2016-12-07 07:41:55 -08:00
docker_cli_build_unix_test.go Create a unified RunCommand function with Assert() 2016-08-23 15:11:46 -04:00
docker_cli_by_digest_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_cli_commit_test.go Use check in params so we don't ignore errors 2016-12-08 10:56:29 +01:00
docker_cli_config_test.go always add but hide experimental cmds and flags 2016-11-08 04:55:27 -08:00
docker_cli_cp_from_container_test.go Windows: Enable some cp integration tests 2016-08-30 14:32:10 -07:00
docker_cli_cp_test.go Fix bunch of typos 2016-10-29 15:03:26 +08:00
docker_cli_cp_to_container_test.go Windows: Enable some cp integration tests 2016-08-30 14:32:10 -07:00
docker_cli_cp_to_container_unix_test.go Fix copy chown settings to not default to real root 2016-02-18 14:44:13 -08:00
docker_cli_cp_utils.go Use checker assert for integration-cli/docker_cli_cp_* four files. 2015-10-26 10:22:28 +08:00
docker_cli_create_test.go Add config parameter to change per-container stop timeout during daemon shutdown 2016-10-17 12:28:46 -07:00
docker_cli_daemon_plugins_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_daemon_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_diff_test.go Windows: Port a docker diff test 2016-10-28 12:21:54 -07:00
docker_cli_events_test.go Fixes some integration-cli on userns 2016-11-23 14:03:53 +01:00
docker_cli_events_unix_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_exec_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_exec_unix_test.go Add TERM env var to exec 2016-09-12 09:20:27 -07:00
docker_cli_experimental_test.go Make experimental a runtime flag 2016-10-24 15:20:01 -07:00
docker_cli_export_import_test.go Using checkers assert for integration-cli/docker_cli_export_import_test.go 2015-10-21 08:57:20 -04:00
docker_cli_external_graphdriver_unix_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_external_volume_driver_unix_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_health_test.go Adds container health support to docker ps filter 2016-10-28 15:43:04 -04:00
docker_cli_help_test.go fix a few golint errors 2016-11-18 18:32:02 -08:00
docker_cli_history_test.go Windows: Enable docker_cli_history_test 2016-08-30 09:31:33 -07:00
docker_cli_images_test.go all: replace loop with single append 2016-10-13 13:31:52 -07:00
docker_cli_import_test.go Fix issue in docker import -c with quoted flags 2016-09-01 16:28:22 -07:00
docker_cli_info_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_info_unix_test.go daemon: add a flag to override the default seccomp profile 2016-11-02 21:41:29 +01:00
docker_cli_inspect_test.go Use check in params so we don't ignore errors 2016-12-08 10:56:29 +01:00
docker_cli_kill_test.go Add restart policy to restart policy tests 2016-11-09 17:13:42 -06:00
docker_cli_links_test.go Remove unnecessary json.Unmarshal wrapper. 2016-08-23 15:11:46 -04:00
docker_cli_links_unix_test.go use of checkers on Integration test 2015-10-18 09:00:08 +08:00
docker_cli_login_test.go Planned 1.13 deprecation: email from login 2016-11-11 17:32:46 -08:00
docker_cli_logout_test.go support legacy registries in exernal stores 2016-09-07 09:45:42 +02:00
docker_cli_logs_bench_test.go Fixes some issues with jsonfile write/read 2016-03-21 11:05:58 -04:00
docker_cli_logs_test.go Change reading order of tailfile 2016-11-13 20:08:51 -08:00
docker_cli_nat_test.go Assert error in body of function inspectField* 2016-01-29 23:39:07 +08:00
docker_cli_netmode_test.go fix typos 2016-06-02 17:17:22 +08:00
docker_cli_network_unix_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_oom_killed_test.go Add the swapMemorySupport requirement to OOM tests 2016-05-10 11:28:00 -07:00
docker_cli_pause_test.go Use check in params so we don't ignore errors 2016-12-08 10:56:29 +01:00
docker_cli_plugins_test.go plugins: container-rootfs-relative paths 2016-12-09 10:16:24 -08:00
docker_cli_port_test.go Expose bridge IPv6 setting to docker network inspect 2016-02-11 22:13:47 +00:00
docker_cli_proxy_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_prune_unix_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_ps_test.go Adds container health support to docker ps filter 2016-10-28 15:43:04 -04:00
docker_cli_pull_local_test.go support legacy registries in exernal stores 2016-09-07 09:45:42 +02:00
docker_cli_pull_test.go Add class to repository scope 2016-11-21 22:18:50 -08:00
docker_cli_pull_trusted_test.go Fix API incompatibilities between notary v0.3.0 and v0.4.2: 2016-10-14 17:53:34 -07:00
docker_cli_push_test.go Update token server error test to not fail on retries 2016-09-01 15:18:15 -07:00
docker_cli_registry_user_agent_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_rename_test.go Support plugins in docker inspect 2016-12-02 11:33:29 -08:00
docker_cli_restart_test.go Remove some unused global variables 2016-12-08 19:51:42 +01:00
docker_cli_rm_test.go Fix typo in integration-cli (#29160) 2016-12-05 22:23:41 -05:00
docker_cli_rmi_test.go Move some test fixtures to go 2016-09-07 17:30:35 -04:00
docker_cli_run_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_run_unix_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_save_load_test.go add defer file.Close to avoid potential fd leak 2016-08-10 08:36:09 +08:00
docker_cli_save_load_unix_test.go Validate docker-load receives a tar file 2016-10-31 15:30:55 +02:00
docker_cli_search_test.go Use spf13/cobra for docker search 2016-06-03 19:50:01 +02:00
docker_cli_secret_create_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_cli_secret_inspect_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_cli_service_create_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_cli_service_health_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_cli_service_logs_experimental_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_cli_service_scale_test.go validate service parameter in client side to avoid api call 2016-09-26 17:18:02 +08:00
docker_cli_service_update_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_cli_sni_test.go Disable flakey TestClientSetsTLSServerName 2016-02-02 19:56:31 -08:00
docker_cli_stack_test.go Restore stack deploy integration test with dab 2016-11-10 11:28:19 -05:00
docker_cli_start_test.go Use check in params so we don't ignore errors 2016-12-08 10:56:29 +01:00
docker_cli_stats_test.go Do not remove containers from stats list on err 2016-04-13 16:36:34 -04:00
docker_cli_stop_test.go Add test case for stopping a restarting container 2016-04-10 15:39:28 +08:00
docker_cli_swarm_test.go Show usage when docker swarm update has no flags 2016-12-13 05:05:04 -08:00
docker_cli_tag_test.go Remove deprecated -f flag on docker tag 2016-06-01 09:44:25 -07:00
docker_cli_top_test.go Windows: docker top implementation 2016-09-07 16:29:02 -07:00
docker_cli_update_test.go Forbid update restart policy of container with AutoRemove flag 2016-08-16 15:36:13 +08:00
docker_cli_update_unix_test.go Add engine-api types to docker 2016-09-07 11:05:58 -07:00
docker_cli_userns_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_v2_only_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_cli_version_test.go Align output of docker version again 2016-11-28 11:38:58 -08:00
docker_cli_volume_test.go add break when found in TestVolumeCLICreateWithOpts() 2016-12-08 15:59:52 +08:00
docker_cli_wait_test.go Better logging for errors in some tests 2016-03-25 10:02:52 -04:00
docker_deprecated_api_v124_test.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
docker_deprecated_api_v124_unix_test.go remove deprecated feature of passing HostConfig at API container start 2016-06-01 22:25:17 +08:00
docker_experimental_network_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_hub_pull_suite_test.go Use *check.C in StartWithBusybox, Start, Stop and Restart… 2016-12-12 09:46:47 +01:00
docker_test_vars.go Remove some unused global variables 2016-12-08 19:51:42 +01:00
docker_utils.go Extract daemon to its own package 2016-12-09 22:26:42 +01:00
events_utils.go test: fix trivial code convention noncompliance 2016-09-12 07:36:52 +00:00
fixtures.go Move some test fixtures to go 2016-09-07 17:30:35 -04:00
fixtures_linux_daemon.go Use runc version built without ambient capabilities 2016-11-04 17:25:28 +00:00
registry.go add defer file.Close to avoid potential fd leak 2016-08-10 08:36:09 +08:00
registry_mock.go integration-cli: log error when starting registry 2016-01-11 20:16:13 +01:00
requirements.go Windows: Add cpu count option 2016-11-04 13:38:50 -07:00
requirements_unix.go Add support for ambient capabilities 2016-10-10 19:29:02 +01:00
test_vars.go Windows: docker top implementation 2016-09-07 16:29:02 -07:00
test_vars_exec.go integration-cli: add test requirement ExecSupport 2015-02-20 23:24:30 -08:00
test_vars_noexec.go integration-cli: add test requirement ExecSupport 2015-02-20 23:24:30 -08:00
test_vars_noseccomp.go Allow non-seccomp platforms to pass integration-cli tests 2015-12-07 20:14:52 -05:00
test_vars_seccomp.go Allow non-seccomp platforms to pass integration-cli tests 2015-12-07 20:14:52 -05:00
test_vars_unix.go Windows: docker top implementation 2016-09-07 16:29:02 -07:00
test_vars_windows.go Windows: docker top implementation 2016-09-07 16:29:02 -07:00
trust_server.go Fix govet for go1.7 2016-09-02 19:07:54 -07:00
utils.go Create a unified RunCommand function with Assert() 2016-08-23 15:11:46 -04:00