moby/libcontainerd
Paweł Gronowski 55b664046c
libcontainer/windows: Fix process not being killed after stdio attach failure
Error check in defer block used wrong error variable which is always nil
if the flow reaches the defer. This caused the `newProcess.Kill` to be
never called if the subsequent attemp to attach to the stdio failed.
Although this only happens in Exec (as Start does overwrite the error),
this also adjusts the Start to also use the returned error to avoid this
kind of mistake in future changes.

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
2023-09-14 11:10:11 +02:00
..
local libcontainer/windows: Fix process not being killed after stdio attach failure 2023-09-14 11:10:11 +02:00
queue bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
remote swap logrus types for their containerd/logs aliases 2023-08-01 13:02:55 +02:00
shimopts daemon: allow shimv2 runtimes to be configured 2023-02-17 18:08:06 -05:00
supervisor Add otel support 2023-09-07 18:38:19 +00:00
types daemon: stop setting container resources to zero 2023-06-06 12:13:05 -04:00
libcontainerd_linux.go Configure shims from runtime config 2020-07-13 14:18:02 -07:00
libcontainerd_windows.go Remove unused useShimV2() 2020-07-15 14:28:48 +02:00
replace.go Switch all logging to use containerd log pkg 2023-06-24 00:23:44 +00:00