d18919e304
- Updated Dockerfile to satisfy libnetwork GOPATH requirements.
- Reworked daemon to allocate network resources using libnetwork.
- Reworked remove link code to also update network resources in libnetwork.
- Adjusted the exec driver command population to reflect libnetwork design.
- Adjusted the exec driver create command steps.
- Updated a few test cases to reflect the change in design.
- Removed the dns setup code from docker as resolv.conf is entirely managed
in libnetwork.
- Integrated with lxc exec driver.
Signed-off-by: Jana Radhakrishnan <mrjana@docker.com>
326 lines
10 KiB
Go
326 lines
10 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"reflect"
|
|
"regexp"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/go-check/check"
|
|
)
|
|
|
|
func (s *DockerSuite) TestLinksEtcHostsRegularFile(c *check.C) {
|
|
runCmd := exec.Command(dockerBinary, "run", "--net=host", "busybox", "ls", "-la", "/etc/hosts")
|
|
out, _, _, err := runCommandWithStdoutStderr(runCmd)
|
|
if err != nil {
|
|
c.Fatal(out, err)
|
|
}
|
|
|
|
if !strings.HasPrefix(out, "-") {
|
|
c.Errorf("/etc/hosts should be a regular file")
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinksEtcHostsContentMatch(c *check.C) {
|
|
testRequires(c, SameHostDaemon)
|
|
|
|
runCmd := exec.Command(dockerBinary, "run", "--net=host", "busybox", "cat", "/etc/hosts")
|
|
out, _, _, err := runCommandWithStdoutStderr(runCmd)
|
|
if err != nil {
|
|
c.Fatal(out, err)
|
|
}
|
|
|
|
hosts, err := ioutil.ReadFile("/etc/hosts")
|
|
if os.IsNotExist(err) {
|
|
c.Skip("/etc/hosts does not exist, skip this test")
|
|
}
|
|
|
|
if out != string(hosts) {
|
|
c.Errorf("container")
|
|
}
|
|
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinksPingUnlinkedContainers(c *check.C) {
|
|
runCmd := exec.Command(dockerBinary, "run", "--rm", "busybox", "sh", "-c", "ping -c 1 alias1 -W 1 && ping -c 1 alias2 -W 1")
|
|
exitCode, err := runCommand(runCmd)
|
|
|
|
if exitCode == 0 {
|
|
c.Fatal("run ping did not fail")
|
|
} else if exitCode != 1 {
|
|
c.Fatalf("run ping failed with errors: %v", err)
|
|
}
|
|
|
|
}
|
|
|
|
// Test for appropriate error when calling --link with an invalid target container
|
|
func (s *DockerSuite) TestLinksInvalidContainerTarget(c *check.C) {
|
|
|
|
runCmd := exec.Command(dockerBinary, "run", "--link", "bogus:alias", "busybox", "true")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
|
|
if err == nil {
|
|
c.Fatal("an invalid container target should produce an error")
|
|
}
|
|
if !strings.Contains(out, "Could not get container") {
|
|
c.Fatalf("error output expected 'Could not get container', but got %q instead; err: %v", out, err)
|
|
}
|
|
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinksPingLinkedContainers(c *check.C) {
|
|
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "--name", "container1", "--hostname", "fred", "busybox", "top")
|
|
if _, err := runCommand(runCmd); err != nil {
|
|
c.Fatal(err)
|
|
}
|
|
runCmd = exec.Command(dockerBinary, "run", "-d", "--name", "container2", "--hostname", "wilma", "busybox", "top")
|
|
if _, err := runCommand(runCmd); err != nil {
|
|
c.Fatal(err)
|
|
}
|
|
|
|
runArgs := []string{"run", "--rm", "--link", "container1:alias1", "--link", "container2:alias2", "busybox", "sh", "-c"}
|
|
pingCmd := "ping -c 1 %s -W 1 && ping -c 1 %s -W 1"
|
|
|
|
// test ping by alias, ping by name, and ping by hostname
|
|
// 1. Ping by alias
|
|
dockerCmd(c, append(runArgs, fmt.Sprintf(pingCmd, "alias1", "alias2"))...)
|
|
// 2. Ping by container name
|
|
dockerCmd(c, append(runArgs, fmt.Sprintf(pingCmd, "container1", "container2"))...)
|
|
// 3. Ping by hostname
|
|
dockerCmd(c, append(runArgs, fmt.Sprintf(pingCmd, "fred", "wilma"))...)
|
|
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinksPingLinkedContainersAfterRename(c *check.C) {
|
|
|
|
out, _ := dockerCmd(c, "run", "-d", "--name", "container1", "busybox", "top")
|
|
idA := strings.TrimSpace(out)
|
|
out, _ = dockerCmd(c, "run", "-d", "--name", "container2", "busybox", "top")
|
|
idB := strings.TrimSpace(out)
|
|
dockerCmd(c, "rename", "container1", "container_new")
|
|
dockerCmd(c, "run", "--rm", "--link", "container_new:alias1", "--link", "container2:alias2", "busybox", "sh", "-c", "ping -c 1 alias1 -W 1 && ping -c 1 alias2 -W 1")
|
|
dockerCmd(c, "kill", idA)
|
|
dockerCmd(c, "kill", idB)
|
|
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinksInspectLinksStarted(c *check.C) {
|
|
var (
|
|
expected = map[string]struct{}{"/container1:/testinspectlink/alias1": {}, "/container2:/testinspectlink/alias2": {}}
|
|
result []string
|
|
)
|
|
dockerCmd(c, "run", "-d", "--name", "container1", "busybox", "top")
|
|
dockerCmd(c, "run", "-d", "--name", "container2", "busybox", "top")
|
|
dockerCmd(c, "run", "-d", "--name", "testinspectlink", "--link", "container1:alias1", "--link", "container2:alias2", "busybox", "top")
|
|
links, err := inspectFieldJSON("testinspectlink", "HostConfig.Links")
|
|
if err != nil {
|
|
c.Fatal(err)
|
|
}
|
|
|
|
err = unmarshalJSON([]byte(links), &result)
|
|
if err != nil {
|
|
c.Fatal(err)
|
|
}
|
|
|
|
output := convertSliceOfStringsToMap(result)
|
|
|
|
equal := reflect.DeepEqual(output, expected)
|
|
|
|
if !equal {
|
|
c.Fatalf("Links %s, expected %s", result, expected)
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinksInspectLinksStopped(c *check.C) {
|
|
var (
|
|
expected = map[string]struct{}{"/container1:/testinspectlink/alias1": {}, "/container2:/testinspectlink/alias2": {}}
|
|
result []string
|
|
)
|
|
dockerCmd(c, "run", "-d", "--name", "container1", "busybox", "top")
|
|
dockerCmd(c, "run", "-d", "--name", "container2", "busybox", "top")
|
|
dockerCmd(c, "run", "-d", "--name", "testinspectlink", "--link", "container1:alias1", "--link", "container2:alias2", "busybox", "true")
|
|
links, err := inspectFieldJSON("testinspectlink", "HostConfig.Links")
|
|
if err != nil {
|
|
c.Fatal(err)
|
|
}
|
|
|
|
err = unmarshalJSON([]byte(links), &result)
|
|
if err != nil {
|
|
c.Fatal(err)
|
|
}
|
|
|
|
output := convertSliceOfStringsToMap(result)
|
|
|
|
equal := reflect.DeepEqual(output, expected)
|
|
|
|
if !equal {
|
|
c.Fatalf("Links %s, but expected %s", result, expected)
|
|
}
|
|
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinksNotStartedParentNotFail(c *check.C) {
|
|
runCmd := exec.Command(dockerBinary, "create", "--name=first", "busybox", "top")
|
|
out, _, _, err := runCommandWithStdoutStderr(runCmd)
|
|
if err != nil {
|
|
c.Fatal(out, err)
|
|
}
|
|
runCmd = exec.Command(dockerBinary, "create", "--name=second", "--link=first:first", "busybox", "top")
|
|
out, _, _, err = runCommandWithStdoutStderr(runCmd)
|
|
if err != nil {
|
|
c.Fatal(out, err)
|
|
}
|
|
runCmd = exec.Command(dockerBinary, "start", "first")
|
|
out, _, _, err = runCommandWithStdoutStderr(runCmd)
|
|
if err != nil {
|
|
c.Fatal(out, err)
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinksHostsFilesInject(c *check.C) {
|
|
testRequires(c, SameHostDaemon, ExecSupport)
|
|
|
|
out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-itd", "--name", "one", "busybox", "top"))
|
|
if err != nil {
|
|
c.Fatal(err, out)
|
|
}
|
|
|
|
idOne := strings.TrimSpace(out)
|
|
|
|
out, _, err = runCommandWithOutput(exec.Command(dockerBinary, "run", "-itd", "--name", "two", "--link", "one:onetwo", "busybox", "top"))
|
|
if err != nil {
|
|
c.Fatal(err, out)
|
|
}
|
|
|
|
idTwo := strings.TrimSpace(out)
|
|
|
|
time.Sleep(1 * time.Second)
|
|
|
|
contentOne, err := readContainerFileWithExec(idOne, "/etc/hosts")
|
|
if err != nil {
|
|
c.Fatal(err, string(contentOne))
|
|
}
|
|
|
|
contentTwo, err := readContainerFileWithExec(idTwo, "/etc/hosts")
|
|
if err != nil {
|
|
c.Fatal(err, string(contentTwo))
|
|
}
|
|
|
|
if !strings.Contains(string(contentTwo), "onetwo") {
|
|
c.Fatal("Host is not present in updated hosts file", string(contentTwo))
|
|
}
|
|
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinksNetworkHostContainer(c *check.C) {
|
|
|
|
out, _, err := runCommandWithOutput(exec.Command(dockerBinary, "run", "-d", "--net", "host", "--name", "host_container", "busybox", "top"))
|
|
if err != nil {
|
|
c.Fatal(err, out)
|
|
}
|
|
|
|
out, _, err = runCommandWithOutput(exec.Command(dockerBinary, "run", "--name", "should_fail", "--link", "host_container:tester", "busybox", "true"))
|
|
if err == nil || !strings.Contains(out, "--net=host can't be used with links. This would result in undefined behavior") {
|
|
c.Fatalf("Running container linking to a container with --net host should have failed: %s", out)
|
|
}
|
|
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinksUpdateOnRestart(c *check.C) {
|
|
testRequires(c, SameHostDaemon, ExecSupport)
|
|
|
|
if out, err := exec.Command(dockerBinary, "run", "-d", "--name", "one", "busybox", "top").CombinedOutput(); err != nil {
|
|
c.Fatal(err, string(out))
|
|
}
|
|
out, err := exec.Command(dockerBinary, "run", "-d", "--name", "two", "--link", "one:onetwo", "--link", "one:one", "busybox", "top").CombinedOutput()
|
|
if err != nil {
|
|
c.Fatal(err, string(out))
|
|
}
|
|
id := strings.TrimSpace(string(out))
|
|
|
|
realIP, err := inspectField("one", "NetworkSettings.IPAddress")
|
|
if err != nil {
|
|
c.Fatal(err)
|
|
}
|
|
content, err := readContainerFileWithExec(id, "/etc/hosts")
|
|
if err != nil {
|
|
c.Fatal(err, string(content))
|
|
}
|
|
getIP := func(hosts []byte, hostname string) string {
|
|
re := regexp.MustCompile(fmt.Sprintf(`(\S*)\t%s`, regexp.QuoteMeta(hostname)))
|
|
matches := re.FindSubmatch(hosts)
|
|
if matches == nil {
|
|
c.Fatalf("Hostname %s have no matches in hosts", hostname)
|
|
}
|
|
return string(matches[1])
|
|
}
|
|
if ip := getIP(content, "one"); ip != realIP {
|
|
c.Fatalf("For 'one' alias expected IP: %s, got: %s", realIP, ip)
|
|
}
|
|
if ip := getIP(content, "onetwo"); ip != realIP {
|
|
c.Fatalf("For 'onetwo' alias expected IP: %s, got: %s", realIP, ip)
|
|
}
|
|
if out, err := exec.Command(dockerBinary, "restart", "one").CombinedOutput(); err != nil {
|
|
c.Fatal(err, string(out))
|
|
}
|
|
realIP, err = inspectField("one", "NetworkSettings.IPAddress")
|
|
if err != nil {
|
|
c.Fatal(err)
|
|
}
|
|
content, err = readContainerFileWithExec(id, "/etc/hosts")
|
|
if err != nil {
|
|
c.Fatal(err, string(content))
|
|
}
|
|
if ip := getIP(content, "one"); ip != realIP {
|
|
c.Fatalf("For 'one' alias expected IP: %s, got: %s", realIP, ip)
|
|
}
|
|
if ip := getIP(content, "onetwo"); ip != realIP {
|
|
c.Fatalf("For 'onetwo' alias expected IP: %s, got: %s", realIP, ip)
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinksEnvs(c *check.C) {
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "-e", "e1=", "-e", "e2=v2", "-e", "e3=v3=v3", "--name=first", "busybox", "top")
|
|
out, _, _, err := runCommandWithStdoutStderr(runCmd)
|
|
if err != nil {
|
|
c.Fatalf("Run of first failed: %s\n%s", out, err)
|
|
}
|
|
|
|
runCmd = exec.Command(dockerBinary, "run", "--name=second", "--link=first:first", "busybox", "env")
|
|
|
|
out, stde, rc, err := runCommandWithStdoutStderr(runCmd)
|
|
if err != nil || rc != 0 {
|
|
c.Fatalf("run of 2nd failed: rc: %d, out: %s\n err: %s", rc, out, stde)
|
|
}
|
|
|
|
if !strings.Contains(out, "FIRST_ENV_e1=\n") ||
|
|
!strings.Contains(out, "FIRST_ENV_e2=v2") ||
|
|
!strings.Contains(out, "FIRST_ENV_e3=v3=v3") {
|
|
c.Fatalf("Incorrect output: %s", out)
|
|
}
|
|
}
|
|
|
|
func (s *DockerSuite) TestLinkShortDefinition(c *check.C) {
|
|
runCmd := exec.Command(dockerBinary, "run", "-d", "--name", "shortlinkdef", "busybox", "top")
|
|
out, _, err := runCommandWithOutput(runCmd)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
cid := strings.TrimSpace(out)
|
|
c.Assert(waitRun(cid), check.IsNil)
|
|
|
|
runCmd = exec.Command(dockerBinary, "run", "-d", "--name", "link2", "--link", "shortlinkdef", "busybox", "top")
|
|
out, _, err = runCommandWithOutput(runCmd)
|
|
c.Assert(err, check.IsNil)
|
|
|
|
cid2 := strings.TrimSpace(out)
|
|
c.Assert(waitRun(cid2), check.IsNil)
|
|
|
|
links, err := inspectFieldJSON(cid2, "HostConfig.Links")
|
|
c.Assert(err, check.IsNil)
|
|
c.Assert(links, check.Equals, "[\"/shortlinkdef:/link2/shortlinkdef\"]")
|
|
}
|