moby/pkg
Yong Tang 397a6fefad Inconsistent --tmpfs behavior
This fix tries to address the issue raised in #22420. When
`--tmpfs` is specified with `/tmp`, the default value is
`rw,nosuid,nodev,noexec,relatime,size=65536k`. When `--tmpfs`
is specified with `/tmp:rw`, then the value changed to
`rw,nosuid,nodev,noexec,relatime`.

The reason for such an inconsistency is because docker tries
to add `size=65536k` option only when user provides no option.

This fix tries to address this issue by always pre-progating
`size=65536k` along with `rw,nosuid,nodev,noexec,relatime`.
If user provides a different value (e.g., `size=8192k`), it
will override the `size=65536k` anyway since the combined
options will be parsed and merged to remove any duplicates.

Additional test cases have been added to cover the changes
in this fix.

This fix fixes #22420.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2016-05-26 19:28:18 -07:00
..
aaparser apparmor: fix version checks to work properly 2016-02-15 20:36:07 +11:00
archive fix typos 2016-05-06 18:23:11 +08:00
authorization pkg: authorization: cleanup tests 2016-05-08 14:18:38 +02:00
broadcaster Improved push and pull with upload manager and download manager 2015-12-09 19:13:35 -08:00
chrootarchive pkg: chrootarchive: chroot_linux: fix docker build 2016-05-10 00:42:49 +02:00
devicemapper loopback: separate loop logic from devicemapper 2015-12-18 10:57:43 -05:00
directory Get the Docker Engine to build clean on Solaris 2016-05-23 16:37:12 -07:00
discovery Fix a race in pkg/discovery/memory 2016-05-25 04:01:43 +00:00
filenotify add file poller panic fix from 1.10.2 2016-02-24 10:17:29 -05:00
fileutils Get the Docker Engine to build clean on Solaris 2016-05-23 16:37:12 -07:00
gitutils Windows CI: Unit tests - port pkg\gitutils 2016-02-11 18:19:17 -08:00
graphdb Windows CI: Turn off failing unit tests pkg\graphdb 2016-03-02 19:27:41 -08:00
homedir Revert "resolve the config file from the sudo user" 2016-02-29 13:51:43 +01:00
httputils Fix some typos in comments and strings 2016-02-22 20:27:15 +01:00
idtools Lazy init useradd and remove init() 2016-04-06 17:53:45 -04:00
integration Fix a race in pkg/integration.TestChannelBufferTimeout 2016-05-25 07:09:38 +00:00
ioutils Fix concurrent map access in bytespipe 2016-05-12 10:04:05 -04:00
jsonlog Add support for reading logs extra attrs 2016-05-06 20:42:20 -04:00
jsonmessage Send push information to trust code out-of-band 2016-01-08 10:57:50 -08:00
listeners Get the Docker Engine to build clean on Solaris 2016-05-23 16:37:12 -07:00
locker Fix typos found across repository 2015-12-13 18:04:12 +02:00
longpath Windows: Fixing longpath hanlding of UNC paths. 2015-09-30 19:36:08 -07:00
loopback loopback: separate loop logic from devicemapper 2015-12-18 10:57:43 -05:00
mflag Merge pull request #19517 from calavera/validate_config_keys 2016-01-22 15:01:29 -05:00
mount Inconsistent --tmpfs behavior 2016-05-26 19:28:18 -07:00
namesgenerator Adding Rita Levi-Montalcini and Claude Shannon to name generator 2016-05-04 00:14:09 +05:30
parsers Get the Docker Engine to build clean on Solaris 2016-05-23 16:37:12 -07:00
pidfile Windows: don't overwrite PID file if process exists 2016-04-18 16:41:37 -07:00
platform make package docker/pkg/platform support darwin 2016-05-26 11:10:29 +08:00
plugins When calling volume driver Mount, send opaque ID 2016-04-29 09:37:02 -04:00
pools fix variables that werent being called 2016-03-17 13:19:55 -07:00
progress Send push information to trust code out-of-band 2016-01-08 10:57:50 -08:00
promise Move Go() promise-like func from utils to pkg/promise 2014-09-29 23:16:27 -07:00
proxy pkg/proxy: remove unused 'transfered' variable 2016-05-10 14:33:21 -07:00
pubsub Revert "use pubsub instead of filenotify to follow json logs" 2016-02-23 21:43:52 -05:00
random Fix typos found across repository 2015-12-13 18:04:12 +02:00
reexec Get the Docker Engine to build clean on Solaris 2016-05-23 16:37:12 -07:00
registrar fix typos in pkg 2016-04-09 21:18:15 +08:00
signal Get the Docker Engine to build clean on Solaris 2016-05-23 16:37:12 -07:00
stdcopy Optimizations for StdWriter 2016-03-25 22:14:27 -04:00
streamformatter Fix flaky test TestJSONFormatProgress (#21124) 2016-03-14 16:00:12 +00:00
stringid fix typos in pkg 2016-04-09 21:18:15 +08:00
stringutils fix typos in pkg 2016-04-09 21:18:15 +08:00
symlink fix variables that werent being called 2016-03-17 13:19:55 -07:00
sysinfo Get the Docker Engine to build clean on Solaris 2016-05-23 16:37:12 -07:00
system Get the Docker Engine to build clean on Solaris 2016-05-23 16:37:12 -07:00
tailfile typofix - https://github.com/vlajos/misspell_fixer 2015-08-07 23:25:49 +01:00
tarsum Fix build cache false positives when build context tar contains unnormalized paths 2016-04-14 17:57:45 -07:00
term Windows: run -it not crash in ISE 2016-05-25 09:50:18 -07:00
tlsconfig Fix golint warnings 2015-11-02 08:02:25 -08:00
truncindex pkg: truncindex: provide more info in error 2016-03-17 15:53:12 +01:00
urlutil Support unixgram syslog address 2016-04-28 11:04:50 +08:00
useragent Fix typos found across repository 2015-12-13 18:04:12 +02:00
README.md Add README to pkg 2013-12-23 23:12:19 +00:00

pkg/ is a collection of utility packages used by the Docker project without being specific to its internals.

Utility packages are kept separate from the docker core codebase to keep it as small and concise as possible. If some utilities grow larger and their APIs stabilize, they may be moved to their own repository under the Docker organization, to facilitate re-use by other projects. However that is not the priority.

The directory pkg is named after the same directory in the camlistore project. Since Brad is a core Go maintainer, we thought it made sense to copy his methods for organizing Go code :) Thanks Brad!

Because utility packages are small and neatly separated from the rest of the codebase, they are a good place to start for aspiring maintainers and contributors. Get in touch if you want to help maintain them!