moby/plugin
Brian Goff 426e610e43 Use runtime spec modifier for metrics plugin hook
Currently the metrics plugin uses a really hackish host mount with
propagated mounts to get the metrics socket into a plugin after the
plugin is alreay running.
This approach ends up leaking mounts which requires setting the plugin
manager root to private, which causes some other issues.

With this change, plugin subsystems can register a set of modifiers to
apply to the plugin's runtime spec before the plugin is ever started.
This will help to generalize some of the customization work that needs
to happen for various plugin subsystems (and future ones).

Specifically it lets the metrics plugin subsystem append a mount to the
runtime spec to mount the metrics socket in the plugin's mount namespace
rather than the host's and prevetns any leaking due to this mount.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
2018-02-07 15:48:26 -05:00
..
executor/containerd Move api/errdefs to errdefs 2018-01-11 21:21:43 -05:00
v2 Use runtime spec modifier for metrics plugin hook 2018-02-07 15:48:26 -05:00
backend_linux.go Merge pull request #34372 from cpuguy83/more_error_handling_for_pluginrm 2018-01-25 20:45:17 -08:00
backend_linux_test.go Ignore exist/not-exist errors on plugin remove 2018-01-25 09:23:54 -08:00
backend_unsupported.go Make plugin emit strongly typed, consumable events 2017-07-06 14:26:06 -04:00
blobstore.go LCOW: Re-coalesce stores 2018-01-18 08:29:19 -08:00
defs.go Use runtime spec modifier for metrics plugin hook 2018-02-07 15:48:26 -05:00
errors.go Add helpers to create errdef errors 2018-01-11 21:21:43 -05:00
events.go Make plugin emit strongly typed, consumable events 2017-07-06 14:26:06 -04:00
manager.go LCOW: Re-coalesce stores 2018-01-18 08:29:19 -08:00
manager_linux.go Move api/errdefs to errdefs 2018-01-11 21:21:43 -05:00
manager_linux_test.go Add test to check for plugin mounts on remove 2017-12-04 22:01:14 -05:00
manager_test.go fixed:go vetting warning unkeyed fields 2017-03-20 16:30:01 +08:00
manager_windows.go Remove Solaris files 2017-12-18 17:22:25 +01:00
store.go Use runtime spec modifier for metrics plugin hook 2018-02-07 15:48:26 -05:00
store_test.go Fixup some issues with plugin refcounting 2017-10-21 15:17:57 -04:00