beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
moby/daemon
History
junzhe and mnussbaum 20ca612a59 Fix empty LogPath with non-blocking logging mode 
This fixes an issue where the container LogPath was empty when the
non-blocking logging mode was enabled. This change sets the LogPath on
the container as soon as the path is generated, instead of setting the
LogPath on a logger struct and then attempting to pull it off that
logger at a later point. That attempt to pull the LogPath off the logger
was error prone since it assumed that the logger would only ever be a
single type.

Prior to this change docker inspect returned an empty string for
LogPath. This caused issues with tools that rely on docker inspect
output to discover container logs, e.g. Kubernetes.

This commit also removes some LogPath methods that are now unnecessary
and are never invoked.

Signed-off-by: junzhe and mnussbaum <code@getbraintree.com>
2018-02-20 23:12:34 -08:00
..
caps Add canonical import comment 2018-02-05 16:51:57 -05:00
cluster Fix typos in daemon 2018-02-10 19:42:54 +08:00
config Add canonical import comment 2018-02-05 16:51:57 -05:00
discovery Add canonical import comment 2018-02-05 16:51:57 -05:00
events Add canonical import comment 2018-02-05 16:51:57 -05:00
exec Add canonical import comment 2018-02-05 16:51:57 -05:00
graphdriver Fix typos in daemon 2018-02-10 19:42:54 +08:00
initlayer Add canonical import comment 2018-02-05 16:51:57 -05:00
links Add canonical import comment 2018-02-05 16:51:57 -05:00
listeners Add canonical import comment 2018-02-05 16:51:57 -05:00
logger Fix empty LogPath with non-blocking logging mode 2018-02-20 23:12:34 -08:00
names Add canonical import comment 2018-02-05 16:51:57 -05:00
network Add canonical import comment 2018-02-05 16:51:57 -05:00
stats Add canonical import comment 2018-02-05 16:51:57 -05:00
testdata Remove libtrust dep from api 2017-09-06 12:05:19 -04:00
apparmor_default.go Add canonical import comment 2018-02-05 16:51:57 -05:00
apparmor_default_unsupported.go Add canonical import comment 2018-02-05 16:51:57 -05:00
archive.go Add canonical import comment 2018-02-05 16:51:57 -05:00
archive_tarcopyoptions.go Add canonical import comment 2018-02-05 16:51:57 -05:00
archive_tarcopyoptions_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
archive_tarcopyoptions_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
archive_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
archive_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
attach.go Add canonical import comment 2018-02-05 16:51:57 -05:00
auth.go Add canonical import comment 2018-02-05 16:51:57 -05:00
bindmount_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
build.go Add canonical import comment 2018-02-05 16:51:57 -05:00
cache.go Add canonical import comment 2018-02-05 16:51:57 -05:00
changes.go c.RWLayer: check for nil before use 2018-02-09 11:24:09 -08:00
checkpoint.go Add canonical import comment 2018-02-05 16:51:57 -05:00
cluster.go Add canonical import comment 2018-02-05 16:51:57 -05:00
commit.go Merge pull request #36224 from dnephin/refactor-commit 2018-02-08 21:02:30 +09:00
configs.go Add canonical import comment 2018-02-05 16:51:57 -05:00
configs_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
configs_unsupported.go Add canonical import comment 2018-02-05 16:51:57 -05:00
configs_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
container.go Add canonical import comment 2018-02-05 16:51:57 -05:00
container_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
container_operations.go Add canonical import comment 2018-02-05 16:51:57 -05:00
container_operations_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
container_operations_windows.go Merge pull request #36194 from dnephin/add-canonical-import 2018-02-07 13:06:45 -08:00
container_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
create.go Add canonical import comment 2018-02-05 16:51:57 -05:00
create_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
create_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
create_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
daemon.go c.RWLayer: check for nil before use 2018-02-09 11:24:09 -08:00
daemon_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
daemon_linux_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
daemon_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
daemon_unix.go Merge pull request #36194 from dnephin/add-canonical-import 2018-02-07 13:06:45 -08:00
daemon_unix_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
daemon_unsupported.go Add canonical import comment 2018-02-05 16:51:57 -05:00
daemon_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
daemon_windows_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
debugtrap_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
debugtrap_unsupported.go Add canonical import comment 2018-02-05 16:51:57 -05:00
debugtrap_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
delete.go Add canonical import comment 2018-02-05 16:51:57 -05:00
delete_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
dependency.go Add canonical import comment 2018-02-05 16:51:57 -05:00
disk_usage.go Add canonical import comment 2018-02-05 16:51:57 -05:00
errors.go Add canonical import comment 2018-02-05 16:51:57 -05:00
events.go Add canonical import comment 2018-02-05 16:51:57 -05:00
events_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
exec.go Add canonical import comment 2018-02-05 16:51:57 -05:00
exec_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
exec_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
export.go Add canonical import comment 2018-02-05 16:51:57 -05:00
getsize_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
health.go Add canonical import comment 2018-02-05 16:51:57 -05:00
health_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
image.go Add canonical import comment 2018-02-05 16:51:57 -05:00
image_delete.go Add canonical import comment 2018-02-05 16:51:57 -05:00
image_exporter.go Add canonical import comment 2018-02-05 16:51:57 -05:00
image_history.go Add canonical import comment 2018-02-05 16:51:57 -05:00
image_inspect.go Add canonical import comment 2018-02-05 16:51:57 -05:00
image_pull.go Add canonical import comment 2018-02-05 16:51:57 -05:00
image_push.go Add canonical import comment 2018-02-05 16:51:57 -05:00
image_tag.go Add canonical import comment 2018-02-05 16:51:57 -05:00
images.go Add canonical import comment 2018-02-05 16:51:57 -05:00
import.go Add canonical import comment 2018-02-05 16:51:57 -05:00
info.go Add canonical import comment 2018-02-05 16:51:57 -05:00
info_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
info_unix_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
info_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
inspect.go c.RWLayer: check for nil before use 2018-02-09 11:24:09 -08:00
inspect_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
inspect_test.go c.RWLayer: check for nil before use 2018-02-09 11:24:09 -08:00
inspect_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
keys.go Add canonical import comment 2018-02-05 16:51:57 -05:00
keys_unsupported.go Add canonical import comment 2018-02-05 16:51:57 -05:00
kill.go Add canonical import comment 2018-02-05 16:51:57 -05:00
links.go Add canonical import comment 2018-02-05 16:51:57 -05:00
list.go Add canonical import comment 2018-02-05 16:51:57 -05:00
list_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
list_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
logdrivers_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
logdrivers_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
logs.go Add canonical import comment 2018-02-05 16:51:57 -05:00
logs_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
metrics.go Add canonical import comment 2018-02-05 16:51:57 -05:00
metrics_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
metrics_unsupported.go Add canonical import comment 2018-02-05 16:51:57 -05:00
monitor.go Add canonical import comment 2018-02-05 16:51:57 -05:00
monitor_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
monitor_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
mounts.go Add canonical import comment 2018-02-05 16:51:57 -05:00
names.go Add canonical import comment 2018-02-05 16:51:57 -05:00
network.go Add canonical import comment 2018-02-05 16:51:57 -05:00
oci_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
oci_linux_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
oci_windows.go c.RWLayer: check for nil before use 2018-02-09 11:24:09 -08:00
pause.go Add canonical import comment 2018-02-05 16:51:57 -05:00
prune.go Add canonical import comment 2018-02-05 16:51:57 -05:00
reload.go Add canonical import comment 2018-02-05 16:51:57 -05:00
reload_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
reload_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
reload_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
rename.go Add canonical import comment 2018-02-05 16:51:57 -05:00
resize.go Add canonical import comment 2018-02-05 16:51:57 -05:00
restart.go Add canonical import comment 2018-02-05 16:51:57 -05:00
search.go Add canonical import comment 2018-02-05 16:51:57 -05:00
search_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
seccomp_disabled.go Add canonical import comment 2018-02-05 16:51:57 -05:00
seccomp_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
seccomp_unsupported.go Add canonical import comment 2018-02-05 16:51:57 -05:00
secrets.go Add canonical import comment 2018-02-05 16:51:57 -05:00
secrets_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
secrets_unsupported.go Add canonical import comment 2018-02-05 16:51:57 -05:00
secrets_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
selinux_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
selinux_unsupported.go Add canonical import comment 2018-02-05 16:51:57 -05:00
start.go Add canonical import comment 2018-02-05 16:51:57 -05:00
start_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
start_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
stats.go Add canonical import comment 2018-02-05 16:51:57 -05:00
stats_collector.go Add canonical import comment 2018-02-05 16:51:57 -05:00
stats_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
stats_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
stop.go Add canonical import comment 2018-02-05 16:51:57 -05:00
top_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
top_unix_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
top_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
trustkey.go Add canonical import comment 2018-02-05 16:51:57 -05:00
trustkey_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
unpause.go Add canonical import comment 2018-02-05 16:51:57 -05:00
update.go Add canonical import comment 2018-02-05 16:51:57 -05:00
update_linux.go Add canonical import comment 2018-02-05 16:51:57 -05:00
update_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
volumes.go Add canonical import comment 2018-02-05 16:51:57 -05:00
volumes_unit_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
volumes_unix.go Add canonical import comment 2018-02-05 16:51:57 -05:00
volumes_unix_test.go Add canonical import comment 2018-02-05 16:51:57 -05:00
volumes_windows.go Add canonical import comment 2018-02-05 16:51:57 -05:00
wait.go Add canonical import comment 2018-02-05 16:51:57 -05:00
workdir.go Add canonical import comment 2018-02-05 16:51:57 -05:00