beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
moby/integration
History
Sebastiaan van Stijn 0bce64f08d
api: POST /containers/{id}/wait: fix validation for "condition" parameter 
commit 737e8c6ab8 added validation for the wait
condition parameter, however, the default ("not-running") option was not part
of the list of valid options, resulting in a regression if the default value
was explicitly passed;

    docker scan --accept-license --version
    Error response from daemon: invalid condition: "not-running"

This patch adds the missing option, and adds a test to verify.

With this patch;

    make BIND_DIR=. DOCKER_GRAPHDRIVER=vfs TEST_FILTER=TestWaitConditions test-integration
    ...
    --- PASS: TestWaitConditions (0.04s)
    --- PASS: TestWaitConditions/removed (1.79s)
    --- PASS: TestWaitConditions/default (1.91s)
    --- PASS: TestWaitConditions/next-exit (1.97s)
    --- PASS: TestWaitConditions/not-running (1.99s)
    PASS

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-06-27 14:45:32 +02:00
..
build Merge pull request #43009 from thaJeztah/skip_TestBuildWCOWSandboxSize 2021-11-10 11:59:09 -08:00
config Add configuration validation option and tests. 2021-06-23 09:54:55 +00:00
container api: POST /containers/{id}/wait: fix validation for "condition" parameter 2022-06-27 14:45:32 +02:00
daemon replace deprecated gotest.tools' env.Patch() with t.SetEnv() 2022-05-28 12:12:39 +02:00
distribution bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
image Finish refactor of UID/GID usage to a new struct 2022-03-14 16:28:57 -04:00
internal container/exec: Support ConsoleSize 2022-06-24 11:54:25 +02:00
network api/server/httputils: add ReadJSON() utility 2022-04-11 21:37:51 +02:00
plugin api: rename volume.VolumeCreateBody to volume.CreateOptions 2022-04-28 22:39:14 +02:00
secret integration/secret: add check for empty list not producing an error 2020-04-14 18:31:36 +02:00
service Fix race in TestCreateServiceSecretFileMode, TestCreateServiceConfigFileMode 2021-10-27 10:55:54 +02:00
session bump gotest.tools v3.0.1 for compatibility with Go 1.14 2020-02-11 00:06:42 +01:00
system integration: TestPingSwarmHeader(): fix incorrect ping, and cleanup 2022-05-29 15:17:37 +02:00
testdata/https Update test certificates 2021-05-18 09:43:21 +02:00
volume api: rename volume.VolumeCreateBody to volume.CreateOptions 2022-04-28 22:39:14 +02:00
doc.go Add canonical import comment 2018-02-05 16:51:57 -05:00