beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
moby/hack/validate
History
Sebastiaan van Stijn 0e9a66d35a
logger/journald: remove journald_compat (for systemd < 209) 
This was added in 6cdc4ba6cd in 2016, likely
because at the time we were still building for CentOS 6 and Ubuntu 14.04.

All currently supported distros appear to be on _at least_ 219 now, so it looks
safe to remove this;

```bash
docker run -it --rm centos:7

yum install -y systemd-devel

pkg-config 'libsystemd >= 209' && echo "OK" || echo "KO"
OK

pkg-config --print-provides 'libsystemd'
libsystemd = 219

pkg-config --print-provides 'libsystemd-journal'
libsystemd-journal = 219
```

And on a `debian:buster` (old stable)

```bash
docker run -it --rm debian:buster

apt-get update && apt-get install -y libsystemd-dev pkg-config

pkg-config 'libsystemd >= 209' && echo "OK" || echo "KO"
OK

pkg-config --print-provides 'libsystemd'
libsystemd = 241

pkg-config --print-provides 'libsystemd-journal'
Package libsystemd-journal was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsystemd-journal.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libsystemd-journal' found
```

OpenSUSE leap (I think that's built for s390x)

```bash
docker run -it --rm docker.io/opensuse/leap:15

zypper install -y systemd-devel

pkg-config 'libsystemd >= 209' && echo "OK" || echo "KO"
OK

pkg-config --print-provides 'libsystemd'
libsystemd = 246

pkg-config --print-provides 'libsystemd-journal'
Package libsystemd-journal was not found in the pkg-config search path.
Perhaps you should add the directory containing `libsystemd-journal.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libsystemd-journal' found
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2022-07-20 18:48:00 +02:00
..
.swagger-yamllint Add swagger.yaml validation 2016-11-07 11:03:21 -08:00
.validate hack: no need to git fetch in CI 2019-02-05 02:54:50 +00:00
all run shfmt 2020-03-03 12:27:49 +09:00
changelog-date-descending hack: fix mixed tabs/spaces for indentation 2019-08-02 15:58:33 +02:00
changelog-well-formed hack: fix mixed tabs/spaces for indentation 2019-08-02 15:58:33 +02:00
dco run shfmt 2020-03-03 12:27:49 +09:00
default validation: temporarily allows changes in integration-cli 2022-06-17 10:58:55 +02:00
default-seccomp run shfmt 2020-03-03 12:27:49 +09:00
deprecate-integration-cli run shfmt 2020-03-03 12:27:49 +09:00
golangci-lint logger/journald: remove journald_compat (for systemd < 209) 2022-07-20 18:48:00 +02:00
golangci-lint.yml replace golint with revive, as it's deprecated 2022-07-04 10:15:54 +02:00
pkg-imports pkg/urlutil: deprecate, and move to builder/remotecontext/urlutil 2022-04-12 19:58:05 +02:00
shfmt Fixup libnetwork lint errors 2021-06-01 23:48:32 +00:00
swagger run shfmt 2020-03-03 12:27:49 +09:00
swagger-gen run shfmt 2020-03-03 12:27:49 +09:00
toml validate/toml: switch to github.com/pelletier/go-toml 2021-04-02 16:08:17 +02:00
vendor hack/vendor.sh: run "go mod tidy" before vendoring 2022-02-05 11:25:23 +01:00