b08f071e18
Although having a request ID available throughout the codebase is very valuable, the impact of requiring a Context as an argument to every function in the codepath of an API request, is too significant and was not properly understood at the time of the review. Furthermore, mixing API-layer code with non-API-layer code makes the latter usable only by API-layer code (one that has a notion of Context). This reverts commitde41640435, reversing changes made to7daeecd42d. Signed-off-by: Tibor Vass <tibor@docker.com> Conflicts: api/server/container.go builder/internals.go daemon/container_unix.go daemon/create.go
48 lines
1 KiB
Go
48 lines
1 KiB
Go
package daemon
|
|
|
|
import (
|
|
derr "github.com/docker/docker/errors"
|
|
)
|
|
|
|
// ContainerRename changes the name of a container, using the oldName
|
|
// to find the container. An error is returned if newName is already
|
|
// reserved.
|
|
func (daemon *Daemon) ContainerRename(oldName, newName string) error {
|
|
if oldName == "" || newName == "" {
|
|
return derr.ErrorCodeEmptyRename
|
|
}
|
|
|
|
container, err := daemon.Get(oldName)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
oldName = container.Name
|
|
|
|
container.Lock()
|
|
defer container.Unlock()
|
|
if newName, err = daemon.reserveName(container.ID, newName); err != nil {
|
|
return derr.ErrorCodeRenameTaken.WithArgs(err)
|
|
}
|
|
|
|
container.Name = newName
|
|
|
|
undo := func() {
|
|
container.Name = oldName
|
|
daemon.reserveName(container.ID, oldName)
|
|
daemon.containerGraphDB.Delete(newName)
|
|
}
|
|
|
|
if err := daemon.containerGraphDB.Delete(oldName); err != nil {
|
|
undo()
|
|
return derr.ErrorCodeRenameDelete.WithArgs(oldName, err)
|
|
}
|
|
|
|
if err := container.toDisk(); err != nil {
|
|
undo()
|
|
return err
|
|
}
|
|
|
|
container.logEvent("rename")
|
|
return nil
|
|
}
|