//go:build !windows package main import ( "context" "encoding/json" "fmt" "os/exec" "strings" "testing" "time" "github.com/creack/pty" "github.com/docker/docker/api/types" "github.com/docker/docker/client" "github.com/docker/docker/integration-cli/cli" "github.com/docker/docker/testutil" "github.com/docker/docker/testutil/request" "gotest.tools/v3/assert" ) func (s *DockerCLIUpdateSuite) TearDownTest(ctx context.Context, c *testing.T) { s.ds.TearDownTest(ctx, c) } func (s *DockerCLIUpdateSuite) OnTimeout(c *testing.T) { s.ds.OnTimeout(c) } func (s *DockerCLIUpdateSuite) TestUpdateRunningContainer(c *testing.T) { testRequires(c, DaemonIsLinux) testRequires(c, memoryLimitSupport) const name = "test-update-container" cli.DockerCmd(c, "run", "-d", "--name", name, "-m", "300M", "busybox", "top") cli.DockerCmd(c, "update", "-m", "500M", name) assert.Equal(c, inspectField(c, name, "HostConfig.Memory"), "524288000") const file = "/sys/fs/cgroup/memory/memory.limit_in_bytes" out := cli.DockerCmd(c, "exec", name, "cat", file).Stdout() assert.Equal(c, strings.TrimSpace(out), "524288000") } func (s *DockerCLIUpdateSuite) TestUpdateRunningContainerWithRestart(c *testing.T) { testRequires(c, DaemonIsLinux) testRequires(c, memoryLimitSupport) const name = "test-update-container" cli.DockerCmd(c, "run", "-d", "--name", name, "-m", "300M", "busybox", "top") cli.DockerCmd(c, "update", "-m", "500M", name) cli.DockerCmd(c, "restart", name) assert.Equal(c, inspectField(c, name, "HostConfig.Memory"), "524288000") const file = "/sys/fs/cgroup/memory/memory.limit_in_bytes" out := cli.DockerCmd(c, "exec", name, "cat", file).Stdout() assert.Equal(c, strings.TrimSpace(out), "524288000") } func (s *DockerCLIUpdateSuite) TestUpdateStoppedContainer(c *testing.T) { testRequires(c, DaemonIsLinux) testRequires(c, memoryLimitSupport) const name = "test-update-container" const file = "/sys/fs/cgroup/memory/memory.limit_in_bytes" cli.DockerCmd(c, "run", "--name", name, "-m", "300M", "busybox", "cat", file) cli.DockerCmd(c, "update", "-m", "500M", name) assert.Equal(c, inspectField(c, name, "HostConfig.Memory"), "524288000") out := cli.DockerCmd(c, "start", "-a", name).Stdout() assert.Equal(c, strings.TrimSpace(out), "524288000") } func (s *DockerCLIUpdateSuite) TestUpdatePausedContainer(c *testing.T) { testRequires(c, DaemonIsLinux) testRequires(c, cpuShare) const name = "test-update-container" cli.DockerCmd(c, "run", "-d", "--name", name, "--cpu-shares", "1000", "busybox", "top") cli.DockerCmd(c, "pause", name) cli.DockerCmd(c, "update", "--cpu-shares", "500", name) assert.Equal(c, inspectField(c, name, "HostConfig.CPUShares"), "500") cli.DockerCmd(c, "unpause", name) const file = "/sys/fs/cgroup/cpu/cpu.shares" out := cli.DockerCmd(c, "exec", name, "cat", file).Stdout() assert.Equal(c, strings.TrimSpace(out), "500") } func (s *DockerCLIUpdateSuite) TestUpdateWithUntouchedFields(c *testing.T) { testRequires(c, DaemonIsLinux) testRequires(c, memoryLimitSupport) testRequires(c, cpuShare) const name = "test-update-container" cli.DockerCmd(c, "run", "-d", "--name", name, "-m", "300M", "--cpu-shares", "800", "busybox", "top") cli.DockerCmd(c, "update", "-m", "500M", name) // Update memory and not touch cpus, `cpuset.cpus` should still have the old value out := inspectField(c, name, "HostConfig.CPUShares") assert.Equal(c, out, "800") const file = "/sys/fs/cgroup/cpu/cpu.shares" out = cli.DockerCmd(c, "exec", name, "cat", file).Stdout() assert.Equal(c, strings.TrimSpace(out), "800") } func (s *DockerCLIUpdateSuite) TestUpdateContainerInvalidValue(c *testing.T) { testRequires(c, DaemonIsLinux) testRequires(c, memoryLimitSupport) const name = "test-update-container" cli.DockerCmd(c, "run", "-d", "--name", name, "-m", "300M", "busybox", "true") out, _, err := dockerCmdWithError("update", "-m", "2M", name) assert.ErrorContains(c, err, "") expected := "Minimum memory limit allowed is 6MB" assert.Assert(c, strings.Contains(out, expected)) } func (s *DockerCLIUpdateSuite) TestUpdateContainerWithoutFlags(c *testing.T) { testRequires(c, DaemonIsLinux) testRequires(c, memoryLimitSupport) const name = "test-update-container" cli.DockerCmd(c, "run", "-d", "--name", name, "-m", "300M", "busybox", "true") _, _, err := dockerCmdWithError("update", name) assert.ErrorContains(c, err, "") } func (s *DockerCLIUpdateSuite) TestUpdateSwapMemoryOnly(c *testing.T) { testRequires(c, DaemonIsLinux) testRequires(c, memoryLimitSupport) testRequires(c, swapMemorySupport) const name = "test-update-container" cli.DockerCmd(c, "run", "-d", "--name", name, "--memory", "300M", "--memory-swap", "500M", "busybox", "top") cli.DockerCmd(c, "update", "--memory-swap", "600M", name) assert.Equal(c, inspectField(c, name, "HostConfig.MemorySwap"), "629145600") const file = "/sys/fs/cgroup/memory/memory.memsw.limit_in_bytes" out := cli.DockerCmd(c, "exec", name, "cat", file).Stdout() assert.Equal(c, strings.TrimSpace(out), "629145600") } func (s *DockerCLIUpdateSuite) TestUpdateInvalidSwapMemory(c *testing.T) { testRequires(c, DaemonIsLinux) testRequires(c, memoryLimitSupport) testRequires(c, swapMemorySupport) const name = "test-update-container" cli.DockerCmd(c, "run", "-d", "--name", name, "--memory", "300M", "--memory-swap", "500M", "busybox", "top") _, _, err := dockerCmdWithError("update", "--memory-swap", "200M", name) // Update invalid swap memory should fail. // This will pass docker config validation, but failed at kernel validation assert.ErrorContains(c, err, "") // Update invalid swap memory with failure should not change HostConfig assert.Equal(c, inspectField(c, name, "HostConfig.Memory"), "314572800") assert.Equal(c, inspectField(c, name, "HostConfig.MemorySwap"), "524288000") cli.DockerCmd(c, "update", "--memory-swap", "600M", name) assert.Equal(c, inspectField(c, name, "HostConfig.MemorySwap"), "629145600") const file = "/sys/fs/cgroup/memory/memory.memsw.limit_in_bytes" out := cli.DockerCmd(c, "exec", name, "cat", file).Stdout() assert.Equal(c, strings.TrimSpace(out), "629145600") } func (s *DockerCLIUpdateSuite) TestUpdateStats(c *testing.T) { testRequires(c, DaemonIsLinux) testRequires(c, memoryLimitSupport) testRequires(c, cpuCfsQuota) const name = "foo" cli.DockerCmd(c, "run", "-d", "-ti", "--name", name, "-m", "500m", "busybox") cli.WaitRun(c, name) getMemLimit := func(id string) uint64 { resp, body, err := request.Get(testutil.GetContext(c), fmt.Sprintf("/containers/%s/stats?stream=false", id)) assert.NilError(c, err) assert.Equal(c, resp.Header.Get("Content-Type"), "application/json") var v *types.Stats err = json.NewDecoder(body).Decode(&v) assert.NilError(c, err) body.Close() return v.MemoryStats.Limit } preMemLimit := getMemLimit(name) cli.DockerCmd(c, "update", "--cpu-quota", "2000", name) curMemLimit := getMemLimit(name) assert.Equal(c, preMemLimit, curMemLimit) } func (s *DockerCLIUpdateSuite) TestUpdateMemoryWithSwapMemory(c *testing.T) { testRequires(c, DaemonIsLinux) testRequires(c, memoryLimitSupport) testRequires(c, swapMemorySupport) const name = "test-update-container" cli.DockerCmd(c, "run", "-d", "--name", name, "--memory", "300M", "busybox", "top") out, _, err := dockerCmdWithError("update", "--memory", "800M", name) assert.ErrorContains(c, err, "") assert.Assert(c, strings.Contains(out, "Memory limit should be smaller than already set memoryswap limit")) cli.DockerCmd(c, "update", "--memory", "800M", "--memory-swap", "1000M", name) } func (s *DockerCLIUpdateSuite) TestUpdateNotAffectMonitorRestartPolicy(c *testing.T) { testRequires(c, DaemonIsLinux, cpuShare) id := cli.DockerCmd(c, "run", "-tid", "--restart=always", "busybox", "sh").Stdout() id = strings.TrimSpace(id) cli.DockerCmd(c, "update", "--cpu-shares", "512", id) cpty, tty, err := pty.Open() assert.NilError(c, err) defer cpty.Close() cmd := exec.Command(dockerBinary, "attach", id) cmd.Stdin = tty assert.NilError(c, cmd.Start()) defer cmd.Process.Kill() _, err = cpty.Write([]byte("exit\n")) assert.NilError(c, err) assert.NilError(c, cmd.Wait()) // container should restart again and keep running err = waitInspect(id, "{{.RestartCount}}", "1", 30*time.Second) assert.NilError(c, err) cli.WaitRun(c, id) } func (s *DockerCLIUpdateSuite) TestUpdateWithNanoCPUs(c *testing.T) { testRequires(c, cpuCfsQuota, cpuCfsPeriod) const file1 = "/sys/fs/cgroup/cpu/cpu.cfs_quota_us" const file2 = "/sys/fs/cgroup/cpu/cpu.cfs_period_us" out := cli.DockerCmd(c, "run", "-d", "--cpus", "0.5", "--name", "top", "busybox", "top").Stdout() assert.Assert(c, strings.TrimSpace(out) != "") out = cli.DockerCmd(c, "exec", "top", "sh", "-c", fmt.Sprintf("cat %s && cat %s", file1, file2)).Combined() assert.Equal(c, strings.TrimSpace(out), "50000\n100000") clt, err := client.NewClientWithOpts(client.FromEnv) assert.NilError(c, err) inspect, err := clt.ContainerInspect(testutil.GetContext(c), "top") assert.NilError(c, err) assert.Equal(c, inspect.HostConfig.NanoCPUs, int64(500000000)) out = inspectField(c, "top", "HostConfig.CpuQuota") assert.Equal(c, out, "0", "CPU CFS quota should be 0") out = inspectField(c, "top", "HostConfig.CpuPeriod") assert.Equal(c, out, "0", "CPU CFS period should be 0") out, _, err = dockerCmdWithError("update", "--cpu-quota", "80000", "top") assert.ErrorContains(c, err, "") assert.Assert(c, strings.Contains(out, "Conflicting options: CPU Quota cannot be updated as NanoCPUs has already been set")) cli.DockerCmd(c, "update", "--cpus", "0.8", "top") inspect, err = clt.ContainerInspect(testutil.GetContext(c), "top") assert.NilError(c, err) assert.Equal(c, inspect.HostConfig.NanoCPUs, int64(800000000)) out = inspectField(c, "top", "HostConfig.CpuQuota") assert.Equal(c, out, "0", "CPU CFS quota should be 0") out = inspectField(c, "top", "HostConfig.CpuPeriod") assert.Equal(c, out, "0", "CPU CFS period should be 0") out = cli.DockerCmd(c, "exec", "top", "sh", "-c", fmt.Sprintf("cat %s && cat %s", file1, file2)).Combined() assert.Equal(c, strings.TrimSpace(out), "80000\n100000") }