Commit graph

31655 commits

Author SHA1 Message Date
John Maguire
020ec88542 Add note regarding Windows VOLUME limitations
Signed-off-by: John Maguire <jmaguire@duosecurity.com>
2017-03-22 14:57:42 -04:00
Vincent Demeester
0f9ec7e470 Merge pull request #31992 from tonistiigi/fix-builder-exit-code
Return proper exit code on builder panic
2017-03-22 19:04:09 +01:00
Anusha Ragunathan
342ed107bc Embed DockerVersion in plugin config.
Embedding DockerVersion in plugin config when the plugin is created,
enables users to do a docker plugin inspect and know which version
the plugin was built on. This is helpful in cases where users are
running a new plugin on older docker releases and confused at
unexpected behavior.

By embedding DockerVersion in the config, we claim that there's no
guarantee that if the plugin config's DockerVersion is greater that
the version of the docker engine the plugin is executed against, the
plugin will work as expected.

For example, lets say:
- in 17.03, a plugin was released as johndoe/foo:v1
- in 17.05, the plugin uses the new ipchost config setting and author
publishes johndoe/foo:v2

In this case, johndoe/foo:v2 was built on 17.05 using ipchost, but is
running on docker-engine version 17.03. Since 17.05 > 17.03, there's
no guarantee that the plugin will work as expected. Ofcourse, if the
plugin did not use newly added config settings (ipchost in this case)
in 17.05, it would work fine in 17.03.

Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com>
2017-03-22 10:26:20 -07:00
Vincent Demeester
d3dc27d145
Remove compose types.Dict alias
It is just an alias type and make the code a little bit more complex
and hard to use from outside `compose` package.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2017-03-22 16:16:20 +01:00
Brian Goff
d8406fd7a0 Merge pull request #31996 from aboch/drst
Fix stop/start/restart of detached container
2017-03-22 10:24:45 -04:00
Vincent Demeester
f453412bd8 Merge pull request #31973 from wsong/update_df_docs
Update system df docs to call out performance implications
2017-03-22 13:46:48 +01:00
Vincent Demeester
57a82c4190 Merge pull request #31988 from thaJeztah/fix-deprecation-version
update "docker daemon" deprecation message for new version scheme
2017-03-22 11:26:54 +01:00
Alessandro Boch
4ca7d4f0c1 Fix start/restart of detached container
Signed-off-by: Alessandro Boch <aboch@docker.com>
2017-03-22 02:38:26 -07:00
Vincent Demeester
c497499cde Merge pull request #31584 from dave-tucker/ignore-default-build-args
Exclude “default” build-args from image history
2017-03-22 10:07:22 +01:00
Vincent Demeester
94394026a8 Merge pull request #31749 from yallop/docs-31047
Add documentation for bind mount consistency flags (#31047).
2017-03-22 10:06:50 +01:00
Vincent Demeester
2b478686be Merge pull request #31991 from tonistiigi/add-build-arg-testcase
Add testcase for build arg without value
2017-03-22 09:55:45 +01:00
Wayne Song
d8a49c322a Update system df docs to call out performance implications
Signed-off-by: Wayne Song <wsong@docker.com>
2017-03-22 09:49:03 +01:00
Ryan Liu
786f30107b Fix nw sandbox leak when stopping detached container
Signed-off-by: Ryan Liu <ryanlyy@me.com>
2017-03-21 23:51:52 -07:00
Tonis Tiigi
385f1174ff Return proper exit code on builder panic
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-03-21 19:09:23 -07:00
Tonis Tiigi
8f37715af2 Add testcase for build arg without value
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-03-21 18:59:42 -07:00
Sebastiaan van Stijn
ba76a0c912
update "docker daemon" deprecation message for new version scheme
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2017-03-22 00:21:15 +01:00
John Howard (VM)
91e971c0fe Windows: Don't close client stdin handle to avoid hang
Signed-off-by: John Howard (VM) <jhoward@microsoft.com>
2017-03-21 16:00:17 -07:00
Anusha Ragunathan
4d1edcb2cc Add pid host support
Tested using global-net-plugin-ipc which sets PidHost in config.json.

Plugins might need access to host pid namespace. Add support for that.
Tested using aragunathan/global-net-plugin-ipc which sets "pidhost" in
config.json. Observed using `readlink /proc/self/ns/pid` that plugin and
host have the same ns.

Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com>
2017-03-21 13:39:01 -07:00
Anusha Ragunathan
6d6185c257 Add support in plugin config for accessing host ipc namespace.
Plugins might need access to host ipc namespace. A good usecase is
a volume plugin running iscsi multipath commands that need access to
host kernel locks.
Tested with a custom plugin (aragunathan/global-net-plugin-full) that's
built with `"ipchost" : true` in config.json. Observed using
`readlink /proc/self/ns/ipc` that plugin and host have the same ns.

Signed-off-by: Anusha Ragunathan <anusha.ragunathan@docker.com>
2017-03-21 13:39:01 -07:00
Sebastiaan van Stijn
fd3aef5ec2 Merge pull request #31966 from runcom/seccomp-clock-settime
profiles: seccomp: allow clock_settime when CAP_SYS_TIME is added
2017-03-21 20:22:22 +01:00
Victor Vieux
afe1c5c2eb Merge pull request #31705 from cyli/bump-go-connections
Use either a system pool or custom CA pool when connecting from client->daemon (+go-connections version bump)
2017-03-21 10:36:41 -07:00
Dave Tucker
89a2a885c8 Ignore built-in allowed build-args in image history
Removes the build-args from the image history if they are in the
BuiltinAllowedBuildArgs map unless they are explicitly defined in an ARG
instruction.

Signed-off-by: Dave Tucker <dt@docker.com>
2017-03-21 16:36:48 +00:00
Sebastiaan van Stijn
4c7941d391 Merge pull request #31969 from vdemeester/fix-images-reference-docs-filter-list
Add `reference` filter to the list of available filters
2017-03-21 16:14:07 +01:00
Vincent Demeester
8e7e6bdb73
Add reference filter to the list of available filters
The `reference` filter is documented in the file, but is not present
in the list of available filters.

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2017-03-21 16:11:11 +01:00
Vincent Demeester
b82f9622dc Merge pull request #31962 from dgageot/fix-31922
Windows: Fix Docker hanging with named pipes and stdin
2017-03-21 16:02:29 +01:00
Vincent Demeester
f965aab5e9 Merge pull request #31621 from dnephin/cleanup-container-run-command
Some cleanup of container run command
2017-03-21 16:01:11 +01:00
Jeremy Yallop
1a710c1660 Documentation for bind mount consistency flags.
Signed-off-by: Jeremy Yallop <yallop@docker.com>
2017-03-21 11:55:33 +00:00
David Gageot
97b572ea1b Windows: Fix Docker hanging with named pipes and stdin
Fixes #31922

Vendor a fork of Microsoft/go-winio that has this
PR (https://github.com/Microsoft/go-winio/pull/43)
merged


Signed-off-by: David Gageot <david@gageot.net>
2017-03-21 11:49:57 +01:00
Vincent Demeester
58ccdfe00c Merge pull request #31928 from Microsoft/jjh/cleanupremoving
Windows: graph cleanup '-removing'
2017-03-21 09:43:38 +01:00
Akihiro Suda
9a5bf4b5ad Merge pull request #29779 from thaJeztah/do-not-return-incorrect-error
NetworksPrune: do not return warnings as error
2017-03-21 16:28:54 +09:00
Sebastiaan van Stijn
0bc84fc06c Merge pull request #31596 from rootsongjc/dry-run-test
Wrong entrypoint in docker plugin example
2017-03-20 23:38:15 +01:00
Sebastiaan van Stijn
1ec77baed9 Merge pull request #31552 from ripcurld0/add_format_secretls
Add format to secret ls
2017-03-20 20:20:45 +01:00
Tonis Tiigi
acad599210 Fix cache for dockerfiles with multiple FROM
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-03-20 11:24:50 -07:00
Tonis Tiigi
09f308ce21 Fix ARG scoping for Dockerfiles with multiple FROM
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
2017-03-20 11:24:44 -07:00
Vincent Demeester
550b06ab6a Merge pull request #31948 from vdemeester/compose-typo
Fixing a small typo in compose loader package
2017-03-20 17:48:50 +01:00
Daniel Nephin
4152243985 Create a new ServerType struct for storing details about the server on the client.
Signed-off-by: Daniel Nephin <dnephin@docker.com>
2017-03-20 12:48:25 -04:00
Vincent Demeester
2422d5ad35 Merge pull request #31669 from tonistiigi/files-filter
Fix inefficient file paths filter
2017-03-20 17:43:47 +01:00
John Howard (VM)
9910b9a7f0 Windows: graph cleanup '-removing'
Signed-off-by: John Howard (VM) <jhoward@ntdev.microsoft.com>
2017-03-20 09:15:27 -07:00
Vincent Demeester
1bb4eae43f Merge pull request #31943 from liker12134/fix-go-vetting-warning-unkeyed-fields
Fixed:go vetting warning unkeyed fields
2017-03-20 15:51:32 +01:00
Vincent Demeester
93eaec90aa Merge pull request #31946 from fate-grand-order/fixed
fix misspell in utils.go
2017-03-20 15:41:54 +01:00
Vincent Demeester
b8c45c3a57
Fixing a small typo in compose loader package
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
2017-03-20 15:39:57 +01:00
Sebastiaan van Stijn
1ed277a268 Merge pull request #31915 from albers/fix-completion-node-update
Bash completion for `docker node update` completes only one node
2017-03-20 14:10:25 +01:00
fate-grand-order
2b79dbc89b fix misspell in utils.go
Signed-off-by: Helen Xie <chenjg@harmonycloud.cn>
2017-03-20 19:52:00 +08:00
Sebastiaan van Stijn
a8b20f4789 Merge pull request #31941 from felicianotech/fix/cli-build-heading
Fix 'Specify a Dockerfile (-f)' heading in Engine CLI Docs.
2017-03-20 12:51:47 +01:00
Vincent Demeester
5aa44cdf13 Merge pull request #31933 from cooltoast/master
Add Johannes Kepler and Mary Jackson to name generator
2017-03-20 11:27:17 +01:00
Vincent Demeester
3794e190ff Merge pull request #31882 from unclejack/fix_Dockerfile
Dockerfile: move comments to fix build error
2017-03-20 11:08:45 +01:00
Antonio Murdaca
3ab4961032
profiles: seccomp: allow clock_settime when CAP_SYS_TIME is added
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
2017-03-20 11:05:23 +01:00
liker12134
2333b39b37 fixed:go vetting warning unkeyed fields
Signed-off-by: Aaron.L.Xu <liker.xu@foxmail.com>
2017-03-20 16:30:01 +08:00
Ricardo N Feliciano
0bd77d2381
Fix 'Specify a Dockerfile (-f)' heading in Engine CLI Docs.
Signed-off-by: Ricardo N Feliciano <FelicianoTech@gmail.com>
2017-03-19 18:05:12 -04:00
Boaz Shuster
e281fe9c3a Add format to secret ls
Signed-off-by: Boaz Shuster <ripcurld.github@gmail.com>
2017-03-19 09:22:30 +02:00