beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
47432 commits 14 branches 412 tags 338 MiB
Commit graph

47432 commits

This branch
This branch
All branches
Author SHA1 Message Date
Sebastiaan van Stijn
9ea50365d6
daemon/events: use events-consts in tests, and fix vars that collided 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-27 22:23:29 +02:00
Sebastiaan van Stijn
2f8e957713
Dockerfile: update crun binary to v1.8.7 
Updating the version of crun that we use in our tests to a version that
supports the "features" command (crun v1.8.6 and up). This should prevent
some warnings in our logs:

    WARN[2023-08-26T17:05:35.042978552Z] Failed to run [/usr/local/bin/crun features]: "unknown command features\n"  error="exit status 1"

full diff: https://github.com/containers/crun/compare/1.4.5...1.8.7

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-27 21:43:00 +02:00
Sebastiaan van Stijn
8b21609654
libnetwork: remove Endpoint.Interface 
This method is not part of any interface, and identical to Endpoint.Iface,
but one returns an Interface-type (driverapi.InterfaceInfo) and the other
returns a concrete type (EndpointInterface).

Interface-matching should generally happen on the receiver side, and this
function was only used in a single location, and passed as argument to
Driver.CreateEndpoint, which already matches the interface by accepting
a driverapi.InterfaceInfo.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-27 20:24:32 +02:00
Sebastiaan van Stijn
f8181b8875
libnetwork: Endpoint.Iface, Endpoint.Interface remove redundant "if" 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-27 20:24:32 +02:00
Sebastiaan van Stijn
6a61bacafe
libnetwork/drivers/remote: rollbackEndpoint.Interface: return concrete type 
Interface-matching should generally happen on the receiver side, and this
function was only used in a single location, and passed as argument to
Driver.CreateEndpoint, which already matches the interface by accepting
a driverapi.InterfaceInfo.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-27 20:18:31 +02:00
Sebastiaan van Stijn
dc061d2ed3
libnetwork/drivers/remote: driver.DeleteNetwork: remove var that collided 
Remove the var, because `delete` is a builtin.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-27 20:18:30 +02:00
Sebastiaan van Stijn
40b1389917
libnetwork/drivers/remote: remove unused testEndpoint.Interface 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-27 20:18:30 +02:00
Sebastiaan van Stijn
15435f7293
libnetwork/drivers/bridge: testEndpoint.Interface: return concrete type 
Interface-matching should generally happen on the receiver side, and this
function was only used in a single location, and passed as argument to
Driver.CreateEndpoint, which already matches the interface by accepting
a driverapi.InterfaceInfo.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-27 20:13:27 +02:00
Sebastiaan van Stijn
9afb688f5f
libnetwork/drivers/bridge: getIPv4Data: remove unused argument 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-27 20:13:27 +02:00
Sebastiaan van Stijn
5b53ddfcdd
Merge pull request #46340 from thaJeztah/carry_46292_update_readme 
Update example in README.md to close cli object (carry 46292)
 2023-08-27 00:01:05 +02:00
Sebastiaan van Stijn
ebe2347ac6
daemon: remove LogPluginEventWithAttributes as it's not used 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 22:04:43 +02:00
Sebastiaan van Stijn
aa764e6009
daemon: logNetworkEvent, logSecretEvent, logConfigEvent rm unused args 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 22:04:43 +02:00
Sebastiaan van Stijn
fa13b0715f
integration/internal/swarm: rename max/min as it collides with go1.21 builtin 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 22:02:25 +02:00
Sebastiaan van Stijn
79495c5b6a
pkg/tailfile: rename max/min as it collides with go1.21 builtin 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 22:02:25 +02:00
Sebastiaan van Stijn
df2f25a977
pkg/plugins: rename max/min as it collides with go1.21 builtin 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 22:02:25 +02:00
Sebastiaan van Stijn
6c036f267f
pkg/sysinfo: rename max/min as it collides with go1.21 builtin 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 22:02:25 +02:00
Sebastiaan van Stijn
55192de9e3
pkg/archive: rename max/min as it collides with go1.21 builtin 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 22:02:25 +02:00
Sebastiaan van Stijn
a3867992b7
daemon: rename max/min as it collides with go1.21 builtin 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 22:02:21 +02:00
msadiq058
f6b2e34268
Update example in README.md to close cli object 
Signed-off-by: Mohd Sadiq <mohdsadiq058@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 19:55:45 +02:00
Sebastiaan van Stijn
318b3d4fe5
api/types/versions: rename max/min as it collides with go1.21 builtin 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 19:38:47 +02:00
Sebastiaan van Stijn
cb394a62e5
restartmanager: rename max/min as it collides with go1.21 builtin 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 19:37:19 +02:00
Sebastiaan van Stijn
8f64e2e925
daemon: daemon.logClusterEvent: use events.Type for event-types 
Also swapping the order of arguments; putting the "attributes" arguments
last, so that variables can be more cleanly inlined.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 19:20:42 +02:00
Sebastiaan van Stijn
3dea2f230a
daemon: inline some vars when producing events 
Also moves the clusterEventAction closer to where it's used.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 17:45:21 +02:00
Sebastiaan van Stijn
634f6ec1d4
Merge pull request #46333 from thaJeztah/remove_devicemapper_leftovers 
hack, Dockerfile: remove devicemapper leftover,  build-tags, and libdevmapper-dev dependency
 2023-08-26 16:42:58 +02:00
Sebastiaan van Stijn
385f6429be
api/server/router/network: remove empty file 
The content of this file was removed in c0bc14e8dd,
and all it container since was the package name.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 12:51:19 +02:00
Sebastiaan van Stijn
350223201e
integration/container: TestCheckpoint: remove intermediate vars 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 12:44:16 +02:00
Sebastiaan van Stijn
b688af2226
api/types: move checkpoint-types to api/types/checkpoint 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-26 12:37:41 +02:00
Sebastiaan van Stijn
70baaec6a5
Dockerfile: remove libdevmapper-dev 
The devicemapper graphdriver has been removed in commit
dc11d2a2d8, and we should
no longer need this.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-25 16:46:16 +02:00
Sebastiaan van Stijn
12d1f4f385
hack: remove devicemapper leftovers and build-tags 
This check was added in 98fe4bd8f1, to check
whether dm_task_deferred_remove could be removed, and to conditionally set
the corresponding build-tags. Now that the devicemapper graphdriver has been
removed in dc11d2a2d8, we no longer need this.

This patch:

- removes uses of the (no longer used) `libdm`, `dlsym_deferred_remove`,
  and `libdm_no_deferred_remove` build-tags.
- removes the `add_buildtag` utility, which is now unused.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-25 16:39:33 +02:00
Sebastiaan van Stijn
3e5b2a6ef6
Merge pull request #46323 from thaJeztah/api_docs_update_urls 
docs: update links to Go documentation
 2023-08-25 14:14:39 +02:00
Sebastiaan van Stijn
4824c60893
Merge pull request #46324 from thaJeztah/hack_less_redirects 
Dockerfile: Windows: update Golang download domains to cut down redirects
 2023-08-25 13:49:32 +02:00
Sebastiaan van Stijn
f6a5318f94
Dockerfile: Windows: update Golang download domains to cut down redirects 
The `golang.org` domain moved to `go.dev`, and the download-URLs we were
using resulted in 2 redirects;

    curl -sI https://golang.org/dl/go1.20.windows-amd64.zip | grep 'location'
    location: https://go.dev/dl/go1.20.windows-amd64.zip

    curl -sI https://go.dev/dl/go1.20.windows-amd64.zip | grep 'location'
    location: https://dl.google.com/go/go1.20.windows-amd64.zip

    curl -sI https://dl.google.com/go/go1.20.windows-amd64.zip
    HTTP/2 200
    # ...

This patch cuts it down to one redirects. I decided not to use the "final"
(`dl.google.com`) URL, because that URL is not documented in the Golang docs,
and visiting the domain itself (https://dl.google.com/) redirects to a marketing
page for "Google Chrome".

Trying the `/go/` path (https://dl.google.com/go/) also does not show a landing
page that lists downloads, so I'm considering those URLs to be "unstable".

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-25 12:53:19 +02:00
Sebastiaan van Stijn
2aabd64477
hack: update link to GOPATH documentation 
This documentation moved to a different page, and the Go documentation
moved to the https://go.dev/ domain.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-25 12:53:19 +02:00
Sebastiaan van Stijn
b18e170631
CONTRIBUTING.md: update links to golang docs and blog 
- docs moved to https://go.dev/doc/
- blog moved to https://go.dev/blog/

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-25 12:43:31 +02:00
Sebastiaan van Stijn
136e86bb5c
api: swagger: update link to Go documentation 
Go documentation moved to the `go.dev` domain;

    curl -sI https://golang.org/doc/install/source#environment | grep 'location'
    location: https://go.dev/doc/install/source

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-25 12:43:30 +02:00
Sebastiaan van Stijn
4862d39144
docs/api: update links to Go documentation 
Go documentation moved to the `go.dev` domain;

    curl -sI https://golang.org/doc/install/source#environment | grep 'location'
    location: https://go.dev/doc/install/source

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-25 12:43:30 +02:00
Sebastiaan van Stijn
b249376bb0
Merge pull request #46321 from thaJeztah/update_golangci_lint 
update golangci-lint to v1.54.2
 2023-08-25 12:43:07 +02:00
Sebastiaan van Stijn
cd49f9affd
update golangci-lint to v1.54.2 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-25 02:19:35 +02:00
Sebastiaan van Stijn
6d5204b63e
Merge pull request #46316 from thaJeztah/rm_more_buildtags 
remove some remaining pre-go1.17 build-tags
 2023-08-25 01:06:39 +02:00
Sebastiaan van Stijn
f10e182ca7
Merge pull request #46317 from thaJeztah/gofumpt_all_the_things 
Format code with gofumpt
 2023-08-25 01:06:05 +02:00
Sebastiaan van Stijn
cfd431d4d5
Merge pull request #46211 from thaJeztah/daemon_error_cleanup 
daemon: WithNamespaces(): improve error-handling, and assorted cleanups
 2023-08-24 19:23:18 +02:00
Sebastiaan van Stijn
d52f20048d
api/server: format code with gofumpt 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-24 18:00:19 +02:00
Sebastiaan van Stijn
e9b09b49fd
builder/builder-next: format code with gofumpt 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-24 17:59:50 +02:00
Sebastiaan van Stijn
73894af9ff
contrib/apparmor: format code with gofumpt 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-24 17:59:35 +02:00
Sebastiaan van Stijn
ce01d779df
daemon: format code with gofumpt 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-24 17:59:22 +02:00
Sebastiaan van Stijn
211d3a8c32
pkg/stack: format code with gofumpt 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-24 17:59:01 +02:00
Sebastiaan van Stijn
95e99e629c
pkg/fileutils: format code with gofumpt 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-24 17:58:46 +02:00
Sebastiaan van Stijn
6c6e1fb13d
pkg/containerfs: format code with gofumpt 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-24 17:58:32 +02:00
Sebastiaan van Stijn
1e579a7a2a
pkg/sysinfo: format code with gofumpt 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-24 17:58:12 +02:00
Sebastiaan van Stijn
263c00f27c
testutil: format code with gofumpt 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2023-08-24 17:57:54 +02:00