beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

staticcheck: SA4001: &*x will be simplified to x. It will not copy x

Browse source 
daemon/volumes_unix_test.go:228:13: SA4001: &*x will be simplified to x. It will not copy x. (staticcheck)
                mp:      &(*c.MountPoints["/jambolan"]), // copy the mountpoint, expect no changes
                         ^
    daemon/logger/local/local_test.go:214:22: SA4001: &*x will be simplified to x. It will not copy x. (staticcheck)
            dst.PLogMetaData = &(*src.PLogMetaData)
                               ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit f7433d6190)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2021-04-16 16:28:10 +02:00
parent 7573e32577
commit fadf8bbdff
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
2 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
daemon/logger/local/local_test.go
View file

@ -211,7 +211,8 @@ func copyLogMessage(src *logger.Message) *logger.Message {
dst.Err = src.Err
dst.Line = append(dst.Line, src.Line...)
if src.PLogMetaData != nil {
dst.PLogMetaData = &(*src.PLogMetaData)
lmd := *src.PLogMetaData
dst.PLogMetaData = &lmd
}
return dst
}

4
daemon/volumes_unix_test.go
View file

@ -97,6 +97,8 @@ func TestBackportMountSpec(t *testing.T) {
return string(b)
}
mpc := *c.MountPoints["/jambolan"]
for _, x := range []expected{
{
mp: &volumemounts.MountPoint{
@ -226,7 +228,7 @@ func TestBackportMountSpec(t *testing.T) {
comment: "partially configured named volume caused by #32613",
},
{
mp: &(*c.MountPoints["/jambolan"]), // copy the mountpoint, expect no changes
mp: &mpc,
comment: "volume defined in mounts API",
},
{