beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

info: add warnings about missing blkio cgroup support

Browse source 
These warnings were only logged, and could therefore be overlooked
by users. This patch makes these more visible by returning them as
warnings in the API response.

We should probably consider adding "boolean" (?) fields for these
as well, so that they can be consumed in other ways. In addition,
some of these warnings could potentially be grouped to reduce the
number of warnings that are printed.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2020-06-08 17:16:01 +02:00
parent 2dd0134589
commit d378625554
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
1 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
daemon/info_unix.go
View file

@ -124,6 +124,25 @@ func (daemon *Daemon) fillPlatformInfo(v *types.Info, sysInfo *sysinfo.SysInfo)
if v.CgroupVersion == "2" {
v.Warnings = append(v.Warnings, "WARNING: Support for cgroup v2 is experimental")
}
// TODO add fields for these options in types.Info
if !sysInfo.BlkioWeight {
v.Warnings = append(v.Warnings, "WARNING: No blkio weight support")
}
if !sysInfo.BlkioWeightDevice {
v.Warnings = append(v.Warnings, "WARNING: No blkio weight_device support")
}
if !sysInfo.BlkioReadBpsDevice {
v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.read_bps_device support")
}
if !sysInfo.BlkioWriteBpsDevice {
v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.write_bps_device support")
}
if !sysInfo.BlkioReadIOpsDevice {
v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.read_iops_device support")
}
if !sysInfo.BlkioWriteIOpsDevice {
v.Warnings = append(v.Warnings, "WARNING: No blkio throttle.write_iops_device support")
}
}
if !v.IPv4Forwarding {
v.Warnings = append(v.Warnings, "WARNING: IPv4 forwarding is disabled")