integration: copy loop variable into parallel test closures
Discovered a few instances, where loop variable is incorrectly used
within a test closure, which is marked as parallel.
Few of these were actually loops over singleton slices, therefore the issue
might not have surfaced there (yet), but it is good to fix there as
well, as this is an incorrect pattern used across different tests.
Signed-off-by: Roman Volosatovs <roman.volosatovs@docker.com>
(cherry picked from commit dd01abf9bf
)
Signed-off-by: Cory Snider <csnider@mirantis.com>
This commit is contained in:
parent
d69ed28a75
commit
c643f0e48f
4 changed files with 5 additions and 0 deletions
|
@ -19,6 +19,7 @@ func TestContainerInvalidJSON(t *testing.T) {
|
|||
}
|
||||
|
||||
for _, ep := range endpoints {
|
||||
ep := ep
|
||||
t.Run(ep, func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
|
|
|
@ -72,6 +72,7 @@ func TestNetworkInvalidJSON(t *testing.T) {
|
|||
}
|
||||
|
||||
for _, ep := range endpoints {
|
||||
ep := ep
|
||||
t.Run(ep, func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
|
@ -105,6 +106,7 @@ func TestNetworkList(t *testing.T) {
|
|||
}
|
||||
|
||||
for _, ep := range endpoints {
|
||||
ep := ep
|
||||
t.Run(ep, func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
|
|
|
@ -35,6 +35,7 @@ func TestPluginInvalidJSON(t *testing.T) {
|
|||
endpoints := []string{"/plugins/foobar/set"}
|
||||
|
||||
for _, ep := range endpoints {
|
||||
ep := ep
|
||||
t.Run(ep, func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
|
|
|
@ -110,6 +110,7 @@ func TestVolumesInvalidJSON(t *testing.T) {
|
|||
endpoints := []string{"/volumes/create"}
|
||||
|
||||
for _, ep := range endpoints {
|
||||
ep := ep
|
||||
t.Run(ep, func(t *testing.T) {
|
||||
t.Parallel()
|
||||
|
||||
|
|
Loading…
Reference in a new issue