beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #39360 from emosbaugh/logging-rate-limiter-bucket-fix

Browse source 
Fix rate limiting for logger, increase refill rate
This commit is contained in:
Sebastiaan van Stijn 2019-06-24 23:49:29 +02:00 committed by GitHub
commit c2deb9f97f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
daemon/cluster/executor/container/controller.go
View file

@ -508,7 +508,9 @@ func (r *controller) Logs(ctx context.Context, publisher exec.LogPublisher, opti
var ( var (
// use a rate limiter to keep things under control but also provides some // use a rate limiter to keep things under control but also provides some
// ability coalesce messages. // ability coalesce messages.
limiter = rate.NewLimiter(rate.Every(time.Second), 10<<20) // 10 MB/s // this will implement a "token bucket" of size 10 MB, initially full and refilled
// at rate 10 MB tokens per second.
limiter = rate.NewLimiter(10<<20, 10<<20) // 10 MB/s
msgctx = api.LogContext{ msgctx = api.LogContext{
NodeID: r.task.NodeID, NodeID: r.task.NodeID,
ServiceID: r.task.ServiceID, ServiceID: r.task.ServiceID,